mlx5: some independent fixes
cover mlx5: some independent fixes
Some independent fixes in mlx5 net and common driver.
Michael Baum (6):
net/mlx5: fix shared device context creation error flow net/mlx5: fix PCI probing error flow
net/mlx5: fix allow duplicate pattern devarg default common/mlx5: fix class combination validation common/mlx5: fix device list operation concurrency common/mlx5: fix resource cleanliness in a device remove
drivers/common/mlx5/mlx5_common.c | 26 +++++++++++++++++--------- drivers/net/mlx5/linux/mlx5_os.c | 15 +++++++++++++-- drivers/net/mlx5/mlx5.c | 4 +++- drivers/net/mlx5/mlx5.h | 1 + 4 files changed, 34 insertions(+), 12 deletions(-)
Signature · 1 line
2.25.1
PATCH 1/6 net/mlx5: fix shared device context creation error flow
In shared device context creation, there are two validations after MR btree memory allocation.
When one of them fails, the MR btree memory was not freed what caused a memory leak.
Free it.
--- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/mlx5/mlx5.c +2 -0
@@ -1254,6 +1254,8 @@ mlx5_alloc_shared_dev_ctx(const struct mlx5_dev_spawn_data *spawn,MLX5_ASSERT (sh);if (sh->cnt_id_tbl)mlx5_l3t_destroy (sh->cnt_id_tbl); +if (sh->share_cache.cache.table) +mlx5_mr_btree_free (&sh->share_cache.cache);if (sh->tis)claim_zero (mlx5_devx_cmd_destroy (sh->tis));if (sh->td)
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH 1/6] net/mlx5: fix shared device context creation error flow
Hi,
Quoted 8 lines
-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Tuesday, August 31, 2021 11:37 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [PATCH 1/6] net/mlx5: fix shared device context creation error flow
How about something like this:
fix memory leak in the shared device context creation
Quoted 8 lines
In shared device context creation, there are two validations after MR btree memory allocation.
When one of them fails, the MR btree memory was not freed what caused a memory leak.
Free it.
How about changing it to something like this:
In shared device context creation, there is a missing validation when one of the btree memory allocation fails that will cause a memory leak.
This adds a proper check to clean resources in case of failure.
Quoted 26 lines
Fixes 632f0f19056f ("net/mlx5: manage shared counters in three-leveltable")
Cc: [email protected]Signed-off-by Michael Baum <[email protected]>--- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+)drivers/net/mlx5/mlx5.c +2
-0@@ -1254,6 +1254,8 @@ mlx5_alloc_shared_dev_ctx(const structmlx5_dev_spawn_data *spawn,MLX5_ASSERT (sh );if (sh->cnt_id_tbl)mlx5_l3t_destroy (sh->cnt_id_tbl); +if (sh->share_cache.cache.table) +mlx5_mr_btree_free (&sh->share_cache.cache);if (sh->tis)claim_zero (mlx5_devx_cmd_destroy (sh->tis));if (
sh->td)
--
2.25.1
PATCH 2/6 net/mlx5: fix PCI probing error flow
In reply to Michael BaumIn PCI probing, there is internal probe function that is called several times for several PFs.
When one of them fails, the previous PFs are not destroyed what may cause a memory leak.
Destroy them.
--- drivers/net/mlx5/linux/mlx5_os.c | 13 ++++++++++++- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5.h | 1 + 3 files changed, 14 insertions(+), 2 deletions(-)
drivers/net/mlx5/linux/mlx5_os.c +12 -1
@@ -2700,9 +2700,20 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev)if (eth_da.nb_ports >0 ) {/* Iterate all port if devargs pf is range: "pf[0-1]vf[...]". */ -for (p =0 ; p < eth_da.nb_ports; p++) +for (p =0 ; p < eth_da.nb_ports; p++) { ret =mlx5_os_pci_probe_pf (pci_dev, ð_da, eth_da.ports[p]); +if (ret) +break ; + } +if (ret) { +DRV_LOG (ERR ,"Probe of PCI device " PCI_PRI_FMT " " +"aborted due to proding failure of PF %u" , + pci_dev->addr.domain, pci_dev->addr.bus, + pci_dev->addr.devid, pci_dev->addr.function, + eth_da.ports[p]); +mlx5_net_remove (&pci_dev->device); + } }else { ret =mlx5_os_pci_probe_pf (pci_dev, ð_da,0 ); }
drivers/net/mlx5/mlx5.c +1 -1
@@ -2386,7 +2386,7 @@ mlx5_eth_find_next(uint16_t port_id, struct rte_device *odev)* @return * 0 on success, the function cannot fail. */ -static int +int mlx5_net_remove (struct rte_device *dev) {uint16_t port_id;
drivers/net/mlx5/mlx5.h +1 -0
@@ -1483,6 +1483,7 @@ int mlx5_udp_tunnel_port_add(struct rte_eth_dev *dev, struct rte_eth_udp_tunnel *udp_tunnel);uint16_t mlx5_eth_find_next (uint16_t port_id,struct rte_device *odev);int mlx5_dev_close (struct rte_eth_dev *dev); +int mlx5_net_remove (struct rte_device *dev);bool mlx5_is_hpf (struct rte_eth_dev *dev);bool mlx5_is_sf_repr (struct rte_eth_dev *dev);void mlx5_age_event_prepare (struct mlx5_dev_ctx_shared *sh);
Signature · 1 line
2.25.1
Re: [dpdk-dev] [PATCH 2/6] net/mlx5: fix PCI probing error flow
Hi,
Quoted 9 lines
-----Original Message-----
From: Michael Baum <[email protected]>
Sent: Tuesday, August 31, 2021 11:37 PM
To: [email protected]
Cc: Matan Azrad <[email protected]>; Raslan Darawsheh <[email protected]>; Slava Ovsiienko <[email protected]>; [email protected]
Subject: [PATCH 2/6] net/mlx5: fix PCI probing error flow
How about changing to something like this:
Fix memory leak in PCI prob
Quoted 2 lines
In PCI probing, there is internal probe function that is called several times for several PFs.
During PCI probe, the internal probe function is called per PF.
Quoted 3 lines
When one of them fails, the previous PFs are not destroyed what may cause a memory leak.
If one of them fails, it was missing a prober destroy for the previously probed PFs
Quoted 2 lines
Destroy them.
This fixes the behavior by destroying all previously probed PF's
Quoted 69 lines
Fixes 08c2772fc747 ("net/mlx5: support list of representor PF")Signed-off-by Michael Baum <[email protected]>--- drivers/net/mlx5/linux/mlx5_os.c | 13 ++++++++++++- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5.h | 1 + 3 files changed, 14 insertions(+), 2 deletions(-)drivers/net/mlx5/linux/mlx5_os.c +6
-1@@ -2700,9 +2700,20 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev) if (eth_da.nb_ports > 0) { /* Iterate all port if devargs pf is range: "pf[0-1]vf[...]". */ -for (p =0 ; p < eth_da.nb_ports; p++) + for (p = 0; p < eth_da.nb_ports; p++) { ret = mlx5_os_pci_probe_pf(pci_dev, ð_da, eth_da.ports[p]); + if (ret) + break; + } + if (ret) { + DRV_LOG(ERR, "Probe of PCI device " PCI_PRI_FMT ""
drivers/net/mlx5/linux/mlx5_os.c +3
-0+"aborted due to proding failure of PF %u" , + pci_dev->addr.domain, pci_dev->addr.bus, + pci_dev->addr.devid, pci_dev-Quoted 1 line
addr.function,
drivers/net/mlx5/linux/mlx5_os.c +3
-0+ eth_da.ports[p]); +mlx5_net_remove (&pci_dev->device); + } }else { ret =mlx5_os_pci_probe_pf (pci_dev, ð_da,0 ); }drivers/net/mlx5/mlx5.c index renamed from drivers/net/mlx5/mlx5.c +0
-0
f0ec2d1279..02ea2e781e100644drivers/net/mlx5/mlx5.c +1
-1@@ -2386,7 +2386,7 @@ mlx5_eth_find_next(uint16_t port_id, structrte_device *odev) * @return * 0 on success, the function cannot fail. */ -static int +int mlx5_net_remove (struct rte_device *dev) {uint16_t port_id;drivers/net/mlx5/mlx5.h index renamed from drivers/net/mlx5/mlx5.h +0
-0
e02714e231..3581414b78100644drivers/net/mlx5/mlx5.h +0
-0@@ -1483,6 +1483,7 @@ int mlx5_udp_tunnel_port_add(struct rte_eth_dev *dev, struct rte_eth_udp_tunnel *udp_tunnel);
uint16_tmlx5_eth_find_next(uint16_t port_id, struct rte_device *odev); intmlx5_dev_close(struct rte_eth_dev *dev);
+intmlx5_net_remove(struct rte_device *dev);
boolmlx5_is_hpf(struct rte_eth_dev *dev); bool mlx5_is_sf_repr(structrte_eth_dev*dev); voidmlx5_age_event_prepare(struct mlx5_dev_ctx_shared *sh);
--
2.25.1
PATCH 3/6 net/mlx5: fix allow duplicate pattern devarg default
In reply to Michael BaumIn order to allow\disallow configuring rules with identical patterns, the new device argument 'allow_duplicate_pattern' was introduced.
The default is to allow, and it is initialized to 1 in PCI probe function.
However, on auxiliary bus probing (for Sub-Function) it is not initialized at all, so it's actually initialized to 0
Move the initialization to default config function which is called from both.
--- drivers/net/mlx5/linux/mlx5_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/linux/mlx5_os.c +1 -1
@@ -2142,6 +2142,7 @@ mlx5_os_config_default(struct mlx5_dev_config *config) config->dv_flow_en =1 ; config->decap_en =1 ; config->log_hp_size =MLX5_ARG_UNSET ; + config->allow_duplicate_pattern =1 ; }/**
@@ -2564,7 +2565,6 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,/* Default configuration. */ mlx5_os_config_default (&dev_config); dev_config.vf = dev_config_vf; - dev_config.allow_duplicate_pattern =1 ; list[i].numa_node = pci_dev->device.numa_node; list[i].eth_dev = mlx5_dev_spawn(&pci_dev->device, &list[i],
Signature · 1 line
2.25.1
PATCH 4/6 common/mlx5: fix class combination validation
In reply to Michael BaumThe common probe function gets as a user argument the classes it should create, and checks whether the combination is valid.
In case the device already exists, it checks the integration of the above with the classes that the device has.
However, the function does not check the combination when the device does not exist and it has to create it.
Check if the combination is valid for all cases.
--- drivers/common/mlx5/mlx5_common.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/common/mlx5/mlx5_common.c +10 -8
@@ -317,14 +317,16 @@ mlx5_common_dev_probe(struct rte_device *eal_dev) dev->dev = eal_dev;TAILQ_INSERT_HEAD (&devices_list, dev, next); new_device = true; - }else { -/* Validate combination here. */ - ret =is_valid_class_combination (classes | - dev->classes_loaded); -if (ret !=0 ) { -DRV_LOG (ERR ,"Unsupported mlx5 classes combination." ); -return ret; - } + } +/* +* Validate combination here. +* For new device, the classes_loaded field is 0 and it check only +* the classes given as user device arguments. +*/ + ret =is_valid_class_combination (classes | dev->classes_loaded); +if (ret !=0 ) { +DRV_LOG (ERR ,"Unsupported mlx5 classes combination." ); + goto class_err; } ret =drivers_probe (dev, classes);if (ret)
Signature · 1 line
2.25.1
PATCH 5/6 common/mlx5: fix device list operation concurrency
In reply to Michael BaumThe MLX5 common driver has a global list of mlx5 devices which are probed.
In probe function it create one and insert it to the list. Similarly it removes the device in remove function.
These operations are not safe as there can be such operations in parallel, by different threads.
Add global lock for the list and use it to insert or remove.
--- drivers/common/mlx5/mlx5_common.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/common/mlx5/mlx5_common.c +6 -0
@@ -50,6 +50,7 @@ static TAILQ_HEAD(mlx5_drivers, mlx5_class_driver) drivers_list =/* Head of devices. */ static TAILQ_HEAD(mlx5_devices, mlx5_common_device) devices_list =TAILQ_HEAD_INITIALIZER (devices_list); +static pthread_mutex_t devices_list_lock; static const struct { const char *name;
@@ -222,7 +223,9 @@ mlx5_dev_to_pci_str(const struct rte_device *dev, char *addr, size_t size)static void dev_release (struct mlx5_common_device *dev) { +pthread_mutex_lock (&devices_list_lock);TAILQ_REMOVE (&devices_list, dev, next); +pthread_mutex_unlock (&devices_list_lock);rte_free (dev); }
@@ -315,7 +318,9 @@ mlx5_common_dev_probe(struct rte_device *eal_dev)if (!dev)return -ENOMEM ; dev->dev = eal_dev; +pthread_mutex_lock (&devices_list_lock);TAILQ_INSERT_HEAD (&devices_list, dev, next); +pthread_mutex_unlock (&devices_list_lock); new_device = true; }/*
@@ -440,6 +445,7 @@ mlx5_common_init(void)if (mlx5_common_initialized)return ; +pthread_mutex_init (&devices_list_lock,NULL );mlx5_glue_constructor ();mlx5_common_driver_init (); mlx5_common_initialized = true;
Signature · 1 line
2.25.1
PATCH 6/6 common/mlx5: fix resource cleanliness in a device remove
In reply to Michael BaumThe common remove function call in a loop to remove function for each driver which have been registered.
If all removes are succeeded, it return 0 without to free the device which allocated in probe function. Otherwise, it free the device. In fact we expect exactly the opposite behavior. If all removes are failed, it return error without to free the device which allocated in probe function. Otherwise, it free the device and return 0.
Replace it with the correct behavior.
--- drivers/common/mlx5/mlx5_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/mlx5/mlx5_common.c +1 -1
@@ -354,7 +354,7 @@ mlx5_common_dev_remove(struct rte_device *eal_dev)return -ENODEV ;/* Matching device found, cleanup and unload drivers. */ ret =drivers_remove (dev, dev->classes_loaded); -if (ret !=0 ) +if (ret ==0 )dev_release (dev);return ret; }
Signature · 1 line
2.25.1
From: Michael Baum
Quoted 10 lines
Some independent fixes in mlx5 net and common driver.
Michael Baum (6):
net/mlx5: fix shared device context creation error flow net/mlx5: fix PCI probing error flow
net/mlx5: fix allow duplicate pattern devarg default common/mlx5: fix class combination validation common/mlx5: fix device list operation concurrency common/mlx5: fix resource cleanliness in a device remove
Quoted 5 lines
drivers/common/mlx5/mlx5_common.c | 26 +++++++++++++++++--------- drivers/net/mlx5/linux/mlx5_os.c | 15 +++++++++++++-- drivers/net/mlx5/mlx5.c | 4 +++- drivers/net/mlx5/mlx5.h | 1 + 4 files changed, 34 insertions(+), 12 deletions(-)
Quoted 2 lines
--
2.25.1
v2 cover mlx5: some independent fixes
In reply to Michael BaumSome independent fixes in mlx5 net and common driver.
v2: improve commit logs.
Michael Baum (6):
net/mlx5: fix memory leak in the SH creation net/mlx5: fix memory leak in PCI probe net/mlx5: fix allow duplicate pattern devarg default common/mlx5: fix class combination validation common/mlx5: fix device list operation concurrency common/mlx5: fix resource cleanliness in a device remove
drivers/common/mlx5/mlx5_common.c | 26 +++++++++++++++++--------- drivers/net/mlx5/linux/mlx5_os.c | 15 +++++++++++++-- drivers/net/mlx5/mlx5.c | 4 +++- drivers/net/mlx5/mlx5.h | 1 + 4 files changed, 34 insertions(+), 12 deletions(-)
Signature · 1 line
2.25.1
PATCH v2 1/6 net/mlx5: fix memory leak in the SH creation
In shared device context creation, there is a missing validation when one of the btree memory allocation fails that will cause a memory leak.
This adds a proper check to clean resources in case of failure.
--- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/mlx5/mlx5.c +2 -0
@@ -1254,6 +1254,8 @@ mlx5_alloc_shared_dev_ctx(const struct mlx5_dev_spawn_data *spawn,MLX5_ASSERT (sh);if (sh->cnt_id_tbl)mlx5_l3t_destroy (sh->cnt_id_tbl); +if (sh->share_cache.cache.table) +mlx5_mr_btree_free (&sh->share_cache.cache);if (sh->tis)claim_zero (mlx5_devx_cmd_destroy (sh->tis));if (sh->td)
Signature · 1 line
2.25.1
PATCH v2 2/6 net/mlx5: fix memory leak in PCI probe
In reply to Michael BaumDuring PCI probe, the internal probe function is called per PF.
If one of them fails, it was missing a prober destroy for the previously probed PFs.
This fixes the behavior by destroying all previously probed PFs.
--- drivers/net/mlx5/linux/mlx5_os.c | 13 ++++++++++++- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5.h | 1 + 3 files changed, 14 insertions(+), 2 deletions(-)
drivers/net/mlx5/linux/mlx5_os.c +12 -1
@@ -2700,9 +2700,20 @@ mlx5_os_pci_probe(struct rte_pci_device *pci_dev)if (eth_da.nb_ports >0 ) {/* Iterate all port if devargs pf is range: "pf[0-1]vf[...]". */ -for (p =0 ; p < eth_da.nb_ports; p++) +for (p =0 ; p < eth_da.nb_ports; p++) { ret =mlx5_os_pci_probe_pf (pci_dev, ð_da, eth_da.ports[p]); +if (ret) +break ; + } +if (ret) { +DRV_LOG (ERR ,"Probe of PCI device " PCI_PRI_FMT " " +"aborted due to proding failure of PF %u" , + pci_dev->addr.domain, pci_dev->addr.bus, + pci_dev->addr.devid, pci_dev->addr.function, + eth_da.ports[p]); +mlx5_net_remove (&pci_dev->device); + } }else { ret =mlx5_os_pci_probe_pf (pci_dev, ð_da,0 ); }
drivers/net/mlx5/mlx5.c +1 -1
@@ -2386,7 +2386,7 @@ mlx5_eth_find_next(uint16_t port_id, struct rte_device *odev)* @return * 0 on success, the function cannot fail. */ -static int +int mlx5_net_remove (struct rte_device *dev) {uint16_t port_id;
drivers/net/mlx5/mlx5.h +1 -0
@@ -1483,6 +1483,7 @@ int mlx5_udp_tunnel_port_add(struct rte_eth_dev *dev, struct rte_eth_udp_tunnel *udp_tunnel);uint16_t mlx5_eth_find_next (uint16_t port_id,struct rte_device *odev);int mlx5_dev_close (struct rte_eth_dev *dev); +int mlx5_net_remove (struct rte_device *dev);bool mlx5_is_hpf (struct rte_eth_dev *dev);bool mlx5_is_sf_repr (struct rte_eth_dev *dev);void mlx5_age_event_prepare (struct mlx5_dev_ctx_shared *sh);
Signature · 1 line
2.25.1
PATCH v2 3/6 net/mlx5: fix allow duplicate pattern devarg default
In reply to Michael BaumIn order to allow\disallow configuring rules with identical patterns, the new device argument 'allow_duplicate_pattern' was introduced.
The default is to allow, and it is initialized to 1 in PCI probe function.
However, on auxiliary bus probing (for Sub-Function) it is not initialized at all, so it's actually initialized to 0
Move the initialization to default config function which is called from both.
--- drivers/net/mlx5/linux/mlx5_os.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/mlx5/linux/mlx5_os.c +1 -1
@@ -2142,6 +2142,7 @@ mlx5_os_config_default(struct mlx5_dev_config *config) config->dv_flow_en =1 ; config->decap_en =1 ; config->log_hp_size =MLX5_ARG_UNSET ; + config->allow_duplicate_pattern =1 ; }/**
@@ -2564,7 +2565,6 @@ mlx5_os_pci_probe_pf(struct rte_pci_device *pci_dev,/* Default configuration. */ mlx5_os_config_default (&dev_config); dev_config.vf = dev_config_vf; - dev_config.allow_duplicate_pattern =1 ; list[i].numa_node = pci_dev->device.numa_node; list[i].eth_dev = mlx5_dev_spawn(&pci_dev->device, &list[i],
Signature · 1 line
2.25.1
PATCH v2 4/6 common/mlx5: fix class combination validation
In reply to Michael BaumThe common probe function gets as a user argument the classes it should create, and checks whether the combination is valid.
In case the device already exists, it checks the integration of the above with the classes that the device has.
However, the function does not check the combination when the device does not exist and it has to create it.
Check if the combination is valid for all cases.
--- drivers/common/mlx5/mlx5_common.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
drivers/common/mlx5/mlx5_common.c +10 -8
@@ -317,14 +317,16 @@ mlx5_common_dev_probe(struct rte_device *eal_dev) dev->dev = eal_dev;TAILQ_INSERT_HEAD (&devices_list, dev, next); new_device = true; - }else { -/* Validate combination here. */ - ret =is_valid_class_combination (classes | - dev->classes_loaded); -if (ret !=0 ) { -DRV_LOG (ERR ,"Unsupported mlx5 classes combination." ); -return ret; - } + } +/* +* Validate combination here. +* For new device, the classes_loaded field is 0 and it check only +* the classes given as user device arguments. +*/ + ret =is_valid_class_combination (classes | dev->classes_loaded); +if (ret !=0 ) { +DRV_LOG (ERR ,"Unsupported mlx5 classes combination." ); + goto class_err; } ret =drivers_probe (dev, classes);if (ret)
Signature · 1 line
2.25.1
PATCH v2 5/6 common/mlx5: fix device list operation concurrency
In reply to Michael BaumThe MLX5 common driver has a global list of mlx5 devices which are probed.
In probe function it create one and insert it to the list. Similarly it removes the device in remove function.
These operations are not safe as there can be such operations in parallel, by different threads.
Add global lock for the list and use it to insert or remove.
--- drivers/common/mlx5/mlx5_common.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/common/mlx5/mlx5_common.c +6 -0
@@ -50,6 +50,7 @@ static TAILQ_HEAD(mlx5_drivers, mlx5_class_driver) drivers_list =/* Head of devices. */ static TAILQ_HEAD(mlx5_devices, mlx5_common_device) devices_list =TAILQ_HEAD_INITIALIZER (devices_list); +static pthread_mutex_t devices_list_lock; static const struct { const char *name;
@@ -222,7 +223,9 @@ mlx5_dev_to_pci_str(const struct rte_device *dev, char *addr, size_t size)static void dev_release (struct mlx5_common_device *dev) { +pthread_mutex_lock (&devices_list_lock);TAILQ_REMOVE (&devices_list, dev, next); +pthread_mutex_unlock (&devices_list_lock);rte_free (dev); }
@@ -315,7 +318,9 @@ mlx5_common_dev_probe(struct rte_device *eal_dev)if (!dev)return -ENOMEM ; dev->dev = eal_dev; +pthread_mutex_lock (&devices_list_lock);TAILQ_INSERT_HEAD (&devices_list, dev, next); +pthread_mutex_unlock (&devices_list_lock); new_device = true; }/*
@@ -440,6 +445,7 @@ mlx5_common_init(void)if (mlx5_common_initialized)return ; +pthread_mutex_init (&devices_list_lock,NULL );mlx5_glue_constructor ();mlx5_common_driver_init (); mlx5_common_initialized = true;
Signature · 1 line
2.25.1
PATCH v2 6/6 common/mlx5: fix resource cleanliness in a device remove
In reply to Michael BaumThe common remove function call in a loop to remove function for each driver which have been registered.
If all removes are succeeded, it return 0 without to free the device which allocated in probe function. Otherwise, it free the device. In fact we expect exactly the opposite behavior. If all removes are failed, it return error without to free the device which allocated in probe function. Otherwise, it free the device and return 0.
Replace it with the correct behavior.
--- drivers/common/mlx5/mlx5_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/common/mlx5/mlx5_common.c +1 -1
@@ -354,7 +354,7 @@ mlx5_common_dev_remove(struct rte_device *eal_dev)return -ENODEV ;/* Matching device found, cleanup and unload drivers. */ ret =drivers_remove (dev, dev->classes_loaded); -if (ret !=0 ) +if (ret ==0 )dev_release (dev);return ret; }
Signature · 1 line
2.25.1
Thomas Monjalon
Applied12/09/2021 12:36, Michael Baum:
Quoted 11 lines
Some independent fixes in mlx5 net and common driver.
v2: improve commit logs.
Michael Baum (6):
net/mlx5: fix memory leak in the SH creation net/mlx5: fix memory leak in PCI probe net/mlx5: fix allow duplicate pattern devarg default common/mlx5: fix class combination validation common/mlx5: fix device list operation concurrency common/mlx5: fix resource cleanliness in a device remove
Applied in next-net-mlx, thanks.