Skip to contentSkip to conversation

Using of Compression VBDEV

SPDK Ruslan Laishev 2 participants 9 messages Sep 13, 2021 – Sep 14, 2021

lore
Share & tools
lore

Ruslan Laishev

author
#0 lore raw

Hello!
I have created "Compression VBDEV" on top of Malloc0 BDEV.

$ sudo /data/devadm/spdk/scripts/rpc.py bdev_compress_create -p ./pmem_files -b "CryMalloc0A"
COMP_CryMalloc0A
$sudo /data/devadm/spdk/scripts/rpc.py vhost_scsi_controller_add_target vhost.0 0 COMP_CryMalloc0A
0

When I try to execute "mkfs /dev/sda" (where /dev/sda is the COMP_Malloc0 ) in the inner VM I got error on the VHOST's output:

[2021-09-13 11:32:51.759692] vbdev_compress.c: 811:_comp_bdev_io_submit: *ERROR*: Unknown I/O type 4 [2021-09-13 11:32:51.759741] vbdev_compress.c: 822:_comp_bdev_io_submit: *ERROR*: on bdev_io submission!
...

Is there what I'm need to check ?
Thanks in advance!

#1 lore raw

I/O type 4 is SPDK_BDEV_IO_TYPE_FLUSH

Looks like Compress vbdev does not support this I/O type

-----Original Message-----
From: Ruslan Laishev <zator(a)yandex.ru>
Sent: Monday, September 13, 2021 16:43
To: spdk(a)lists.01.org
Subject: [SPDK] Using of Compression VBDEV

Hello!
I have created "Compression VBDEV" on top of Malloc0 BDEV.

$ sudo /data/devadm/spdk/scripts/rpc.py bdev_compress_create -p ./pmem_files -b "CryMalloc0A"
COMP_CryMalloc0A
$sudo /data/devadm/spdk/scripts/rpc.py vhost_scsi_controller_add_target vhost.0 0 COMP_CryMalloc0A
0

When I try to execute "mkfs /dev/sda" (where /dev/sda is the COMP_Malloc0 ) in the inner VM I got error on the VHOST's output:

[2021-09-13 11:32:51.759692] vbdev_compress.c: 811:_comp_bdev_io_submit: *ERROR*: Unknown I/O type 4 [2021-09-13 11:32:51.759741] vbdev_compress.c: 822:_comp_bdev_io_submit: *ERROR*: on bdev_io submission!
...

Is there what I'm need to check ?
Thanks in advance!
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

author
#2 lore raw
Quoted 4 lines

I/O type 4 is SPDK_BDEV_IO_TYPE_FLUSH

Looks like Compress vbdev does not support this I/O type

Hello!

Do I'm need to check something in the SPDK (may be configuration option for build?) ? Or this is a problem inspired by the VM's?

#3 lore raw

I can’t remember off the top of my head why that’s not supported, Jim may recall. I’ll look through the code today and jog my memory though

Thx
Paul

From: Ruslan Laishev <zator(a)yandex.ru>
Date: Monday, September 13, 2021 at 6:50 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV

Quoted 4 lines

I/O type 4 is SPDK_BDEV_IO_TYPE_FLUSH

Looks like Compress vbdev does not support this I/O type

Hello!

Do I'm need to check something in the SPDK (may be configuration option for build?) ? Or this is a problem inspired by the VM's?
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

#4 lore raw

It’s listed in a block of other non-RW bdev IO types as TODO. I believe at the time it was just a matter of priorities. We’d need change the reporting of supported types to match the underlying device, update the reduce lib to allow the bdev module to determine which blocks are associated with the incoming range and then just plumb the flush.

I may be missing something (Jim feel free to jump in). Is this something you might be interested in working on?

Thx
Paul

From: Luse, Paul E <paul.e.luse(a)intel.com>
Date: Monday, September 13, 2021 at 7:31 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
I can’t remember off the top of my head why that’s not supported, Jim may recall. I’ll look through the code today and jog my memory though

Thx
Paul

From: Ruslan Laishev <zator(a)yandex.ru>
Date: Monday, September 13, 2021 at 6:50 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV

Quoted 4 lines

I/O type 4 is SPDK_BDEV_IO_TYPE_FLUSH

Looks like Compress vbdev does not support this I/O type

Hello!

Do I'm need to check something in the SPDK (may be configuration option for build?) ? Or this is a problem inspired by the VM's?
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

#5 lore raw

Or add a new spdk_reduce_vol_flush() API. Then the reduce library can drive the flush operations just like it does for readv/writev.

We also need support for RESET operation.

-Jim

On 9/13/21, 8:11 AM, "Luse, Paul E" <paul.e.luse(a)intel.com> wrote:

It’s listed in a block of other non-RW bdev IO types as TODO. I believe at the time it was just a matter of priorities. We’d need change the reporting of supported types to match the underlying device, update the reduce lib to allow the bdev module to determine which blocks are associated with the incoming range and then just plumb the flush.

I may be missing something (Jim feel free to jump in). Is this something you might be interested in working on?

Thx
Paul

From: Luse, Paul E <paul.e.luse(a)intel.com>
Date: Monday, September 13, 2021 at 7:31 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
I can’t remember off the top of my head why that’s not supported, Jim may recall. I’ll look through the code today and jog my memory though

Thx
Paul

From: Ruslan Laishev <zator(a)yandex.ru>
Date: Monday, September 13, 2021 at 6:50 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
> I/O type 4 is SPDK_BDEV_IO_TYPE_FLUSH
>
> Looks like Compress vbdev does not support this I/O type >

Hello!

Do I'm need to check something in the SPDK (may be configuration option for build?) ? Or this is a problem inspired by the VM's?
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

#6 lore raw

Yup yup. Rusian, let us know if you’re interested in working on these….

From: Harris, James R <james.r.harris(a)intel.com>
Date: Monday, September 13, 2021 at 9:36 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
Or add a new spdk_reduce_vol_flush() API. Then the reduce library can drive the flush operations just like it does for readv/writev.

We also need support for RESET operation.

-Jim

On 9/13/21, 8:11 AM, "Luse, Paul E" <paul.e.luse(a)intel.com> wrote:

It’s listed in a block of other non-RW bdev IO types as TODO. I believe at the time it was just a matter of priorities. We’d need change the reporting of supported types to match the underlying device, update the reduce lib to allow the bdev module to determine which blocks are associated with the incoming range and then just plumb the flush.

I may be missing something (Jim feel free to jump in). Is this something you might be interested in working on?

Thx
Paul

From: Luse, Paul E <paul.e.luse(a)intel.com>
Date: Monday, September 13, 2021 at 7:31 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
I can’t remember off the top of my head why that’s not supported, Jim may recall. I’ll look through the code today and jog my memory though

Thx
Paul

From: Ruslan Laishev <zator(a)yandex.ru>
Date: Monday, September 13, 2021 at 6:50 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
> I/O type 4 is SPDK_BDEV_IO_TYPE_FLUSH
>
> Looks like Compress vbdev does not support this I/O type >

Hello!

Do I'm need to check something in the SPDK (may be configuration option for build?) ? Or this is a problem inspired by the VM's?
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org
_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org

author
#7 lore raw

Hello!

At this nanosecond I'm not sure about of necessity of this feature in my local project. May be in a near future ...

Thanks to all for the support and explanation!

Sincerely yours, Russian/Ruslan. :-)

Quoted 46 lines

Yup yup. Rusian, let us know if you’re interested in working on these….

From: Harris, James R <james.r.harris(a)intel.com&gt;
Date: Monday, September 13, 2021 at 9:36 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org&gt;
Subject: [SPDK] Re: Using of Compression VBDEV
Or add a new spdk_reduce_vol_flush() API. Then the reduce library can drive the flush operations just like it does for readv/writev.

We also need support for RESET operation.

-Jim

On 9/13/21, 8:11 AM, "Luse, Paul E" <paul.e.luse(a)intel.com&gt; wrote:

It’s listed in a block of other non-RW bdev IO types as TODO. I believe at the time
it was just a matter of priorities. We’d need change the reporting of supported types to match the underlying device, update the reduce lib to allow the bdev module to determine which blocks are associated with the incoming range and then just plumb the flush.

I may be missing something (Jim feel free to jump in). Is this something you might be
interested in working on?

    Thx
    Paul

    From: Luse, Paul E <paul.e.luse(a)intel.com&gt;
    Date: Monday, September 13, 2021 at 7:31 AM
    To: Storage Performance Development Kit <spdk(a)lists.01.org&gt;
    Subject: [SPDK] Re: Using of Compression VBDEV
    I can’t remember off the top of my head why that’s not supported, Jim may recall. 

I’ll look through the code today and jog my memory though

    Thx
    Paul

    From: Ruslan Laishev <zator(a)yandex.ru&gt;
    Date: Monday, September 13, 2021 at 6:50 AM
    To: spdk(a)lists.01.org <spdk(a)lists.01.org&gt;
    Subject: [SPDK] Re: Using of Compression VBDEV

    Hello!

    Do I'm need to check something in the SPDK (may be configuration option for

build?) ? Or this is a problem inspired by the VM's?

#8 lore raw

Hi Rusian,

As it turns out Monica on the team here in AZ is interested in working on this… look for it over the coming weeks ☺

Thanks
Paul

From: Ruslan Laishev <zator(a)yandex.ru>
Date: Tuesday, September 14, 2021 at 4:05 AM
To: spdk(a)lists.01.org <spdk(a)lists.01.org>
Subject: [SPDK] Re: Using of Compression VBDEV
Hello!

At this nanosecond I'm not sure about of necessity of this feature in my local project. May be in a near future ...

Thanks to all for the support and explanation!

Sincerely yours, Russian/Ruslan. :-)

Quoted 45 lines

Yup yup. Rusian, let us know if you’re interested in working on these….

From: Harris, James R <james.r.harris(a)intel.com&gt;
Date: Monday, September 13, 2021 at 9:36 AM
To: Storage Performance Development Kit <spdk(a)lists.01.org&gt;
Subject: [SPDK] Re: Using of Compression VBDEV
Or add a new spdk_reduce_vol_flush() API. Then the reduce library can drive the flush operations just like it does for readv/writev.

We also need support for RESET operation.

-Jim

On 9/13/21, 8:11 AM, "Luse, Paul E" <paul.e.luse(a)intel.com&gt; wrote:

It’s listed in a block of other non-RW bdev IO types as TODO. I believe at the time
it was just a matter of priorities. We’d need change the reporting of supported types to match the underlying device, update the reduce lib to allow the bdev module to determine which blocks are associated with the incoming range and then just plumb the flush.

I may be missing something (Jim feel free to jump in). Is this something you might be
interested in working on?

    Thx
    Paul

    From: Luse, Paul E <paul.e.luse(a)intel.com&gt;
    Date: Monday, September 13, 2021 at 7:31 AM
    To: Storage Performance Development Kit <spdk(a)lists.01.org&gt;
    Subject: [SPDK] Re: Using of Compression VBDEV
    I can’t remember off the top of my head why that’s not supported, Jim may recall.

I’ll look through the code today and jog my memory though

    Thx
    Paul

    From: Ruslan Laishev <zator(a)yandex.ru&gt;
    Date: Monday, September 13, 2021 at 6:50 AM
    To: spdk(a)lists.01.org <spdk(a)lists.01.org&gt;
    Subject: [SPDK] Re: Using of Compression VBDEV

    Hello!

    Do I'm need to check something in the SPDK (may be configuration option for
Quoted 1 line

build?) ? Or this is a problem inspired by the VM's?

_______________________________________________
SPDK mailing list -- spdk(a)lists.01.org
To unsubscribe send an email to spdk-leave(a)lists.01.org