drm/i915/gem: Break out some shmem backend utils
Subsystems (4)
Matthew Auld
reviewerPATCH v2 1/7 drm/i915/gem: Break out some shmem backend utils
From: Thomas Hellström <[email protected]>
Break out some shmem backend utils for future reuse by the TTM backend:shmem_alloc_st(), shmem_free_st() and __shmem_writeback() which we can use to provide a shmem-backed TTM page pool for cached-only TTM buffer objects.
Main functional change here is that we now compute the page sizes using the dma segments rather than using the physical page address segments.
v2(Reported-by: kernel test robot <[email protected]>)
- Make sure we initialise the mapping on the error path in shmem_get_pages()
--- drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 181 +++++++++++++--------- 1 file changed, 106 insertions(+), 75 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +106 -75
@@ -25,46 +25,61 @@ static void check_release_pagevec(struct pagevec *pvec)cond_resched (); } -static int shmem_get_pages (struct drm_i915_gem_object *obj) +static void shmem_free_st (struct sg_table *st,struct address_space *mapping, +bool dirty,bool backup) { -struct drm_i915_private *i915 =to_i915 (obj->base.dev); -struct intel_memory_region *mem = obj->mm.region; -const unsigned long page_count = obj->base.size /PAGE_SIZE ; +struct sgt_iter sgt_iter; +struct pagevec pvec; +struct page *page; + +mapping_clear_unevictable (mapping); + +pagevec_init (&pvec); +for_each_sgt_page (page, sgt_iter, st) { +if (dirty) +set_page_dirty (page); + +if (backup) +mark_page_accessed (page); + +if (!pagevec_add (&pvec, page)) +check_release_pagevec (&pvec); + } +if (pagevec_count (&pvec)) +check_release_pagevec (&pvec); + +sg_free_table (st); +kfree (st); +} + +static struct sg_table *shmem_alloc_st (struct drm_i915_private *i915, +size_t size,struct intel_memory_region *mr, +struct address_space *mapping, +unsigned int max_segment) +{ +const unsigned long page_count = size /PAGE_SIZE ;unsigned long i; -struct address_space *mapping;struct sg_table *st;struct scatterlist *sg; -struct sgt_iter sgt_iter;struct page *page;unsigned long last_pfn =0 ;/* suppress gcc warning */ -unsigned int max_segment =i915_sg_segment_size (); -unsigned int sg_page_sizes;gfp_t noreclaim;int ret; -/* -* Assert that the object is not currently in any GPU domain. As it -* wasn't in the GTT, there shouldn't be any way it could have been in -* a GPU cache -*/ -GEM_BUG_ON (obj->read_domains &I915_GEM_GPU_DOMAINS ); -GEM_BUG_ON (obj->write_domain &I915_GEM_GPU_DOMAINS ); -/* * If there's no chance of allocating enough pages for the whole * object, bail early. */ -if (obj->base.size >resource_size (&mem->region)) -return -ENOMEM ; +if (size >resource_size (&mr->region)) +return ERR_PTR (-ENOMEM ); st =kmalloc (sizeof (*st),GFP_KERNEL );if (!st) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); -rebuild_st:if (sg_alloc_table (st, page_count,GFP_KERNEL )) {kfree (st); -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); }/*
@@ -73,14 +88,12 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)* * Fail silently without starting the shrinker */ - mapping = obj->base.filp->f_mapping;mapping_set_unevictable (mapping); noreclaim =mapping_gfp_constraint (mapping, ~__GFP_RECLAIM); noreclaim |= __GFP_NORETRY | __GFP_NOWARN; sg = st->sgl; st->nents =0 ; - sg_page_sizes =0 ;for (i =0 ; i < page_count; i++) {const unsigned int shrink[] = {I915_SHRINK_BOUND |I915_SHRINK_UNBOUND ,
@@ -135,10 +148,9 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)if (!i || sg->length >= max_segment ||page_to_pfn (page) != last_pfn +1 ) { -if (i) { - sg_page_sizes |= sg->length; +if (i) sg =sg_next (sg); - } + st->nents++;sg_set_page (sg, page,PAGE_SIZE ,0 ); }else {
@@ -149,14 +161,65 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)/* Check that the i965g/gm workaround works. */ GEM_BUG_ON (gfp & __GFP_DMA32 && last_pfn >=0x00100000UL ); } -if (sg) {/* loop terminated early; short sg table */ - sg_page_sizes |= sg->length; +if (sg)/* loop terminated early; short sg table */ sg_mark_end (sg); - }/* Trim unused sg entries to avoid wasting memory. */ i915_sg_trim (st); +return st; +err_sg: +sg_mark_end (sg); +if (sg != st->sgl) { +shmem_free_st (st, mapping, false, false); + }else { +mapping_clear_unevictable (mapping); +sg_free_table (st); +kfree (st); + } + +/* +* shmemfs first checks if there is enough memory to allocate the page +* and reports ENOSPC should there be insufficient, along with the usual +* ENOMEM for a genuine allocation failure. +* +* We use ENOSPC in our driver to mean that we have run out of aperture +* space and so want to translate the error from shmemfs back to our +* usual understanding of ENOMEM. +*/ +if (ret == -ENOSPC ) + ret = -ENOMEM ; + +return ERR_PTR (ret); +} + +static int shmem_get_pages (struct drm_i915_gem_object *obj) +{ +struct drm_i915_private *i915 =to_i915 (obj->base.dev); +struct intel_memory_region *mem = obj->mm.region; +struct address_space *mapping = obj->base.filp->f_mapping; +const unsigned long page_count = obj->base.size /PAGE_SIZE ; +unsigned int max_segment =i915_sg_segment_size (); +struct sg_table *st; +struct sgt_iter sgt_iter; +struct page *page; +int ret; + +/* +* Assert that the object is not currently in any GPU domain. As it +* wasn't in the GTT, there shouldn't be any way it could have been in +* a GPU cache +*/ +GEM_BUG_ON (obj->read_domains &I915_GEM_GPU_DOMAINS ); +GEM_BUG_ON (obj->write_domain &I915_GEM_GPU_DOMAINS ); + +rebuild_st: + st =shmem_alloc_st (i915, obj->base.size, mem, mapping, max_segment); +if (IS_ERR (st)) { + ret =PTR_ERR (st); + goto err_st; + } + ret =i915_gem_gtt_prepare_pages (obj, st);if (ret) {/*
@@ -168,6 +231,7 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)for_each_sgt_page (page, sgt_iter, st)put_page (page);sg_free_table (st); +kfree (st); max_segment =PAGE_SIZE ; goto rebuild_st;
@@ -200,28 +264,12 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)if (IS_JSL_EHL (i915) && obj->flags &I915_BO_ALLOC_USER ) obj->cache_dirty = true; -__i915_gem_object_set_pages (obj, st, sg_page_sizes); +__i915_gem_object_set_pages (obj, st,i915_sg_dma_sizes (st->sgl));return 0 ; -err_sg: -sg_mark_end (sg); err_pages: -mapping_clear_unevictable (mapping); -if (sg != st->sgl) { -struct pagevec pvec; - -pagevec_init (&pvec); -for_each_sgt_page (page, sgt_iter, st) { -if (!pagevec_add (&pvec, page)) -check_release_pagevec (&pvec); - } -if (pagevec_count (&pvec)) -check_release_pagevec (&pvec); - } -sg_free_table (st); -kfree (st); - +shmem_free_st (st, mapping, false, false);/* * shmemfs first checks if there is enough memory to allocate the page * and reports ENOSPC should there be insufficient, along with the usual
@@ -231,6 +279,7 @@ static int shmem_get_pages(struct drm_i915_gem_object *obj)* space and so want to translate the error from shmemfs back to our * usual understanding of ENOMEM. */ +err_st:if (ret == -ENOSPC ) ret = -ENOMEM ;
@@ -251,10 +300,8 @@ shmem_truncate(struct drm_i915_gem_object *obj) obj->mm.pages =ERR_PTR (-EFAULT ); } -static void -shmem_writeback (struct drm_i915_gem_object *obj) +static void __shmem_writeback (size_t size,struct address_space *mapping) { -struct address_space *mapping;struct writeback_control wbc = { .sync_mode =WB_SYNC_NONE , .nr_to_write =SWAP_CLUSTER_MAX ,
@@ -270,10 +317,9 @@ shmem_writeback(struct drm_i915_gem_object *obj)* instead of invoking writeback so they are aged and paged out * as normal. */ - mapping = obj->base.filp->f_mapping;/* Begin writeback on each dirty page */ -for (i =0 ; i < obj->base.size >>PAGE_SHIFT ; i++) { +for (i =0 ; i < size >>PAGE_SHIFT ; i++) {struct page *page; page =find_lock_page (mapping, i);
@@ -296,6 +342,12 @@ shmem_writeback(struct drm_i915_gem_object *obj) } } +static void +shmem_writeback (struct drm_i915_gem_object *obj) +{ +__shmem_writeback (obj->base.size, obj->base.filp->f_mapping); +} + void __i915_gem_object_release_shmem(struct drm_i915_gem_object *obj, struct sg_table *pages,
@@ -316,11 +368,6 @@ __i915_gem_object_release_shmem(struct drm_i915_gem_object *obj,void i915_gem_object_put_pages_shmem (struct drm_i915_gem_object *obj,struct sg_table *pages) { -struct sgt_iter sgt_iter; -struct pagevec pvec; -struct page *page; - -GEM_WARN_ON (IS_DGFX (to_i915 (obj->base.dev)));__i915_gem_object_release_shmem (obj, pages, true);i915_gem_gtt_finish_pages (obj, pages);
@@ -328,25 +375,9 @@ void i915_gem_object_put_pages_shmem(struct drm_i915_gem_object *obj, struct sg_if (i915_gem_object_needs_bit17_swizzle (obj))i915_gem_object_save_bit_17_swizzle (obj, pages); -mapping_clear_unevictable (file_inode (obj->base.filp)->i_mapping); - -pagevec_init (&pvec); -for_each_sgt_page (page, sgt_iter, pages) { -if (obj->mm.dirty) -set_page_dirty (page); - -if (obj->mm.madv ==I915_MADV_WILLNEED ) -mark_page_accessed (page); - -if (!pagevec_add (&pvec, page)) -check_release_pagevec (&pvec); - } -if (pagevec_count (&pvec)) -check_release_pagevec (&pvec); +shmem_free_st (pages,file_inode (obj->base.filp)->i_mapping, + obj->mm.dirty, obj->mm.madv ==I915_MADV_WILLNEED ); obj->mm.dirty = false; - -sg_free_table (pages); -kfree (pages); } static void
Signature · 1 line
2.26.3
Matthew Auld
reviewerPATCH v2 2/7 drm/ttm: add TTM_PAGE_FLAG_SHMEM
Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker.
As part of this we should skip the ttm_pages_allocated accounting, since such tt objects should already be reachable, and potentially reclaimable by some shrinker, if under memory pressure, and so shouldn't directly count towards the swap "watermark" level.
We also need to stop touching the page->mapping and page->index for such objects, like in ttm_tt_add_mapping, since shmem already uses these. Some drivers seems to depend on the tt mapping/index behaviour for their own purposes, so directly using shmem tt likely won't be usable there as-is.
--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++-- drivers/gpu/drm/ttm/ttm_tt.c | 10 +++++----- include/drm/ttm/ttm_tt.h | 1 + 3 files changed, 8 insertions(+), 7 deletions(-)
drivers/gpu/drm/ttm/ttm_bo_vm.c +2 -2
@@ -346,8 +346,8 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, }else if (unlikely (!page)) {break ; } - page->index =drm_vma_node_start (&bo->base.vma_node) + - page_offset; +if (!(bo->ttm->page_flags &TTM_PAGE_FLAG_SHMEM )) + page->index =drm_vma_node_start (&bo->base.vma_node) + page_offset; pfn =page_to_pfn (page); }
drivers/gpu/drm/ttm/ttm_tt.c +5 -5
@@ -293,7 +293,7 @@ static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) {pgoff_t i; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))return ;for (i =0 ; i < ttm->num_pages; ++i)
@@ -311,7 +311,7 @@ int ttm_tt_populate(struct ttm_device *bdev,if (ttm_tt_is_populated (ttm))return 0 ; -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_add (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_add(ttm->num_pages,
@@ -349,7 +349,7 @@ int ttm_tt_populate(struct ttm_device *bdev,return 0 ; error: -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,
@@ -364,7 +364,7 @@ static void ttm_tt_clear_mapping(struct ttm_tt *ttm)pgoff_t i;struct page **page = ttm->pages; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))return ;for (i =0 ; i < ttm->num_pages; ++i) {
@@ -384,7 +384,7 @@ void ttm_tt_unpopulate(struct ttm_device *bdev, struct ttm_tt *ttm)else ttm_pool_free (&bdev->pool, ttm); -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,
include/drm/ttm/ttm_tt.h +1 -0
@@ -42,6 +42,7 @@ struct ttm_operation_ctx;#define TTM_PAGE_FLAG_ZERO_ALLOC (1 << 6)#define TTM_PAGE_FLAG_SG (1 << 8)#define TTM_PAGE_FLAG_NO_RETRY (1 << 9) +#define TTM_PAGE_FLAG_SHMEM (1 << 10)#define TTM_PAGE_FLAG_PRIV_POPULATED (1 << 31)
Signature · 1 line
2.26.3
Re: [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM
Am 14.09.21 um 10:50 schrieb Matthew Auld:
Quoted 28 lines
Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker.
As part of this we should skip the
ttm_pages_allocatedaccounting, since such tt objects should already be reachable, and potentially reclaimable by some shrinker, if under memory pressure, and so shouldn't directly count towards the swap "watermark" level.We also need to stop touching the
page->mappingandpage->indexfor such objects, like inttm_tt_add_mapping, since shmem already uses these. Some drivers seems to depend on the tt mapping/index behaviour for their own purposes, so directly using shmem tt likely won't be usable there as-is.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>Cc Christian König <[email protected]>--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++-- drivers/gpu/drm/ttm/ttm_tt.c | 10 +++++----- include/drm/ttm/ttm_tt.h | 1 + 3 files changed, 8 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_bo_vm.c +0
-0
drivers/gpu/drm/ttm/ttm_bo_vm.c vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, · line 350
Quoted 7 lines
drivers/gpu/drm/ttm/ttm_bo_vm.c +2
-2@@ -346,8 +346,8 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, }else if (unlikely (!page)) {break ; } - page->index =drm_vma_node_start (&bo->base.vma_node) + - page_offset; +if (!(bo->ttm->page_flags &TTM_PAGE_FLAG_SHMEM )) + page->index =drm_vma_node_start (&bo->base.vma_node) + page_offset;
I still have a rather bad feeling about that.
This should either not be necessary any more in general or the shmemfile approach doesn't work correctly.
Please send a patch to remove this for everybody instead and we will see if that really works or not.
drivers/gpu/drm/ttm/ttm_tt.c static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) · line 296
Quoted 13 lines
drivers/gpu/drm/ttm/ttm_bo_vm.c +0
-0pfn =page_to_pfn (page); }drivers/gpu/drm/ttm/ttm_tt.c +1
-1@@ -293,7 +293,7 @@ static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) {pgoff_t i; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))
Maybe you should re-use the TTM_PAGE_FLAG_SG for this and/or rename the flag to better describe what it does.
Something like TTM_PAGE_FLAG_EXTERNAL or similar? The only other use case for TTM_PAGE_FLAG_SG which comes to my mind is controlling if the pages array is allocated or not.
Christian.
Quoted 51 lines
drivers/gpu/drm/ttm/ttm_tt.c +4
-4return ;for (i =0 ; i < ttm->num_pages; ++i)@@ -311,7 +311,7 @@ int ttm_tt_populate(struct ttm_device *bdev,if (ttm_tt_is_populated (ttm))return 0 ; -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_add (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_add(ttm->num_pages,@@ -349,7 +349,7 @@ int ttm_tt_populate(struct ttm_device *bdev,return 0 ; error: -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,@@ -364,7 +364,7 @@ static void ttm_tt_clear_mapping(struct ttm_tt *ttm)pgoff_t i;struct page **page = ttm->pages; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))return ;for (i =0 ; i < ttm->num_pages; ++i) {@@ -384,7 +384,7 @@ void ttm_tt_unpopulate(struct ttm_device *bdev, struct ttm_tt *ttm)else ttm_pool_free (&bdev->pool, ttm); -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,include/drm/ttm/ttm_tt.h +1
-0@@ -42,6 +42,7 @@ struct ttm_operation_ctx;#define TTM_PAGE_FLAG_ZERO_ALLOC (1 << 6)#define TTM_PAGE_FLAG_SG (1 << 8)#define TTM_PAGE_FLAG_NO_RETRY (1 << 9) +#define TTM_PAGE_FLAG_SHMEM (1 << 10)#define TTM_PAGE_FLAG_PRIV_POPULATED (1 << 31)
Re: [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM
Quoted 63 lines · Christian König
Am 14.09.21 um 10:50 schrieb Matthew Auld:
Quoted 28 lines
Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker.
As part of this we should skip the
ttm_pages_allocatedaccounting, since such tt objects should already be reachable, and potentially reclaimable by some shrinker, if under memory pressure, and so shouldn't directly count towards the swap "watermark" level.We also need to stop touching the
page->mappingandpage->indexfor such objects, like inttm_tt_add_mapping, since shmem already uses these. Some drivers seems to depend on the tt mapping/index behaviour for their own purposes, so directly using shmem tt likely won't be usable there as-is.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>Cc Christian König <[email protected]>--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++-- drivers/gpu/drm/ttm/ttm_tt.c | 10 +++++----- include/drm/ttm/ttm_tt.h | 1 + 3 files changed, 8 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_bo_vm.c +0
-0drivers/gpu/drm/ttm/ttm_bo_vm.c vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, · line 350
Quoted 7 lines
drivers/gpu/drm/ttm/ttm_bo_vm.c +2
-2@@ -346,8 +346,8 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, }else if (unlikely (!page)) {break ; } - page->index =drm_vma_node_start (&bo->base.vma_node) + - page_offset; +if (!(bo->ttm->page_flags &TTM_PAGE_FLAG_SHMEM )) + page->index =drm_vma_node_start (&bo->base.vma_node) + page_offset;I still have a rather bad feeling about that.
This should either not be necessary any more in general or the shmemfile approach doesn't work correctly.
Please send a patch to remove this for everybody instead and we will see if that really works or not.
drivers/gpu/drm/ttm/ttm_tt.c static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) · line 296
Quoted 13 lines
drivers/gpu/drm/ttm/ttm_bo_vm.c +0
-0pfn =page_to_pfn (page); }drivers/gpu/drm/ttm/ttm_tt.c +1
-1@@ -293,7 +293,7 @@ static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) {pgoff_t i; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))Maybe you should re-use the
TTM_PAGE_FLAG_SGfor this and/or rename the flag to better describe what it does.
Quoted 3 lines
Something like
TTM_PAGE_FLAG_EXTERNALor similar? The only other use case forTTM_PAGE_FLAG_SGwhich comes to my mind is controlling if the pages array is allocated or not.
This seems slightly tricky. We still want ttm_bo_vm_reserve() to behave normally when seeing shmem_tt, and yet it still needs to return SIGBUS or so for FLAG_SG, as per the existing behaviour. Throwing in bo->type == type_sg seems maybe plausible, but at least amdgpu is manually setting FLAG_SG for userptr objects, so I presume bo->type != type_sg here?
Otherwise maybe just s/SHMEM/EXTERNAL and leave FLAG_SG as-is?
Quoted 55 lines
Christian.
Quoted 51 lines
drivers/gpu/drm/ttm/ttm_tt.c +4
-4return ;for (i =0 ; i < ttm->num_pages; ++i)@@ -311,7 +311,7 @@ int ttm_tt_populate(struct ttm_device *bdev,if (ttm_tt_is_populated (ttm))return 0 ; -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_add (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_add(ttm->num_pages,@@ -349,7 +349,7 @@ int ttm_tt_populate(struct ttm_device *bdev,return 0 ; error: -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,@@ -364,7 +364,7 @@ static void ttm_tt_clear_mapping(struct ttm_tt *ttm)pgoff_t i;struct page **page = ttm->pages; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))return ;for (i =0 ; i < ttm->num_pages; ++i) {@@ -384,7 +384,7 @@ void ttm_tt_unpopulate(struct ttm_device *bdev, struct ttm_tt *ttm)else ttm_pool_free (&bdev->pool, ttm); -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,include/drm/ttm/ttm_tt.h +1
-0@@ -42,6 +42,7 @@ struct ttm_operation_ctx;#define TTM_PAGE_FLAG_ZERO_ALLOC (1 << 6)#define TTM_PAGE_FLAG_SG (1 << 8)#define TTM_PAGE_FLAG_NO_RETRY (1 << 9) +#define TTM_PAGE_FLAG_SHMEM (1 << 10)#define TTM_PAGE_FLAG_PRIV_POPULATED (1 << 31)
Re: [PATCH v2 2/7] drm/ttm: add TTM_PAGE_FLAG_SHMEM
Am 14.09.21 um 19:31 schrieb Matthew Auld:
Quoted 64 lines · Christian König
Quoted 55 lines
Am 14.09.21 um 10:50 schrieb Matthew Auld:
Quoted 28 lines
Add new flag to indicate special shmem based tt, which can directly handle swapping itself, and should be visible to some shrinker.
As part of this we should skip the
ttm_pages_allocatedaccounting, since such tt objects should already be reachable, and potentially reclaimable by some shrinker, if under memory pressure, and so shouldn't directly count towards the swap "watermark" level.We also need to stop touching the
page->mappingandpage->indexfor such objects, like inttm_tt_add_mapping, since shmem already uses these. Some drivers seems to depend on the tt mapping/index behaviour for their own purposes, so directly using shmem tt likely won't be usable there as-is.Signed-off-by Matthew Auld <[email protected]>Cc Thomas Hellström <[email protected]>Cc Christian König <[email protected]>--- drivers/gpu/drm/ttm/ttm_bo_vm.c | 4 ++-- drivers/gpu/drm/ttm/ttm_tt.c | 10 +++++----- include/drm/ttm/ttm_tt.h | 1 + 3 files changed, 8 insertions(+), 7 deletions(-)drivers/gpu/drm/ttm/ttm_bo_vm.c +0
-0drivers/gpu/drm/ttm/ttm_bo_vm.c vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, · line 350
Quoted 7 lines
drivers/gpu/drm/ttm/ttm_bo_vm.c +2
-2@@ -346,8 +346,8 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, }else if (unlikely (!page)) {break ; } - page->index =drm_vma_node_start (&bo->base.vma_node) + - page_offset; +if (!(bo->ttm->page_flags &TTM_PAGE_FLAG_SHMEM )) + page->index =drm_vma_node_start (&bo->base.vma_node) + page_offset;I still have a rather bad feeling about that.
This should either not be necessary any more in general or the shmemfile approach doesn't work correctly.
Please send a patch to remove this for everybody instead and we will see if that really works or not.
Quoted 11 lines
drivers/gpu/drm/ttm/ttm_bo_vm.c +0
-0pfn =page_to_pfn (page); }drivers/gpu/drm/ttm/ttm_tt.c +0
-0@@ -293,7 +293,7 @@ static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) {pgoff_t i;Quoted 8 lines
drivers/gpu/drm/ttm/ttm_tt.c static void ttm_tt_add_mapping(struct ttm_device *bdev, struct ttm_tt *ttm) · line 296
Quoted 2 lines
drivers/gpu/drm/ttm/ttm_tt.c +1
-1-if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))Maybe you should re-use the
TTM_PAGE_FLAG_SGfor this and/or rename the flag to better describe what it does.Something like
TTM_PAGE_FLAG_EXTERNALor similar? The only other use case forTTM_PAGE_FLAG_SGwhich comes to my mind is controlling if the pages array is allocated or not.
Quoted 6 lines
This seems slightly tricky. We still want
ttm_bo_vm_reserve()to behave normally when seeingshmem_tt, and yet it still needs to return SIGBUS or so forFLAG_SG, as per the existing behaviour. Throwing inbo->type==type_sgseems maybe plausible, but at least amdgpu is manually settingFLAG_SGfor userptr objects, so I presumebo->type!=type_sghere?
Mapping userptr pages through TTM is highly illegal as well since that won't work correctly with the tracking.
But please double check the history of this check, IIRC there was another reason why we checked the flag.
Thanks,
Christian.
Quoted 56 lines
Otherwise maybe just s/SHMEM/EXTERNAL and leave
FLAG_SGas-is?Quoted 53 lines
Christian.
Quoted 51 lines
drivers/gpu/drm/ttm/ttm_tt.c +4
-4return ;for (i =0 ; i < ttm->num_pages; ++i)@@ -311,7 +311,7 @@ int ttm_tt_populate(struct ttm_device *bdev,if (ttm_tt_is_populated (ttm))return 0 ; -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_add (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_add(ttm->num_pages,@@ -349,7 +349,7 @@ int ttm_tt_populate(struct ttm_device *bdev,return 0 ; error: -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,@@ -364,7 +364,7 @@ static void ttm_tt_clear_mapping(struct ttm_tt *ttm)pgoff_t i;struct page **page = ttm->pages; -if (ttm->page_flags &TTM_PAGE_FLAG_SG ) +if (ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))return ;for (i =0 ; i < ttm->num_pages; ++i) {@@ -384,7 +384,7 @@ void ttm_tt_unpopulate(struct ttm_device *bdev, struct ttm_tt *ttm)else ttm_pool_free (&bdev->pool, ttm); -if (!(ttm->page_flags &TTM_PAGE_FLAG_SG )) { +if (!(ttm->page_flags & (TTM_PAGE_FLAG_SG |TTM_PAGE_FLAG_SHMEM ))) {atomic_long_sub (ttm->num_pages, &ttm_pages_allocated);if (bdev->pool.use_dma32) atomic_long_sub(ttm->num_pages,include/drm/ttm/ttm_tt.h +1
-0@@ -42,6 +42,7 @@ struct ttm_operation_ctx;#define TTM_PAGE_FLAG_ZERO_ALLOC (1 << 6)#define TTM_PAGE_FLAG_SG (1 << 8)#define TTM_PAGE_FLAG_NO_RETRY (1 << 9) +#define TTM_PAGE_FLAG_SHMEM (1 << 10)#define TTM_PAGE_FLAG_PRIV_POPULATED (1 << 31)
Matthew Auld
reviewerPATCH v2 3/7 drm/i915/ttm: add tt shmem backend
In reply to Matthew AuldFor cached objects we can allocate our pages directly in shmem. This should make it possible(in a later patch) to utilise the existing i915-gem shrinker code for such objects. For now this is still disabled.
--- drivers/gpu/drm/i915/gem/i915_gem_object.h | 8 + drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 14 +- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 214 ++++++++++++++++++--- 3 files changed, 206 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.h +8 -0
@@ -618,6 +618,14 @@ int i915_gem_object_wait_migration(struct drm_i915_gem_object *obj,bool i915_gem_object_placement_possible (struct drm_i915_gem_object *obj,enum intel_memory_type type); +struct sg_table *shmem_alloc_st (struct drm_i915_private *i915, +size_t size,struct intel_memory_region *mr, +struct address_space *mapping, +unsigned int max_segment); +void shmem_free_st (struct sg_table *st,struct address_space *mapping, +bool dirty,bool backup); +void __shmem_writeback (size_t size,struct address_space *mapping); +#ifdef CONFIG_MMU_NOTIFIER static inline bool i915_gem_object_is_userptr (struct drm_i915_gem_object *obj)
drivers/gpu/drm/i915/gem/i915_gem_shmem.c +7 -7
@@ -25,8 +25,8 @@ static void check_release_pagevec(struct pagevec *pvec)cond_resched (); } -static void shmem_free_st (struct sg_table *st,struct address_space *mapping, -bool dirty,bool backup) +void shmem_free_st (struct sg_table *st,struct address_space *mapping, +bool dirty,bool backup) {struct sgt_iter sgt_iter;struct pagevec pvec;
@@ -52,10 +52,10 @@ static void shmem_free_st(struct sg_table *st, struct address_space *mapping,kfree (st); } -static struct sg_table *shmem_alloc_st (struct drm_i915_private *i915, -size_t size,struct intel_memory_region *mr, -struct address_space *mapping, -unsigned int max_segment) +struct sg_table *shmem_alloc_st (struct drm_i915_private *i915, +size_t size,struct intel_memory_region *mr, +struct address_space *mapping, +unsigned int max_segment) {const unsigned long page_count = size /PAGE_SIZE ;unsigned long i;
@@ -300,7 +300,7 @@ shmem_truncate(struct drm_i915_gem_object *obj) obj->mm.pages =ERR_PTR (-EFAULT ); } -static void __shmem_writeback (size_t size,struct address_space *mapping) +void __shmem_writeback (size_t size,struct address_space *mapping) {struct writeback_control wbc = { .sync_mode =WB_SYNC_NONE ,
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +191 -23
312 lines not on this page · raw message
Signature · 1 line
2.26.3
Matthew Auld
reviewerPATCH v2 4/7 drm/i915/ttm: use cached system pages when evicting lmem
In reply to Matthew AuldThis should let us do an accelerated copy directly to the shmem pages when temporarily moving lmem-only objects, where the i915-gem shrinker can later kick in to swap out the pages, if needed.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +4 -4
@@ -123,11 +123,11 @@ static enum ttm_caching i915_ttm_select_tt_caching(const struct drm_i915_gem_object *obj) {/* -* Objects only allowed in system get cached cpu-mappings. -* Other objects get WC mapping for now. Even if in system. +* Objects only allowed in system get cached cpu-mappings, or when +* evicting lmem-only buffers to system for swapping. Other objects get +* WC mapping for now. Even if in system. */ -if (obj->mm.region->type ==INTEL_MEMORY_SYSTEM && - obj->mm.n_placements <=1 ) +if (obj->mm.n_placements <=1 )return ttm_cached;return ttm_write_combined;
Signature · 1 line
2.26.3
Matthew Auld
reviewerPATCH v2 5/7 drm/i915: try to simplify make_{un}shrinkable
In reply to Matthew AuldDrop the atomic shrink_pin stuff, and just have make_{un}shrinkable update the shrinker visible lists immediately. This at least simplifies the next patch, and does make the behaviour more obvious. The potential downside is that make_unshrinkable now grabs a global lock even when the object itself is no longer shrinkable(transitioning from purgeable <-> shrinkable doesn't seem to be a thing), for example in the ppGTT insertion paths we should now be careful not to needlessly call make_unshrinkable multiple times. Outside of that there is some fallout in intel_context which relies on nesting calls to shrink_pin.
--- drivers/gpu/drm/i915/gem/i915_gem_object.c | 9 ---- .../gpu/drm/i915/gem/i915_gem_object_types.h | 3 +- drivers/gpu/drm/i915/gem/i915_gem_pages.c | 16 +----- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 52 +++++++++++++------ drivers/gpu/drm/i915/gt/gen6_ppgtt.c | 1 - drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 1 - drivers/gpu/drm/i915/gt/intel_context.c | 9 +--- 7 files changed, 41 insertions(+), 50 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.c +0 -9
@@ -305,15 +305,6 @@ static void i915_gem_free_object(struct drm_gem_object *gem_obj)*/ atomic_inc (&i915->mm.free_count); -/* -* This serializes freeing with the shrinker. Since the free -* is delayed, first by RCU then by the workqueue, we want the -* shrinker to be able to free pages of unreferenced objects, -* or else we may oom whilst there are plenty of deferred -* freed objects. -*/ -i915_gem_object_make_unshrinkable (obj); -/* * Since we require blocking on struct_mutex to unbind the freed * object from the GPU before releasing resources back to the
drivers/gpu/drm/i915/gem/i915_gem_object_types.h +1 -2
@@ -453,7 +453,6 @@ struct drm_i915_gem_object {* instead go through the pin/unpin interfaces. */ atomic_t pages_pin_count; -atomic_t shrink_pin;/** * Priority list of potential placements for this object.
@@ -514,7 +513,7 @@ struct drm_i915_gem_object {struct i915_gem_object_page_iter get_dma_page;/** -* Element within i915->mm.unbound_list or i915->mm.bound_list, +* Element within i915->mm.shrink_list or i915->mm.purge_list, * locked by i915->mm.obj_lock. */ struct list_head link;
drivers/gpu/drm/i915/gem/i915_gem_pages.c +2 -14
@@ -64,28 +64,16 @@ void __i915_gem_object_set_pages(struct drm_i915_gem_object *obj,GEM_BUG_ON (i915_gem_object_has_tiling_quirk (obj));i915_gem_object_set_tiling_quirk (obj);GEM_BUG_ON (!list_empty (&obj->mm.link)); -atomic_inc (&obj->mm.shrink_pin); shrinkable = false; }if (shrinkable) { -struct list_head *list; -unsigned long flags; -assert_object_held (obj); -spin_lock_irqsave (&i915->mm.obj_lock, flags); - - i915->mm.shrink_count++; - i915->mm.shrink_memory += obj->base.size;if (obj->mm.madv !=I915_MADV_WILLNEED ) - list = &i915->mm.purge_list; +i915_gem_object_make_purgeable (obj);else - list = &i915->mm.shrink_list; -list_add_tail (&obj->mm.link, list); - -atomic_set (&obj->mm.shrink_pin,0 ); -spin_unlock_irqrestore (&i915->mm.obj_lock, flags); +i915_gem_object_make_shrinkable (obj); } }
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +36 -16
87 lines not on this page · raw message
drivers/gpu/drm/i915/gt/gen6_ppgtt.c +0 -1
@@ -185,7 +185,6 @@ static void gen6_alloc_va_range(struct i915_address_space *vm, pt = stash->pt[0 ];__i915_gem_object_pin_pages (pt->base); -i915_gem_object_make_unshrinkable (pt->base);fill32_px (pt, vm->scratch[0 ]->encode);
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +0 -1
@@ -301,7 +301,6 @@ static void __gen8_ppgtt_alloc(struct i915_address_space * const vm, pt = stash->pt[!!lvl];__i915_gem_object_pin_pages (pt->base); -i915_gem_object_make_unshrinkable (pt->base);fill_px (pt, vm->scratch[lvl]->encode);
drivers/gpu/drm/i915/gt/intel_context.c +2 -7
@@ -111,11 +111,6 @@ static int __context_pin_state(struct i915_vma *vma, struct i915_gem_ww_ctx *ww)if (err) goto err_unpin; -/* -* And mark it as a globally pinned object to let the shrinker know -* it cannot reclaim the object until we release it. -*/ -i915_vma_make_unshrinkable (vma); vma->obj->mm.dirty = true;return 0 ;
@@ -127,7 +122,6 @@ static int __context_pin_state(struct i915_vma *vma, struct i915_gem_ww_ctx *ww)static void __context_unpin_state (struct i915_vma *vma) { -i915_vma_make_shrinkable (vma);i915_active_release (&vma->active);__i915_vma_unpin (vma); }
@@ -180,7 +174,6 @@ static int intel_context_pre_pin(struct intel_context *ce,if (err) goto err_timeline; -return 0 ; err_timeline:
@@ -338,6 +331,8 @@ static void __intel_context_retire(struct i915_active *active)set_bit (CONTEXT_VALID_BIT , &ce->flags);intel_context_post_unpin (ce); +if (ce->state) +i915_vma_make_shrinkable (ce->state);intel_context_put (ce); }
Signature · 1 line
2.26.3
Matthew Auld
reviewerPATCH v2 6/7 drm/i915/ttm: make evicted shmem pages visible to the shrinker
In reply to Matthew AuldWe currently just evict lmem objects to system memory when under memory pressure. For this case we lack the usual object mm.pages, which effectively hides the pages from the i915-gem shrinker, until we actually "attach" the TT to the object, or in the case of lmem-only objects it just gets migrated back to lmem when touched again. For such cases we can make the object visible as soon as we populate the TT with shmem pages, and then hide it again when doing the unpopulate.
--- drivers/gpu/drm/i915/gem/i915_gem_object.h | 1 + drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 29 +++++++++++++++----- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 11 ++++++++ 3 files changed, 34 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/gem/i915_gem_object.h +1 -0
@@ -540,6 +540,7 @@ i915_gem_object_pin_to_display_plane(struct drm_i915_gem_object *obj,void i915_gem_object_make_unshrinkable (struct drm_i915_gem_object *obj);void i915_gem_object_make_shrinkable (struct drm_i915_gem_object *obj); +void __i915_gem_object_make_shrinkable (struct drm_i915_gem_object *obj);void i915_gem_object_make_purgeable (struct drm_i915_gem_object *obj);static inline bool cpu_write_needs_clflush (struct drm_i915_gem_object *obj)
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c +22 -7
@@ -482,13 +482,12 @@ void i915_gem_object_make_unshrinkable(struct drm_i915_gem_object *obj)spin_unlock_irqrestore (&i915->mm.obj_lock, flags); } -static void __i915_gem_object_make_shrinkable (struct drm_i915_gem_object *obj, -struct list_head *head) +static void ___i915_gem_object_make_shrinkable (struct drm_i915_gem_object *obj, +struct list_head *head) {struct drm_i915_private *i915 =obj_to_i915 (obj);unsigned long flags; -GEM_BUG_ON (!i915_gem_object_has_pages (obj));if (!i915_gem_object_is_shrinkable (obj))return ;
@@ -507,6 +506,21 @@ static void __i915_gem_object_make_shrinkable(struct drm_i915_gem_object *obj,spin_unlock_irqrestore (&i915->mm.obj_lock, flags); } +/** +* __i915_gem_object_make_shrinkable - Move the object to the tail of the +* shrinkable list. Objects on this list might be swapped out. Used with +* WILLNEED objects. +* @obj: The GEM object. +* +* DO NOT USE. This is intended to be called on very special objects that don't +* yet have mm.pages, but are guaranteed to have potentially reclaimable pages +* underneath. +*/ +void __i915_gem_object_make_shrinkable (struct drm_i915_gem_object *obj) +{ +___i915_gem_object_make_shrinkable (obj, + &obj_to_i915 (obj)->mm.shrink_list); +}/** * i915_gem_object_make_shrinkable - Move the object to the tail of the
@@ -518,8 +532,8 @@ static void __i915_gem_object_make_shrinkable(struct drm_i915_gem_object *obj,*/ void i915_gem_object_make_shrinkable (struct drm_i915_gem_object *obj) { -__i915_gem_object_make_shrinkable (obj, - &obj_to_i915 (obj)->mm.shrink_list); +GEM_BUG_ON (!i915_gem_object_has_pages (obj)); +__i915_gem_object_make_shrinkable (obj); }/**
@@ -533,6 +547,7 @@ void i915_gem_object_make_shrinkable(struct drm_i915_gem_object *obj)*/ void i915_gem_object_make_purgeable (struct drm_i915_gem_object *obj) { -__i915_gem_object_make_shrinkable (obj, - &obj_to_i915 (obj)->mm.purge_list); +GEM_BUG_ON (!i915_gem_object_has_pages (obj)); +___i915_gem_object_make_shrinkable (obj, + &obj_to_i915 (obj)->mm.purge_list); }
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +11 -0
@@ -231,6 +231,15 @@ static int i915_ttm_tt_shmem_populate(struct ttm_device *bdev,if (ttm->page_flags &TTM_PAGE_FLAG_SWAPPED ) ttm->page_flags &= ~TTM_PAGE_FLAG_SWAPPED ; +/* +* Even if we lack mm.pages for this object(which will be the case when +* something is evicted to system memory by TTM), we still want to make +* this object visible to the shrinker, since the underlying ttm_tt +* still has the real shmem pages. When unpopulating the tt(possibly due +* to shrinking) we hide it again from the shrinker. +*/ +__i915_gem_object_make_shrinkable (obj); + i915_tt->cached_st = st;return 0 ;
@@ -245,6 +254,8 @@ static void i915_ttm_tt_shmem_unpopulate(struct ttm_tt *ttm)struct drm_i915_gem_object *obj = i915_tt->obj;bool backup = i915_tt->backup; +i915_gem_object_make_unshrinkable (obj); +if (obj->mm.madv ==I915_MADV_DONTNEED ) { obj->mm.dirty = false;GEM_BUG_ON (backup);
Signature · 1 line
2.26.3
Matthew Auld
reviewerPATCH v2 7/7 drm/i915/ttm: enable shmem tt backend
In reply to Matthew AuldEnable shmem tt backend, and enable shrinking.
--- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/gem/i915_gem_ttm.c +1 -0
@@ -1047,6 +1047,7 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)static const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = { .name ="i915_gem_object_ttm" , + .flags =I915_GEM_OBJECT_IS_SHRINKABLE , .get_pages = i915_ttm_get_pages, .put_pages = i915_ttm_put_pages,
Signature · 1 line
2.26.3
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils
URL : https://patchwork.freedesktop.org/series/94648/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
d3fcbc14d6ee drm/i915/gem: Break out some shmem backend utils
5e8ae127a95f drm/ttm: add TTM_PAGE_FLAG_SHMEM
56dd3266c291 drm/i915/ttm: add tt shmem backend
89087b82443e drm/i915/ttm: use cached system pages when evicting lmem
3eb4ab240a73 drm/i915: try to simplify make_{un}shrinkable
-:164: CHECK:LINE_SPACING: Please don't use multiple blank lines
#164: FILE: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:510:+
total: 0 errors, 0 warnings, 1 checks, 194 lines checked f2013b99cd76 drm/i915/ttm: make evicted shmem pages visible to the shrinker dba19f313885 drm/i915/ttm: enable shmem tt backend
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils
URL : https://patchwork.freedesktop.org/series/94648/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +./drivers/gpu/drm/amd/amdgpu/../amdgpu/amdgv_sriovmsg.h:316:49: error: static assertion failed: "amd_sriov_msg_pf2vf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1345:25: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1345:25: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1345:25: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1346:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1346:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1346:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1405:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1405:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c:1405:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:354:16: error: incompatible types in comparison expression (different type sizes): +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:354:16: unsigned long * +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:354:16: unsigned long long * +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4483:31: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4483:31: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4483:31: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4485:33: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4485:33: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:4485:33: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:294:25: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:294:25: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:294:25: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:295:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:295:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:295:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:344:17: error: incompatible types in comparison expression (different address spaces): +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:344:17: struct dma_fence * +drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c:344:17: struct dma_fence [noderef] __rcu * +drivers/gpu/drm/amd/amdgpu/amdgpu_mca.c:117:1: warning: no newline at end of file +drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.h:123:51: error: marked inline, but without a definition +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2pf_info must be 1 KB" +drivers/gpu/drm/amd/amdgpu/amdgv_sriovmsg.h:312:49: error: static assertion failed: "amd_sriov_msg_vf2p
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils
In reply to Matthew Auld== Series Details ==
== Series Details ==
Series: series starting with [v2,1/7] drm/i915/gem: Break out some shmem backend utils
URL : https://patchwork.freedesktop.org/series/94648/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10579 -> Patchwork_21037
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_21037 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_21037, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21037/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_21037:
### IGT changes ###
#### Possible regressions ####
* igt@gem_exec_suspend@basic-s3:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21037/bat-dg1-5/igt@[email protected]
* igt@runner@aborted:
- bat-dg1-5: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21037/bat-dg1-5/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_21037 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@info:
- bat-dg1-5: NOTRUN -> [SKIP][3] ([i915#2582]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21037/bat-dg1-5/igt@[email protected]
* igt@gem_exec_gttfill@basic:
- bat-dg1-5: NOTRUN -> [SKIP][4] ([i915#4086])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21037/bat-dg1-5/igt@[email protected]
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#4086]: https://gitlab.freedesktop.org/drm/intel/issues/4086
Participating hosts (39 -> 38)
------------------------------
Additional (1): bat-dg1-5
Missing (2): fi-bsw-cyan fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_10579 -> Patchwork_21037
CI-20190529: 20190529
CI_DRM_10579: a83151fa02e8d3e90729db21ee0e3830ff8c9565 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6209: 07d6594ed02f55b68d64fa6dd7f80cfbc1ce4ef8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_21037: dba19f313885f552e2cdd7df3c3a267618329722 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
dba19f313885 drm/i915/ttm: enable shmem tt backendf2013b99cd76 drm/i915/ttm: make evicted shmem pages visible to the shrinker 3eb4ab240a73 drm/i915: try to simplify make_{un}shrinkable 89087b82443e drm/i915/ttm: use cached system pages when evicting lmem 56dd3266c291 drm/i915/ttm: add tt shmem backend5e8ae127a95f drm/ttm: add TTM_PAGE_FLAG_SHMEMd3fcbc14d6ee drm/i915/gem: Break out some shmem backend utils
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_21037/index.html