mm/memory: Avoid unnecessary kernel/user pointer conversion
Subsystems (2)
PATCH 1/1 mm/memory: Avoid unnecessary kernel/user pointer conversion
Annotating a pointer from __user to kernel and then back again might confuse sparse. In copy_huge_page_from_user() it can be avoided by removing the intermediate variable since it is never used.
Cc Andrew Morton <[email protected]>
Signed-off-by Amit Daniel Kachhap <[email protected]>
--- mm/memory.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
mm/memory.c +1 -3
@@ -5411,7 +5411,6 @@ long copy_huge_page_from_user(struct page *dst_page,unsigned int pages_per_huge_page, bool allow_pagefault) { - void *src = (void *)usr_src; void *page_kaddr;unsigned long i, rc =0 ;unsigned long ret_val = pages_per_huge_page *PAGE_SIZE ;
@@ -5424,8 +5423,7 @@ long copy_huge_page_from_user(struct page *dst_page,else page_kaddr =kmap_atomic (subpage); rc =copy_from_user (page_kaddr, - (const void __user *)(src + i *PAGE_SIZE ), -PAGE_SIZE ); + usr_src + i *PAGE_SIZE ,PAGE_SIZE );if (allow_pagefault)kunmap (subpage);else
Signature · 1 line
2.17.1
Quoted 6 lines · Amit Daniel Kachhap
Annotating a pointer from
__userto kernel and then back again might confuse sparse. Incopy_huge_page_from_user()it can be avoided by removing the intermediate variable since it is never used.Cc Andrew Morton <[email protected]>Signed-off-by Amit Daniel Kachhap <[email protected]>
Signature · 1 line
Kirill A. Shutemov