Skip to contentSkip to conversation

vhost: Normalize return type and function name

PATCH Superseded Xuan Ding 3 participants 4 messages Sep 16, 2021 – Sep 28, 2021

lore
Share & tools
lore

Xuan Ding

author
#0 lore raw

PATCH 1/1 vhost: Normalize return type and function name

In function definitions, adjust some return types and function names on a separate line to be consistent with DPDK coding style.

---
 lib/vhost/vhost.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
lib/vhost/vhost.c +10 -5
index 24ae1025ea..69e9d229af 100644
@@ -1500,7 +1500,8 @@ rte_vhost_get_vdpa_device(int vid)
 	return dev->vdpa_dev;
 }
 
-int rte_vhost_get_log_base(int vid, uint64_t *log_base,
+int
+rte_vhost_get_log_base(int vid, uint64_t *log_base,
 		uint64_t *log_size)
 {
 	struct virtio_net *dev = get_device(vid);
@@ -1514,7 +1515,8 @@ int rte_vhost_get_log_base(int vid, uint64_t *log_base,
 	return 0;
 }
 
-int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_get_vring_base(int vid, uint16_t queue_id,
 		uint16_t *last_avail_idx, uint16_t *last_used_idx)
 {
 	struct vhost_virtqueue *vq;
@@ -1543,7 +1545,8 @@ int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
 	return 0;
 }
 
-int rte_vhost_set_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_set_vring_base(int vid, uint16_t queue_id,
 		uint16_t last_avail_idx, uint16_t last_used_idx)
 {
 	struct vhost_virtqueue *vq;
@@ -1606,7 +1609,8 @@ rte_vhost_get_vring_base_from_inflight(int vid,
 	return 0;
 }
 
-int rte_vhost_extern_callback_register(int vid,
+int
+rte_vhost_extern_callback_register(int vid,
 		struct rte_vhost_user_extern_ops const * const ops, void *ctx)
 {
 	struct virtio_net *dev = get_device(vid);
@@ -1854,7 +1858,8 @@ rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t queue_id)
 	return 0;
 }
 
-int rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
+int
+rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
 {
 	struct vhost_virtqueue *vq;
 	struct virtio_net *dev = get_device(vid);
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH v2 1/1 vhost: normalize return type and function name

In some function definitions, adjust return type and function name on a separate line to be consistent with DPDK coding style.

---
v2:
* Fixed one format issue.

---
 lib/vhost/vhost.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)
lib/vhost/vhost.c +10 -5
index 24ae1025ea..69e9d229af 100644
@@ -1500,7 +1500,8 @@ rte_vhost_get_vdpa_device(int vid)
 	return dev->vdpa_dev;
 }
 
-int rte_vhost_get_log_base(int vid, uint64_t *log_base,
+int
+rte_vhost_get_log_base(int vid, uint64_t *log_base,
 		uint64_t *log_size)
 {
 	struct virtio_net *dev = get_device(vid);
@@ -1514,7 +1515,8 @@ int rte_vhost_get_log_base(int vid, uint64_t *log_base,
 	return 0;
 }
 
-int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_get_vring_base(int vid, uint16_t queue_id,
 		uint16_t *last_avail_idx, uint16_t *last_used_idx)
 {
 	struct vhost_virtqueue *vq;
@@ -1543,7 +1545,8 @@ int rte_vhost_get_vring_base(int vid, uint16_t queue_id,
 	return 0;
 }
 
-int rte_vhost_set_vring_base(int vid, uint16_t queue_id,
+int
+rte_vhost_set_vring_base(int vid, uint16_t queue_id,
 		uint16_t last_avail_idx, uint16_t last_used_idx)
 {
 	struct vhost_virtqueue *vq;
@@ -1606,7 +1609,8 @@ rte_vhost_get_vring_base_from_inflight(int vid,
 	return 0;
 }
 
-int rte_vhost_extern_callback_register(int vid,
+int
+rte_vhost_extern_callback_register(int vid,
 		struct rte_vhost_user_extern_ops const * const ops, void *ctx)
 {
 	struct virtio_net *dev = get_device(vid);
@@ -1854,7 +1858,8 @@ rte_vhost_async_channel_unregister_thread_unsafe(int vid, uint16_t queue_id)
 	return 0;
 }
 
-int rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
+int
+rte_vhost_async_get_inflight(int vid, uint16_t queue_id)
 {
 	struct vhost_virtqueue *vq;
 	struct virtio_net *dev = get_device(vid);
Signature · 1 line
2.17.1
Reviewed-by on v2 1/1
#2 lore raw

Re: [dpdk-dev] [PATCH v2] vhost: normalize return type and function name

Quoted 15 lines

-----Original Message-----
From: Ding, Xuan <[email protected]>
Sent: Thursday, September 16, 2021 12:34 PM
To: [email protected]; [email protected]; Xia, Chenbo <[email protected]>
Cc: Hu, Jiayu <[email protected]>; Jiang, Cheng1 <[email protected]>; Richardson, Bruce <[email protected]>; Pai G, Sunil <[email protected]>; Yang, YvonneX <[email protected]>; Ding, Xuan <[email protected]>
Subject: [PATCH v2] vhost: normalize return type and function name

In some function definitions, adjust return type and function name on a separate line to be consistent with DPDK coding style.

Quoted 8 lines

---
v2:
* Fixed one format issue.

---
 lib/vhost/vhost.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

--
2.17.1

Thanks for the clean-up!

#3 lore raw

Re: [dpdk-dev] [PATCH v2] vhost: normalize return type and function name

In reply to Xuan Ding
Quoted 11 lines · Xuan Ding

In some function definitions, adjust return type and function name on a separate line to be consistent with DPDK coding style.

---
v2:
* Fixed one format issue.

---
  lib/vhost/vhost.c | 15 ++++++++++-----
  1 file changed, 10 insertions(+), 5 deletions(-)

Applied to dpdk-next-virtio/main.

Thanks,
Maxime