arm: aspeed: Add UART routing support
v5 cover arm: aspeed: Add UART routing support
Add UART routing driver and the device tree nodes.
v5:
- Fix typo in YAML file to solve the compatible string not found error
v4:
- Convert aspeed-lpc bindings to YAML schema to resolve dependecy issues
v3:
- Add individual bindings in YAML
- Add support for AST24xx (AST25xx shares the same design)
- Add more explanation for the sysfs ABI
v2:
- Add dt-bindings
- Add ABI documents for the exported sysfs interface
- Revise driver implementation suggested by Joel
Chia-Wei Wang (4):
dt-bindings: mfd: aspeed-lpc: Convert to YAML schema
dt-bindings: aspeed: Add UART routing controller
soc: aspeed: Add UART routing support
ARM: dts: aspeed: Add uart routing to device tree
.../testing/sysfs-driver-aspeed-uart-routing | 15 + .../devicetree/bindings/mfd/aspeed-lpc.txt | 157 ----- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 191 ++++++ .../bindings/soc/aspeed/uart-routing.yaml | 70 ++ arch/arm/boot/dts/aspeed-g4.dtsi | 6 + arch/arm/boot/dts/aspeed-g5.dtsi | 6 + arch/arm/boot/dts/aspeed-g6.dtsi | 6 + drivers/soc/aspeed/Kconfig | 10 + drivers/soc/aspeed/Makefile | 9 +- drivers/soc/aspeed/aspeed-uart-routing.c | 603 ++++++++++++++++++ 10 files changed, 912 insertions(+), 161 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml create mode 100644 drivers/soc/aspeed/aspeed-uart-routing.c
Signature · 1 line
2.17.1
PATCH v5 1/4 dt-bindings: mfd: aspeed-lpc: Convert to YAML schema
Convert the bindings of Aspeed LPC from text file into YAML schema.
--- .../devicetree/bindings/mfd/aspeed-lpc.txt | 157 --------------- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 187 ++++++++++++++++++ 2 files changed, 187 insertions(+), 157 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0 -157
@@ -1,157 +0,0 @@ -====================================================================== -Device tree bindings for the Aspeed Low Pin Count (LPC) Bus Controller -====================================================================== - -The LPC bus is a means to bridge a host CPU to a number of low-bandwidth -peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The -primary use case of the Aspeed LPC controller is as a slave on the bus -(typically in a Baseboard Management Controller SoC), but under certain -conditions it can also take the role of bus master. - -The LPC controller is represented as a multi-function device to account for the -mix of functionality, which includes, but is not limited to: - -* An IPMI Block Transfer[2] Controller - -* An LPC Host Controller: Manages LPC functions such as host vs slave mode, the - physical properties of some LPC pins, configuration of serial IRQs, and - APB-to-LPC bridging amonst other functions. - -* An LPC Host Interface Controller: Manages functions exposed to the host such - as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART - management and bus snoop configuration. - -* A set of SuperIO[3] scratch registers: Enables implementation of e.g. custom - hardware management protocols for handover between the host and baseboard - management controller. - -Additionally the state of the LPC controller influences the pinmux -configuration, therefore the host portion of the controller is exposed as a -syscon as a means to arbitrate access. - -[0] http://www.intel.com/design/chipsets/industry/25128901.pdf -[1] https://www.renesas.com/en-sg/doc/products/mpumcu/001/rej09b0078_h8s2168.pdf?key=7c88837454702128622bee53acbda8f4 -[2] https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf -[3] https://en.wikipedia.org/wiki/Super_I/O - -Required properties -=================== - -- compatible: One of: - "aspeed,ast2400-lpc-v2", "simple-mfd", "syscon" - "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon" - "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon" - -- reg: contains the physical address and length values of the Aspeed - LPC memory region. - -- #address-cells: <1> -- #size-cells: <1> -- ranges: Maps 0 to the physical address and length of the LPC memory - region - -Example: - -lpc: lpc at 1e789000 { - compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"; - reg = <0x1e789000 0x1000>; - - #address-cells = <1>; - #size-cells = <1>; - ranges = <0x0 0x1e789000 0x1000>; - - lpc_snoop: lpc-snoop at 0 { - compatible = "aspeed,ast2600-lpc-snoop"; - reg = <0x0 0x80>; - interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>; - snoop-ports = <0x80>; - }; -}; - - -LPC Host Interface Controller -------------------- - -The LPC Host Interface Controller manages functions exposed to the host such as -LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART -management and bus snoop configuration. - -Required properties: - -- compatible: One of: - "aspeed,ast2400-lpc-ctrl"; - "aspeed,ast2500-lpc-ctrl"; - "aspeed,ast2600-lpc-ctrl"; - -- reg: contains offset/length values of the host interface controller - memory regions - -- clocks: contains a phandle to the syscon node describing the clocks. - There should then be one cell representing the clock to use - -Optional properties: - -- memory-region: A phandle to a reserved_memory region to be used for the LPC - to AHB mapping - -- flash: A phandle to the SPI flash controller containing the flash to - be exposed over the LPC to AHB mapping - -Example: - -lpc_ctrl: lpc-ctrl at 80 { - compatible = "aspeed,ast2500-lpc-ctrl"; - reg = <0x80 0x80>; - clocks = <&syscon ASPEED_CLK_GATE_LCLK>; - memory-region = <&flash_memory>; - flash = <&spi>; -}; - -LPC Host Controller -------------------- - -The Aspeed LPC Host Controller configures the Low Pin Count (LPC) bus behaviour -between the host and the baseboard management controller. The registers exist -in the "host" portion of the Aspeed LPC controller, which must be the parent of -the LPC host controller node. - -Required properties: - -- compatible: One of: - "aspeed,ast2400-lhc"; - "aspeed,ast2500-lhc"; - "aspeed,ast2600-lhc"; - -- reg: contains offset/length values of the LHC memory regions. In the - AST2400 and AST2500 there are two regions. - -Example: - -lhc: lhc at a0 { - compatible = "aspeed,ast2500-lhc"; - reg = <0xa0 0x24 0xc8 0x8>; -}; - -LPC reset control ------------------ - -The UARTs present in the ASPEED SoC can have their resets tied to the reset -state of the LPC bus. Some systems may chose to modify this configuration. - -Required properties: - - - compatible: One of: - "aspeed,ast2600-lpc-reset"; - "aspeed,ast2500-lpc-reset"; - "aspeed,ast2400-lpc-reset"; - - - reg: offset and length of the IP in the LHC memory region - - #reset-controller indicates the number of reset cells expected - -Example: - -lpc_reset: reset-controller at 98 { - compatible = "aspeed,ast2500-lpc-reset"; - reg = <0x98 0x4>; - #reset-cells = <1>; -};
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +187 -0
187 lines not on this page · raw message
Signature · 1 line
2.17.1
Rob Herring
maintainerRe: [PATCH v5 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema
Quoted 10 lines · Chia-Wei Wang
Convert the bindings of Aspeed LPC from text file into YAML schema.
Signed-off-by Chia-Wei Wang <[email protected]>--- .../devicetree/bindings/mfd/aspeed-lpc.txt | 157 --------------- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 187 ++++++++++++++++++ 2 files changed, 187 insertions(+), 157 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:Documentation/devicetree/bindings/mfd/aspeed-lpc.example.dt.yaml:0:0: /example-0/lpc at 1e789000/lpc-snoop at 90: failed to match any schema with compatible: ['aspeed,ast2600-lpc-snoop']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1528736
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
Rob Herring
maintainerRe: [PATCH v5 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema
In reply to Chia-Wei WangQuoted 292 lines · Chia-Wei Wang
Convert the bindings of Aspeed LPC from text file into YAML schema.
Signed-off-by Chia-Wei Wang <[email protected]>--- .../devicetree/bindings/mfd/aspeed-lpc.txt | 157 --------------- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 187 ++++++++++++++++++ 2 files changed, 187 insertions(+), 157 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.yamlDocumentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-157@@ -1,157 +0,0 @@ -====================================================================== -Device tree bindings for the Aspeed Low Pin Count (LPC) Bus Controller -====================================================================== - -The LPC bus is a means to bridge a host CPU to a number of low-bandwidth -peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The -primary use case of the Aspeed LPC controller is as a slave on the bus -(typically in a Baseboard Management Controller SoC), but under certain -conditions it can also take the role of bus master. - -The LPC controller is represented as a multi-function device to account for the -mix of functionality, which includes, but is not limited to: - -* An IPMI Block Transfer[2] Controller - -* An LPC Host Controller: Manages LPC functions such as host vs slave mode, the - physical properties of some LPC pins, configuration of serial IRQs, and - APB-to-LPC bridging amonst other functions. - -* An LPC Host Interface Controller: Manages functions exposed to the host such - as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART - management and bus snoop configuration. - -* A set of SuperIO[3] scratch registers: Enables implementation of e.g. custom - hardware management protocols for handover between the host and baseboard - management controller. - -Additionally the state of the LPC controller influences the pinmux -configuration, therefore the host portion of the controller is exposed as a -syscon as a means to arbitrate access. - -[0] http://www.intel.com/design/chipsets/industry/25128901.pdf -[1] https://www.renesas.com/en-sg/doc/products/mpumcu/001/rej09b0078_h8s2168.pdf?key=7c88837454702128622bee53acbda8f4 -[2] https://www.intel.com/content/dam/www/public/us/en/documents/product-briefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf -[3] https://en.wikipedia.org/wiki/Super_I/O - -Required properties -=================== - -- compatible: One of: - "aspeed,ast2400-lpc-v2", "simple-mfd", "syscon" - "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon" - "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon" - -- reg: contains the physical address and length values of the Aspeed - LPC memory region. - -- #address-cells: <1> -- #size-cells: <1> -- ranges: Maps 0 to the physical address and length of the LPC memory - region - -Example: - -lpc: lpc at 1e789000 { - compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"; - reg = <0x1e789000 0x1000>; - - #address-cells = <1>; - #size-cells = <1>; - ranges = <0x0 0x1e789000 0x1000>; - - lpc_snoop: lpc-snoop at 0 { - compatible = "aspeed,ast2600-lpc-snoop"; - reg = <0x0 0x80>; - interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>; - snoop-ports = <0x80>; - }; -}; - - -LPC Host Interface Controller -------------------- - -The LPC Host Interface Controller manages functions exposed to the host such as -LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART -management and bus snoop configuration. - -Required properties: - -- compatible: One of: - "aspeed,ast2400-lpc-ctrl"; - "aspeed,ast2500-lpc-ctrl"; - "aspeed,ast2600-lpc-ctrl"; - -- reg: contains offset/length values of the host interface controller - memory regions - -- clocks: contains a phandle to the syscon node describing the clocks. - There should then be one cell representing the clock to use - -Optional properties: - -- memory-region: A phandle to a reserved_memory region to be used for the LPC - to AHB mapping - -- flash: A phandle to the SPI flash controller containing the flash to - be exposed over the LPC to AHB mapping - -Example: - -lpc_ctrl: lpc-ctrl at 80 { - compatible = "aspeed,ast2500-lpc-ctrl"; - reg = <0x80 0x80>; - clocks = <&syscon ASPEED_CLK_GATE_LCLK>; - memory-region = <&flash_memory>; - flash = <&spi>; -}; - -LPC Host Controller -------------------- - -The Aspeed LPC Host Controller configures the Low Pin Count (LPC) bus behaviour -between the host and the baseboard management controller. The registers exist -in the "host" portion of the Aspeed LPC controller, which must be the parent of -the LPC host controller node. - -Required properties: - -- compatible: One of: - "aspeed,ast2400-lhc"; - "aspeed,ast2500-lhc"; - "aspeed,ast2600-lhc"; - -- reg: contains offset/length values of the LHC memory regions. In the - AST2400 and AST2500 there are two regions. - -Example: - -lhc: lhc at a0 { - compatible = "aspeed,ast2500-lhc"; - reg = <0xa0 0x24 0xc8 0x8>; -}; - -LPC reset control ------------------ - -The UARTs present in the ASPEED SoC can have their resets tied to the reset -state of the LPC bus. Some systems may chose to modify this configuration. - -Required properties: - - - compatible: One of: - "aspeed,ast2600-lpc-reset"; - "aspeed,ast2500-lpc-reset"; - "aspeed,ast2400-lpc-reset"; - - - reg: offset and length of the IP in the LHC memory region - - #reset-controller indicates the number of reset cells expected - -Example: - -lpc_reset: reset-controller at 98 { - compatible = "aspeed,ast2500-lpc-reset"; - reg = <0x98 0x4>; - #reset-cells = <1>; -};Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +113
-0@@ -0,0 +1,187 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# # Copyright (c) 2021 Aspeed Tehchnology Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed Low Pin Count (LPC) Bus Controller + +maintainers: + - Andrew Jeffery <[email protected]> + - Chia-Wei Wang <[email protected]> + +description: + The LPC bus is a means to bridge a host CPU to a number of low-bandwidth + peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The + primary use case of the Aspeed LPC controller is as a slave on the bus + (typically in a Baseboard Management Controller SoC), but under certain + conditions it can also take the role of bus master. + + The LPC controller is represented as a multi-function device to account for the + mix of functionality, which includes, but is not limited to + + * An IPMI Block Transfer[2] Controller + + * An LPC Host Interface Controller manages functions exposed to the host such + as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART + management and bus snoop configuration. + + * A set of SuperIO[3] scratch registers enableing implementation of e.g. custom + hardware management protocols for handover between the host and baseboard + management controller. + + Additionally the state of the LPC controller influences the pinmux + configuration, therefore the host portion of the controller is exposed as a + syscon as a means to arbitrate access. + +properties: + compatible: + items: + - enum: + - aspeed,ast2400-lpc-v2 + - aspeed,ast2500-lpc-v2 + - aspeed,ast2600-lpc-v2 + - const: simple-mfd + - const: syscon + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + + ranges: true + +patternProperties: + "^lpc-ctrl@[0-9a-f]+$": + type: object + + description: + The LPC Host Interface Controller manages functions exposed to the host such as + LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART management + and bus snoop configuration. + + properties: + compatible: + items: + - enum: + - aspeed,ast2400-lpc-ctrl + - aspeed,ast2500-lpc-ctrl + - aspeed,ast2600-lpc-ctrl + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + memory-region: + $ref: /schemas/types.yaml#/definitions/phandle + description: A reserved_memory region to be used for the LPC to AHB mapping + + flash: + $ref: /schemas/types.yaml#/definitions/phandle + description: The SPI flash controller containing the flash to be exposed over the LPC to AHB mapping + + required: + - compatible + - clocks + + "^reset-controller@[0-9a-f]+$": + type: object + + description: + The UARTs present in the ASPEED SoC can have their resets tied to the reset + state of the LPC bus. Some systems may chose to modify this configuration + + properties: + compatible: + items: + - enum: + - aspeed,ast2400-lpc-reset + - aspeed,ast2500-lpc-reset + - aspeed,ast2600-lpc-reset + + reg: + maxItems: 1 + + required: + - compatible
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 123
Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +10
-0+ + "^lpc-snoop@[0-9a-f]+$": + type: object + + description: + The LPC snoop interface allows the BMC to listen on and record the data + bytes written by the Host to the targeted LPC I/O pots. + + properties: + comptabile:
I guess I have to point out *every* instance of your typo?
Run 'make dt_binding_check' and find these problems before you send this out.
Rob
RE: [PATCH v5 1/4] dt-bindings: mfd: aspeed-lpc: Convert to YAML schema
Hi Rob,
Quoted 349 lines
From: Rob Herring <[email protected]>
Sent: Thursday, September 16, 2021 10:32 PMQuoted 6 lines · Chia-Wei Wang
Convert the bindings of Aspeed LPC from text file into YAML schema.
Signed-off-by Chia-Wei Wang <[email protected]>--- .../devicetree/bindings/mfd/aspeed-lpc.txt | 157 --------------- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 187++++++++++++++++++
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
Quoted 13 lines
2 files changed, 187 insertions(+), 157 deletions(-) delete mode 100644 Documentation/devicetree/bindings/mfd/aspeed-lpc.txt create mode 100644
Documentation/devicetree/bindings/mfd/aspeed-lpc.yamlDocumentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-0@@ -1,157 +0,0 @@-===============================================================
======Quoted 3 lines
= -Device tree bindings for the Aspeed Low Pin Count (LPC) Bus Controller
-===============================================================
======Quoted 7 lines
=
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-2- -The LPC bus is a means to bridge a host CPU to a number oflow-bandwidth -peripheral devices, replacing the use of the ISA bus in the age of PCI[0]. The -primary use case of the Aspeed LPC controller is as a slave on the bus -(typically in a Baseboard Management Controller SoC), but under certain -conditions it can also take the role of bus
master.
Quoted 26 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-2- -The LPC controller is represented as a multi-function device toaccount for the -mix of functionality, which includes, but is not limited to:
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-4- -* An IPMI Block Transfer[2] Controller - -* An LPC Host Controller: Manages LPC functions such as host vs slavemode, the
- physical properties of some LPC pins, configuration of serial IRQs, andDocumentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-3- APB-to-LPC bridging amonst other functions. - -* An LPC Host Interface Controller: Manages functions exposed to thehost such
- as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UARTDocumentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-3- management and bus snoop configuration. - -* A set of SuperIO[3] scratch registers: Enables implementation ofe.g. custom
- hardware management protocols for handover between the host and baseboardDocumentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-4- management controller. - -Additionally the state of the LPC controller influences the pinmux -configuration, therefore the host portion of the controller isQuoted 5 lines
exposed as a -syscon as a means to arbitrate access. -
-[0] http://www.intel.com/design/chipsets/industry/25128901.pdf
-[1]https://www.renesas.com/en-sg/doc/products/mpumcu/001/rej09b0078_h8s2
1Quoted 3 lines
68.pdf?key=7c88837454702128622bee53acbda8f4
-[2]https://www.intel.com/content/dam/www/public/us/en/documents/product-b
Quoted 51 lines
riefs/ipmi-second-gen-interface-spec-v2-rev1-1.pdf -[3] https://en.wikipedia.org/wiki/Super_I/O
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-40- -Required properties -=================== - -- compatible: One of: - "aspeed,ast2400-lpc-v2", "simple-mfd", "syscon" - "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon" - "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon" - -- reg: contains the physical address and length values of the Aspeed - LPC memory region. - -- #address-cells: <1> -- #size-cells: <1> -- ranges: Maps 0 to the physical address and length of the LPC memory - region - -Example: - -lpc: lpc at 1e789000 { - compatible = "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"; - reg = <0x1e789000 0x1000>; - - #address-cells = <1>; - #size-cells = <1>; - ranges = <0x0 0x1e789000 0x1000>; - - lpc_snoop: lpc-snoop at 0 { - compatible = "aspeed,ast2600-lpc-snoop"; - reg = <0x0 0x80>; - interrupts = <GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH>; - snoop-ports = <0x80>; - }; -}; - - -LPC Host Interface Controller -------------------- - -The LPC Host Interface Controller manages functions exposed to thehost such as -LPC firmware hub cycles, configuration of the LPC-to-AHB mapping, UART -management and bus snoop configuration.
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-7- -Required properties: - -- compatible: One of: - "aspeed,ast2400-lpc-ctrl"; - "aspeed,ast2500-lpc-ctrl"; - "aspeed,ast2600-lpc-ctrl";Documentation/devicetree/bindings/mfd/aspeed-lpc.txt
Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-10- -- reg: contains offset/length values of the host interface controller - memory regions - -- clocks: contains a phandle to the syscon node describing the clocks. - There should then be one cell representing the clock to use - -Optional properties: - -- memory-region: A phandle to a reserved_memory region to be used forthe LPC
Quoted 44 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-19- to AHB mapping - -- flash: A phandle to the SPI flash controller containing the flash to - be exposed over the LPC to AHB mapping - -Example: - -lpc_ctrl: lpc-ctrl at 80 { - compatible = "aspeed,ast2500-lpc-ctrl"; - reg = <0x80 0x80>; - clocks = <&syscon ASPEED_CLK_GATE_LCLK>; - memory-region = <&flash_memory>; - flash = <&spi>; -}; - -LPC Host Controller -------------------- - -The Aspeed LPC Host Controller configures the Low Pin Count (LPC) busbehaviour -between the host and the baseboard management controller. The registers exist -in the "host" portion of the Aspeed LPC controller, which must be the parent of -the LPC host controller node.
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-22- -Required properties: - -- compatible: One of: - "aspeed,ast2400-lhc"; - "aspeed,ast2500-lhc"; - "aspeed,ast2600-lhc"; - -- reg: contains offset/length values of the LHC memory regions. In the - AST2400 and AST2500 there are two regions. - -Example: - -lhc: lhc at a0 { - compatible = "aspeed,ast2500-lhc"; - reg = <0xa0 0x24 0xc8 0x8>; -}; - -LPC reset control ------------------ - -The UARTs present in the ASPEED SoC can have their resets tied to theQuoted 1 line
reset -state of the LPC bus. Some systems may chose to modify this
configuration.
Quoted 46 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.txt deleted +0
-18- -Required properties: - - - compatible: One of: - "aspeed,ast2600-lpc-reset"; - "aspeed,ast2500-lpc-reset"; - "aspeed,ast2400-lpc-reset"; - - - reg: offset and length of the IP in the LHC memory region - - #reset-controller indicates the number of reset cells expected - -Example: - -lpc_reset: reset-controller at 98 { - compatible = "aspeed,ast2500-lpc-reset"; - reg = <0x98 0x4>; - #reset-cells = <1>; -};Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +21
-0@@ -0,0 +1,187 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # # +Copyright (c) 2021 Aspeed Tehchnology Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/aspeed-lpc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Aspeed Low Pin Count (LPC) Bus Controller + +maintainers: + - Andrew Jeffery <[email protected]> + - Chia-Wei Wang <[email protected]> + +description: + The LPC bus is a means to bridge a host CPU to a number of +low-bandwidth + peripheral devices, replacing the use of the ISA bus in the age of +PCI[0]. The + primary use case of the Aspeed LPC controller is as a slave on the +bus + (typically in a Baseboard Management Controller SoC), but underDocumentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 31
Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +10
-0+certain + conditions it can also take the role of bus master. + + The LPC controller is represented as a multi-function device to + account for the mix of functionality, which includes, but is not + limited to + + * An IPMI Block Transfer[2] Controller + + * An LPC Host Interface Controller manages functions exposed to the hostsuch
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 32
Quoted 1 line
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +1
-0+ as LPC firmware hub cycles, configuration of the LPC-to-AHB mapping,UART
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Quoted 3 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +3
-0+ management and bus snoop configuration. + + * A set of SuperIO[3] scratch registers enableing implementation of e.g.custom
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 36
Quoted 1 line
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +1
-0+ hardware management protocols for handover between the host andbaseboard
Quoted 23 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +23
-0+ management controller. + + Additionally the state of the LPC controller influences the pinmux + configuration, therefore the host portion of the controller is + exposed as a syscon as a means to arbitrate access. + +properties: + compatible: + items: + - enum: + - aspeed,ast2400-lpc-v2 + - aspeed,ast2500-lpc-v2 + - aspeed,ast2600-lpc-v2 + - const: simple-mfd + - const: syscon + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells":Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +10
-0+ const: 1 + + ranges: true + +patternProperties: + "^lpc-ctrl@[0-9a-f]+$": + type: object + + description: + The LPC Host Interface Controller manages functions exposed to thehost such as
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 70
Quoted 1 line
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +1
-0+ LPC firmware hub cycles, configuration of the LPC-to-AHB mapping,UART management
Quoted 25 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +25
-0+ and bus snoop configuration. + + properties: + compatible: + items: + - enum: + - aspeed,ast2400-lpc-ctrl + - aspeed,ast2500-lpc-ctrl + - aspeed,ast2600-lpc-ctrl + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + memory-region: + $ref: /schemas/types.yaml#/definitions/phandle + description: A reserved_memory region to be used for the LPC + to AHB mapping + + flash: + $ref: /schemas/types.yaml#/definitions/phandle + description: The SPI flash controller containing the flash to + be exposed over the LPC to AHB mappingDocumentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +10
-0+ + required: + - compatible + - clocks + + "^reset-controller@[0-9a-f]+$": + type: object + + description: + The UARTs present in the ASPEED SoC can have their resets tied tothe reset
Quoted 12 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +12
-0+ state of the LPC bus. Some systems may chose to modify this + configuration + + properties: + compatible: + items: + - enum: + - aspeed,ast2400-lpc-reset + - aspeed,ast2500-lpc-reset + - aspeed,ast2600-lpc-reset + + reg:Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml
Quoted 10 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +10
-0+ maxItems: 1 + + required: + - compatible + + "^lpc-snoop@[0-9a-f]+$": + type: object + + description: + The LPC snoop interface allows the BMC to listen on and record thedata
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml line 123
Quoted 4 lines
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml new file +4
-0+ bytes written by the Host to the targeted LPC I/O pots. + + properties: + comptabile:
Quoted 4 lines
I guess I have to point out *every* instance of your typo?
Run 'make
dt_binding_check' and find these problems before you send this out.
Sorry for making this error again.
I missed the "DT_CHECKER_FLAGS=-m" command line argument and thus the warning did not show up. Will keep in mind next time. Thanks for your help.
Chiawei
PATCH v5 2/4 dt-bindings: aspeed: Add UART routing controller
In reply to Chia-Wei WangAdd dt-bindings for Aspeed UART routing controller.
--- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 4 ++ .../bindings/soc/aspeed/uart-routing.yaml | 70 +++++++++++++++++++ 2 files changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml
Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml +4 -0
@@ -142,6 +142,10 @@ patternProperties: - interrupts - snoop-ports + "^uart-routing@[0-9a-f]+$": + $ref: /schemas/soc/aspeed/uart-routing.yaml# + description: The UART routing control under LPC register space + required: - compatible - reg
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +70 -0
70 lines not on this page · raw message
Signature · 1 line
2.17.1
Rob Herring
maintainerRe: [PATCH v5 2/4] dt-bindings: aspeed: Add UART routing controller
Quoted 60 lines · Chia-Wei Wang
Add dt-bindings for Aspeed UART routing controller.
Signed-off-by Oskar Senft <[email protected]>Signed-off-by Chia-Wei Wang <[email protected]>--- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 4 ++ .../bindings/soc/aspeed/uart-routing.yaml | 70 +++++++++++++++++++ 2 files changed, 74 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/aspeed/uart-routing.yamlDocumentation/devicetree/bindings/mfd/aspeed-lpc.yaml +4
-0@@ -142,6 +142,10 @@ patternProperties: - interrupts - snoop-ports + "^uart-routing@[0-9a-f]+$": + $ref: /schemas/soc/aspeed/uart-routing.yaml# + description: The UART routing control under LPC register space + required: - compatible - regDocumentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +29
-0@@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# # Copyright (c) 2018 Google LLC +# # Copyright (c) 2021 Aspeed Technology Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/aspeed/uart-routing.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Aspeed UART Routing Controller + +maintainers: + - Oskar Senft <[email protected]> + - Chia-Wei Wang <[email protected]> + +description: + The Aspeed UART routing control allow to dynamically route the inputs for + the built-in UARTS and physical serial I/O ports. + + This allows, for example, to connect the output of UART to another UART. + This can be used to enable Host <-> BMC communication via UARTs, e.g. to + allow access to the Host's serial console. + + This driver is for the BMC side. The sysfs files allow the BMC userspace + which owns the system configuration policy, to configure how UARTs and + physical serial I/O ports are routed. + + Two types of files, uart* and io*, are presented in sysfs. The uart* + configures the input signal of a UART controller whereas io* configures + that of a physical serial port.
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml line 39
Quoted 10 lines
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +10
-0+ + When read, each file shows the list of available options with currently + selected option marked by brackets "[]". The list of available options + depends on the selected file. + + e.g. + cat /sys/bus/platform/drivers/aspeed-uart-routing/*.uart_routing/uart1 + [io1] io2 io3 io4 uart2 uart3 uart4 io6 + + In this case, UART1 gets its input from IO1 (physical serial port 1).
This is about documenting the hardware, not an OS driver.
sysfs files have their own documentation.
Quoted 35 lines
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +31
-0+ +properties: + compatible: + items: + - enum: + - aspeed,ast2400-uart-routing + - aspeed,ast2500-uart-routing + - aspeed,ast2600-uart-routing + reg: + maxItems: 1 + +required: + - compatible + +additionalProperties: false + +examples: + - | + lpc: lpc at 1e789000 { + compatible = "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon"; + reg = <0x1e789000 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x1e789000 0x1000>; + + uart_routing: uart-routing at 98 { + compatible = "aspeed,ast2600-uart-routing"; + reg = <0x98 0x8>; + }; + };Signature · 1 line
2.17.1
RE: [PATCH v5 2/4] dt-bindings: aspeed: Add UART routing controller
Hi Rob,
Quoted 84 lines
From: Rob Herring <[email protected]>
Sent: Friday, September 17, 2021 4:19 AMQuoted 7 lines · Chia-Wei Wang
Add dt-bindings for Aspeed UART routing controller.
Signed-off-by Oskar Senft <[email protected]>Signed-off-by Chia-Wei Wang <[email protected]>--- .../devicetree/bindings/mfd/aspeed-lpc.yaml | 4 ++ .../bindings/soc/aspeed/uart-routing.yaml | 70+++++++++++++++++++
Quoted 59 lines
2 files changed, 74 insertions(+) create mode 100644
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yamlDocumentation/devicetree/bindings/mfd/aspeed-lpc.yaml +4
-0@@ -142,6 +142,10 @@ patternProperties: - interrupts - snoop-ports + "^uart-routing@[0-9a-f]+$": + $ref: /schemas/soc/aspeed/uart-routing.yaml# + description: The UART routing control under LPC register space + required: - compatible - regdiff --git
a/Documentation/devicetree/bindings/soc/aspeed/uart-routing.yamlb/Documentation/devicetree/bindings/soc/aspeed/uart-routing.yamlnew file mode 100644
index 000000000000..534b2a9340ceDocumentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +31
-0@@ -0,0 +1,70 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) # # +Copyright (c) 2018 Google LLC # # Copyright (c) 2021 Aspeed +Technology Inc. +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/aspeed/uart-routing.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: Aspeed UART Routing Controller + +maintainers: + - Oskar Senft <[email protected]> + - Chia-Wei Wang <[email protected]> + +description: + The Aspeed UART routing control allow to dynamically route the +inputs for + the built-in UARTS and physical serial I/O ports. + + This allows, for example, to connect the output of UART to another UART. + This can be used to enable Host <-> BMC communication via UARTs, + e.g. to allow access to the Host's serial console. + + This driver is for the BMC side. The sysfs files allow the BMC + userspace which owns the system configuration policy, to configure + how UARTs and physical serial I/O ports are routed. + + Two types of files, uart* and io*, are presented in sysfs. The + uart* configures the input signal of a UART controller whereas io* + configures that of a physical serial port. +Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml line 41
Quoted 10 lines
Documentation/devicetree/bindings/soc/aspeed/uart-routing.yaml new file +10
-0+ When read, each file shows the list of available options with + currently selected option marked by brackets "[]". The list of + available options depends on the selected file. + + e.g. + cat + /sys/bus/platform/drivers/aspeed-uart-routing/*.uart_routing/uart1 + [io1] io2 io3 io4 uart2 uart3 uart4 io6 + + In this case, UART1 gets its input from IO1 (physical serial port 1).This is about documenting the hardware, not an OS driver.
Quoted 2 lines
sysfs files have their own documentation.
Understood. I will remove this sysfs description from bindings in the next revision. Thanks.
Chiawei
PATCH v5 3/4 soc: aspeed: Add UART routing support
In reply to Chia-Wei WangAdd driver support for the UART routing control. Users can perform runtime configuration of the RX muxes among the UART controllers and the UART IO pins.
The sysfs interface is also exported for the convenience of routing paths check and update.
--- .../testing/sysfs-driver-aspeed-uart-routing | 15 + drivers/soc/aspeed/Kconfig | 10 + drivers/soc/aspeed/Makefile | 9 +- drivers/soc/aspeed/aspeed-uart-routing.c | 603 ++++++++++++++++++ 4 files changed, 633 insertions(+), 4 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing create mode 100644 drivers/soc/aspeed/aspeed-uart-routing.c
Documentation/ABI/testing/sysfs-driver-aspeed-uart-routing new file +15 -0
@@ -0,0 +1,15 @@ +What: /sys/bus/platform/drivers/aspeed-uart-routing/*/uart* +Date: September 2021 +Contact: Chia-Wei Wang <[email protected]> +Description: Selects the RX source of the UARTx device. The current + selection will be marked with the '[]' brackets. +Users: OpenBMC. Proposed changes should be mailed to + openbmc at lists.ozlabs.org + +What: /sys/bus/platform/drivers/aspeed-uart-routing/*/io* +Date: September 2021 +Contact: Chia-Wei Wang <[email protected]> +Description: Selects the RX source of IOx pins. The current selection + will be marked with the '[]' brackets. +Users: OpenBMC. Proposed changes should be mailed to + openbmc at lists.ozlabs.org
drivers/soc/aspeed/Kconfig +10 -0
@@ -24,6 +24,16 @@ config ASPEED_LPC_SNOOP allows the BMC to listen on and save the data written by the host to an arbitrary LPC I/O port. +config ASPEED_UART_ROUTING + tristate "ASPEED uart routing control" + select REGMAP + select MFD_SYSCON + default ARCH_ASPEED + help + Provides a driver to control the UART routing paths, allowing + users to perform runtime configuration of the RX muxes among + the UART controllers and I/O pins. + config ASPEED_P2A_CTRL tristate "ASPEED P2A (VGA MMIO to BMC) bridge control" select REGMAP
drivers/soc/aspeed/Makefile +5 -4
@@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o -obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o -obj-$(CONFIG_ASPEED_P2A_CTRL) += aspeed-p2a-ctrl.o -obj-$(CONFIG_ASPEED_SOCINFO) += aspeed-socinfo.o +obj-$(CONFIG_ASPEED_LPC_CTRL) += aspeed-lpc-ctrl.o +obj-$(CONFIG_ASPEED_LPC_SNOOP) += aspeed-lpc-snoop.o +obj-$(CONFIG_ASPEED_UART_ROUTING) += aspeed-uart-routing.o +obj-$(CONFIG_ASPEED_P2A_CTRL) += aspeed-p2a-ctrl.o +obj-$(CONFIG_ASPEED_SOCINFO) += aspeed-socinfo.o
drivers/soc/aspeed/aspeed-uart-routing.c new file +603 -0
603 lines not on this page · raw message
Signature · 1 line
2.17.1
PATCH v5 4/4 ARM: dts: aspeed: Add uart routing to device tree
In reply to Chia-Wei WangAdd LPC uart routing to the device tree for Aspeed SoCs.
--- arch/arm/boot/dts/aspeed-g4.dtsi | 6 ++++++ arch/arm/boot/dts/aspeed-g5.dtsi | 6 ++++++ arch/arm/boot/dts/aspeed-g6.dtsi | 6 ++++++ 3 files changed, 18 insertions(+)
arch/arm/boot/dts/aspeed-g4.dtsi +6 -0
@@ -383,6 +383,12 @@ interrupts = <8>; status = "disabled"; }; + + uart_routing: uart-routing at 9c { + compatible = "aspeed,ast2400-uart-routing"; + reg = <0x9c 0x4>; + status = "disabled"; + }; }; uart2: serial at 1e78d000 {
arch/arm/boot/dts/aspeed-g5.dtsi +6 -0
@@ -491,6 +491,12 @@ #reset-cells = <1>; }; + uart_routing: uart-routing at 9c { + compatible = "aspeed,ast2500-uart-routing"; + reg = <0x9c 0x4>; + status = "disabled"; + }; + lhc: lhc at a0 { compatible = "aspeed,ast2500-lhc"; reg = <0xa0 0x24 0xc8 0x8>;
arch/arm/boot/dts/aspeed-g6.dtsi +6 -0
@@ -551,6 +551,12 @@ #reset-cells = <1>; }; + uart_routing: uart-routing at 98 { + compatible = "aspeed,ast2600-uart-routing"; + reg = <0x98 0x8>; + status = "disabled"; + }; + ibt: ibt at 140 { compatible = "aspeed,ast2600-ibt-bmc"; reg = <0x140 0x18>;
Signature · 1 line
2.17.1