rsi: Fix module dev_oper_mode parameter description
Subsystems (4)
PATCH v2 1/1 rsi: Fix module dev_oper_mode parameter description
The module parameters are missing dev_oper_mode 12, BT classic alone, add it. Moreover, the parameters encode newlines, which ends up being printed malformed e.g. by modinfo, so fix that too.
However, the module parameter string is duplicated in both USB and SDIO modules and the dev_oper_mode mode enumeration in those module parameters is a duplicate of macros used by the driver. Furthermore, the enumeration is confusing.
So, deduplicate the module parameter string and use __stringify() to encode the correct mode enumeration values into the module parameter string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with 'BT classic alone' to clarify what those modes really mean.
--
V2: - Update description of DEV_OPMODE_BT_LE_ALONE DEV_OPMODE_BT_DUAL
DEV_OPMODE_AP_BT DEV_OPMODE_AP_BT_DUAL to include "alone" and "Wi-Fi" consistently.
- Cc netdev and to linux-wireless
--- drivers/net/wireless/rsi/rsi_91x_sdio.c | 5 +---- drivers/net/wireless/rsi/rsi_91x_usb.c | 5 +---- drivers/net/wireless/rsi/rsi_hal.h | 11 +++++++++++ 3 files changed, 13 insertions(+), 8 deletions(-)
drivers/net/wireless/rsi/rsi_91x_sdio.c +1 -4
@@ -24,10 +24,7 @@/* Default operating mode is wlan STA + BT */ static u16 dev_oper_mode =DEV_OPMODE_STA_BT_DUAL ;module_param (dev_oper_mode, ushort,0444 ); -MODULE_PARM_DESC (dev_oper_mode, -"1[Wi-Fi], 4[BT], 8[BT LE], 5[Wi-Fi STA + BT classic]\n" -"9[Wi-Fi STA + BT LE], 13[Wi-Fi STA + BT classic + BT LE]\n" -"6[AP + BT classic], 14[AP + BT classic + BT LE]" ); +MODULE_PARM_DESC (dev_oper_mode,DEV_OPMODE_PARAM_DESC );/** * rsi_sdio_set_cmd52_arg() - This function prepares cmd 52 read/write arg.
drivers/net/wireless/rsi/rsi_91x_usb.c +1 -4
@@ -25,10 +25,7 @@/* Default operating mode is wlan STA + BT */ static u16 dev_oper_mode =DEV_OPMODE_STA_BT_DUAL ;module_param (dev_oper_mode, ushort,0444 ); -MODULE_PARM_DESC (dev_oper_mode, -"1[Wi-Fi], 4[BT], 8[BT LE], 5[Wi-Fi STA + BT classic]\n" -"9[Wi-Fi STA + BT LE], 13[Wi-Fi STA + BT classic + BT LE]\n" -"6[AP + BT classic], 14[AP + BT classic + BT LE]" ); +MODULE_PARM_DESC (dev_oper_mode,DEV_OPMODE_PARAM_DESC );static int rsi_rx_urb_submit (struct rsi_hw *adapter,u8 ep_num,gfp_t flags);
drivers/net/wireless/rsi/rsi_hal.h +11 -0
@@ -28,6 +28,17 @@#define DEV_OPMODE_AP_BT 6#define DEV_OPMODE_AP_BT_DUAL 14 +#define DEV_OPMODE_PARAM_DESC \ + __stringify(DEV_OPMODE_WIFI_ALONE) "[Wi-Fi alone], " \ + __stringify(DEV_OPMODE_BT_ALONE) "[BT classic alone], " \ + __stringify(DEV_OPMODE_BT_LE_ALONE) "[BT LE alone], " \ + __stringify(DEV_OPMODE_BT_DUAL) "[BT classic + BT LE alone], " \ + __stringify(DEV_OPMODE_STA_BT) "[Wi-Fi STA + BT classic], " \ + __stringify(DEV_OPMODE_STA_BT_LE) "[Wi-Fi STA + BT LE], " \ + __stringify(DEV_OPMODE_STA_BT_DUAL) "[Wi-Fi STA + BT classic + BT LE], " \ + __stringify(DEV_OPMODE_AP_BT) "[Wi-Fi AP + BT classic], " \ + __stringify(DEV_OPMODE_AP_BT_DUAL) "[Wi-Fi AP + BT classic + BT LE]" +#define FLASH_WRITE_CHUNK_SIZE (4 * 1024)#define FLASH_SECTOR_SIZE (4 * 1024)
Signature · 1 line
2.33.0
Quoted 14 lines · Marek Vasut
The module parameters are missing
dev_oper_mode12, BT classic alone, add it. Moreover, the parameters encode newlines, which ends up being printed malformed e.g. by modinfo, so fix that too.However, the module parameter string is duplicated in both USB and SDIO modules and the
dev_oper_modemode enumeration in those module parameters is a duplicate of macros used by the driver. Furthermore, the enumeration is confusing.So, deduplicate the module parameter string and use
__stringify()to encode the correct mode enumeration values into the module parameter string. Finally, replace 'Wi-Fi' with 'Wi-Fi alone' and 'BT' with 'BT classic alone' to clarify what those modes really mean.
Quoted 15 lines
Fixes 898b255339310 ("rsi: add module parameter operating mode")Signed-off-by Marek Vasut <[email protected]>Cc Amitkumar Karwar <[email protected]>Cc Angus Ainslie <[email protected]>Cc David S. Miller <[email protected]>Cc Jakub Kicinski <[email protected]>Cc Kalle Valo <[email protected]>Cc Karun Eagalapati <[email protected]>Cc Martin Fuzzey <[email protected]>Cc Martin Kepplinger <[email protected]>Cc Prameela Rani Garnepudi <[email protected]>Cc Sebastian Krzyszkowiak <[email protected]>Cc Siva Rebbagondla <[email protected]>Cc <[email protected]> # 4.17+
Patch applied to wireless-drivers-next.git, thanks.
31f97cf9f0c3 rsi: Fix module dev_oper_mode parameter description
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches