Skip to contentSkip to conversation

mtd: spi-nor: Add support for ZB25VQ128

PATCH In review Daniel Palmer 3 participants 5 messages Sep 18, 2021 – Sep 29, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: spi-nor: Add support for ZB25VQ128

Add support for the ZBIT ZB25VQ128 128MBit SPI NOR flash.

---
 drivers/mtd/spi-nor/Makefile |  1 +
 drivers/mtd/spi-nor/core.c   |  1 +
 drivers/mtd/spi-nor/core.h   |  1 +
 drivers/mtd/spi-nor/zbit.c   | 21 +++++++++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 drivers/mtd/spi-nor/zbit.c
drivers/mtd/spi-nor/Makefile +1 -0
index 6b904e439372..a6f3646824cb 100644
@@ -17,6 +17,7 @@ spi-nor-objs			+= sst.o
 spi-nor-objs			+= winbond.o
 spi-nor-objs			+= xilinx.o
 spi-nor-objs			+= xmc.o
+spi-nor-objs			+= zbit.o
 obj-$(CONFIG_MTD_SPI_NOR)	+= spi-nor.o
 
 obj-$(CONFIG_MTD_SPI_NOR)	+= controllers/
drivers/mtd/spi-nor/core.c +1 -0
index cc08bd707378..75f6ac9485b9 100644
@@ -1846,6 +1846,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = {
 	&spi_nor_winbond,
 	&spi_nor_xilinx,
 	&spi_nor_xmc,
+	&spi_nor_zbit,
 };
 
 static const struct flash_info *
drivers/mtd/spi-nor/core.h +1 -0
index 3348e1dd1445..ad3b34a3b80f 100644
@@ -489,6 +489,7 @@ extern const struct spi_nor_manufacturer spi_nor_sst;
 extern const struct spi_nor_manufacturer spi_nor_winbond;
 extern const struct spi_nor_manufacturer spi_nor_xilinx;
 extern const struct spi_nor_manufacturer spi_nor_xmc;
+extern const struct spi_nor_manufacturer spi_nor_zbit;
 
 extern const struct attribute_group *spi_nor_sysfs_groups[];
 
drivers/mtd/spi-nor/zbit.c new file +21 -0
new file mode 100644
index 000000000000..d240dd65d249
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (C) 2021, Daniel Palmer<[email protected]>
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+static const struct flash_info zbit_parts[] = {
+	/* zbit */
+	{ "zb25vq128", INFO(0x5e4018, 0, 64 * 1024, 256,
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+};
+
+const struct spi_nor_manufacturer spi_nor_zbit = {
+	.name = "zbit",
+	.parts = zbit_parts,
+	.nparts = ARRAY_SIZE(zbit_parts),
+};
Signature · 1 line
2.33.0
#1 lore raw
Quoted 57 lines · Daniel Palmer

Add support for the ZBIT ZB25VQ128 128MBit SPI NOR flash.

---
 drivers/mtd/spi-nor/Makefile |  1 +
 drivers/mtd/spi-nor/core.c   |  1 +
 drivers/mtd/spi-nor/core.h   |  1 +
 drivers/mtd/spi-nor/zbit.c   | 21 +++++++++++++++++++++
 4 files changed, 24 insertions(+)
 create mode 100644 drivers/mtd/spi-nor/zbit.c
drivers/mtd/spi-nor/Makefile +1 -0
index 6b904e439372..a6f3646824cb 100644
@@ -17,6 +17,7 @@ spi-nor-objs			+= sst.o
 spi-nor-objs			+= winbond.o
 spi-nor-objs			+= xilinx.o
 spi-nor-objs			+= xmc.o
+spi-nor-objs			+= zbit.o
 obj-$(CONFIG_MTD_SPI_NOR)	+= spi-nor.o
 
 obj-$(CONFIG_MTD_SPI_NOR)	+= controllers/
drivers/mtd/spi-nor/core.c +1 -0
index cc08bd707378..75f6ac9485b9 100644
@@ -1846,6 +1846,7 @@ static const struct spi_nor_manufacturer *manufacturers[] = {
 	&spi_nor_winbond,
 	&spi_nor_xilinx,
 	&spi_nor_xmc,
+	&spi_nor_zbit,
 };
 
 static const struct flash_info *
drivers/mtd/spi-nor/core.h +1 -0
index 3348e1dd1445..ad3b34a3b80f 100644
@@ -489,6 +489,7 @@ extern const struct spi_nor_manufacturer spi_nor_sst;
 extern const struct spi_nor_manufacturer spi_nor_winbond;
 extern const struct spi_nor_manufacturer spi_nor_xilinx;
 extern const struct spi_nor_manufacturer spi_nor_xmc;
+extern const struct spi_nor_manufacturer spi_nor_zbit;
 
 extern const struct attribute_group *spi_nor_sysfs_groups[];
 
drivers/mtd/spi-nor/zbit.c new file +2 -0
new file mode 100644
index 000000000000..d240dd65d249
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0
+/*

drivers/mtd/spi-nor/zbit.c line 12

Quoted 10 lines
drivers/mtd/spi-nor/zbit.c new file +10 -0
+ * Copyright (C) 2021, Daniel Palmer<[email protected]>
+ */
+
+#include <linux/mtd/spi-nor.h>
+
+#include "core.h"
+
+static const struct flash_info zbit_parts[] = {
+	/* zbit */
+	{ "zb25vq128", INFO(0x5e4018, 0, 64 * 1024, 256,

Zbit should be in bank 10, so it should be preceeded by 9 0x7f bytes, correct? I don't see any logic to handle that in SPI NOR currently so I assume this manufacturer does not implement the continuation codes.

In that case, it should go to the manufacturer collisions driver proposed here [0].

[0] https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

Quoted 12 lines
drivers/mtd/spi-nor/zbit.c new file +9 -0
+			    SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+			    SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
+};
+
+const struct spi_nor_manufacturer spi_nor_zbit = {
+	.name = "zbit",
+	.parts = zbit_parts,
+	.nparts = ARRAY_SIZE(zbit_parts),
+};
Signature · 1 line
2.33.0
Signature · 3 lines
Regards,
Pratyush Yadav
Texas Instruments Inc.
#2 lore raw

Hi Pratyush,

Quoted 9 lines · Pratyush Yadav

Zbit should be in bank 10, so it should be preceeded by 9 0x7f bytes, correct? I don't see any logic to handle that in SPI NOR currently so I assume this manufacturer does not implement the continuation codes.

In that case, it should go to the manufacturer collisions driver proposed here [0].

[0] https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

Sorry, I'm not sure what I should do with this information. I didn't even know about the continuation codes thing until now.
Is there something I need to do here or do I just need to wait for the collision handling code to get merged?

Thanks,

Daniel

#3 lore raw
Quoted 11 lines · Daniel Palmer

Hi Pratyush,

Quoted 8 lines · Pratyush Yadav

Zbit should be in bank 10, so it should be preceeded by 9 0x7f bytes, correct? I don't see any logic to handle that in SPI NOR currently so I assume this manufacturer does not implement the continuation codes.

In that case, it should go to the manufacturer collisions driver proposed here [0].

Quoted 6 lines
Quoted 1 line

[0] https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

Sorry, I'm not sure what I should do with this information. I didn't even know about the continuation codes thing until now.
Is there something I need to do here or do I just need to wait for the collision handling code to get merged?

I think that should be what you need to do. Tudor, any plans on re-rolling that patch series in the near future?

Quoted 4 lines

Thanks,

Daniel

Signature · 7 lines
Regards,
Pratyush Yadav
Texas Instruments Inc.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
#4 lore raw
Quoted 16 lines · Pratyush Yadav

EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe

Quoted 13 lines · Daniel Palmer

Hi Pratyush,

Quoted 9 lines · Pratyush Yadav

Zbit should be in bank 10, so it should be preceeded by 9 0x7f bytes, correct? I don't see any logic to handle that in SPI NOR currently so I assume this manufacturer does not implement the continuation codes.

In that case, it should go to the manufacturer collisions driver proposed here [0].

[0] https://patchwork.ozlabs.org/project/linux-mtd/patch/[email protected]/

Quoted 8 lines
Quoted 4 lines

Sorry, I'm not sure what I should do with this information. I didn't even know about the continuation codes thing until now.
Is there something I need to do here or do I just need to wait for the collision handling code to get merged?

I think that should be what you need to do. Tudor, any plans on re-rolling that patch series in the near future?

Hi, all,

Yes, I was out of office for a month, today I got back. I'll handle it.

Cheers,
ta