Skip to contentSkip to conversation

ASoC: mediatek: mt8195: force COMMON_CLK dependency

PATCH In review Arnd Bergmann 3 participants 4 messages Sep 20, 2021

Subsystems (3)
Sound ASoC Arm MediaTek
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 ASoC: mediatek: mt8195: force COMMON_CLK dependency

From: Arnd Bergmann <[email protected]>

Without CONFIG_COMMON_CLK, this driver fails to link:

ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!

Add the proper Kconfig dependency for compile testing.

Fixes 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Fixes 940ffa194547 ("ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK")
Signed-off-by Arnd Bergmann <[email protected]>
---
 sound/soc/mediatek/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mediatek/Kconfig +1 -1
index 5a2f4667d50b..268c1f74aa3e 100644
@@ -187,7 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
 
 config SND_SOC_MT8195
 	tristate "ASoC support for Mediatek MT8195 chip"
-	depends on ARCH_MEDIATEK || COMPILE_TEST
+	depends on ARCH_MEDIATEK || (COMPILE_TEST && COMMON_CLK)
 	select SND_SOC_MEDIATEK
 	help
 	  This adds ASoC platform driver support for Mediatek MT8195 chip
Signature · 1 line
2.29.2
#1 lore raw

Hi Arnd,

Thanks for your patch!

Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without CONFIG_COMMON_CLK, this driver fails to link:

ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!

Add the proper Kconfig dependency for compile testing.

Fixes 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Fixes 940ffa194547 ("ASoC: mediatek: SND_SOC_MT8195 should depend on ARCH_MEDIATEK")

I don't think the second Fixes tag is appropriate, as that commit did not relax the dependencies.

Quoted 10 lines
Signed-off-by Arnd Bergmann <[email protected]>
---
 sound/soc/mediatek/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/mediatek/Kconfig +0 -0
index 5a2f4667d50b..268c1f74aa3e 100644

sound/soc/mediatek/Kconfig config SND_SOC_MT8192_MT6359_RT1015_RT5682 · line 190

Quoted 5 lines
sound/soc/mediatek/Kconfig +1 -1
@@ -187,7 +187,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
 
 config SND_SOC_MT8195
        tristate "ASoC support for Mediatek MT8195 chip"
-       depends on ARCH_MEDIATEK || COMPILE_TEST
+       depends on ARCH_MEDIATEK || (COMPILE_TEST && COMMON_CLK)

Why not add a second line

depends on COMMON_CLK

to make a clear distinction between hard and soft dependencies?

sound/soc/mediatek/Kconfig config SND_SOC_MT8192_MT6359_RT1015_RT5682 · line 193

Quoted 3 lines
sound/soc/mediatek/Kconfig +0 -0
        select SND_SOC_MEDIATEK
        help
          This adds ASoC platform driver support for Mediatek MT8195 chip

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without CONFIG_COMMON_CLK, this driver fails to link:

ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!

This doesn't apply against current code, please check and resend.

author
#3 lore raw
Quoted 10 lines · Mark Brown
Quoted 6 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without CONFIG_COMMON_CLK, this driver fails to link:

ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!

This doesn't apply against current code, please check and resend.

It's already fixed the way that Geert suggested in your asoc/for-5.15, sorry for the dup.

Arnd