update RDMA controllers queue depth
Subsystems (2)
cover update RDMA controllers queue depth
Hi all,
This series is solving the issue that was introduced by Mark Ruijter while testing SPDK initiators on Vmware-7.x while connecting to Linux RDMA target running on NVIDIA's ConnectX-6 Mellanox Technologies adapter. During connection establishment, the NVMf target controller expose a 1024 queue depth capability but wasn't able to satisfy this depth in reality. The reason for that is that the NVMf driver didn't take the underlying HW capabilities into consideration. For now, limit the RDMA queue depth to a value of 128 (that is the default and works for all the RDMA controllers probably). For that, introduce a new controller operation to return the possible queue size for a given HW. Other transport will continue with thier old behaviour.
In the future, in order to increase this size, we'll need to create a special RDMA API to calculate a possible queue depth for ULPs. As we know, the RDMA IO operations sometimes are built from multiple WRs (such as memory registrations and invalidations) that the ULP driver should take this into consideration during device discovery and queue depth calculations.
Max Gurtovoy (2):
nvmet: add get_queue_size op for controllers
nvmet-rdma: implement get_queue_size controller op
drivers/nvme/target/core.c | 8 +++++--- drivers/nvme/target/nvmet.h | 1 + drivers/nvme/target/rdma.c | 8 ++++++++ 3 files changed, 14 insertions(+), 3 deletions(-)
Signature · 7 lines
2.18.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
PATCH 1/2 nvmet: add get_queue_size op for controllers
Some transports, such as RDMA, would like to set the queue size according to device/port/ctrl characteristics. Add a new nvmet transport op that is called during ctrl initialization. This will not effect transports that don't implement this option.
--- drivers/nvme/target/core.c | 8 +++++--- drivers/nvme/target/nvmet.h | 1 + 2 files changed, 6 insertions(+), 3 deletions(-)
drivers/nvme/target/core.c +5 -3
@@ -1205,7 +1205,10 @@ static void nvmet_init_cap(struct nvmet_ctrl *ctrl)/* CC.EN timeout in 500msec units: */ ctrl->cap |= (15ULL <<24 );/* maximum queue entries supported: */ - ctrl->cap |=NVMET_QUEUE_SIZE -1 ; +if (ctrl->ops->get_queue_size) + ctrl->cap |= ctrl->ops->get_queue_size (ctrl) -1 ; +else + ctrl->cap |=NVMET_QUEUE_SIZE -1 ;if (nvmet_is_passthru_subsys (ctrl->subsys))nvmet_passthrough_override_cap (ctrl);
@@ -1367,6 +1370,7 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn,mutex_init (&ctrl->lock); ctrl->port = req->port; + ctrl->ops = req->ops;INIT_WORK (&ctrl->async_event_work, nvmet_async_event_work);INIT_LIST_HEAD (&ctrl->async_events);
@@ -1405,8 +1409,6 @@ u16 nvmet_alloc_ctrl(const char *subsysnqn, const char *hostnqn, } ctrl->cntlid = ret; - ctrl->ops = req->ops; -/* * Discovery controllers may use some arbitrary high value * in order to cleanup stale discovery sessions
drivers/nvme/target/nvmet.h +1 -0
@@ -309,6 +309,7 @@ struct nvmet_fabrics_ops {u16 (*install_queue)(struct nvmet_sq *nvme_sq);void (*discovery_chg)(struct nvmet_port *port);u8 (*get_mdts)(const struct nvmet_ctrl *ctrl); +u16 (*get_queue_size)(const struct nvmet_ctrl *ctrl); };#define NVMET_MAX_INLINE_BIOVEC 8
Signature · 7 lines
2.18.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 1/2] nvmet: add get_queue_size op for controllers
Quoted 6 lines · Max Gurtovoy
Some transports, such as RDMA, would like to set the queue size according to device/port/ctrl characteristics. Add a new nvmet transport op that is called during ctrl initialization. This will not effect transports that don't implement this option.
Signed-off-by Max Gurtovoy <[email protected]>
I guess there is no way other than making it generic API, looks good.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Sagi Grimberg
maintainerRe: [PATCH 1/2] nvmet: add get_queue_size op for controllers
In reply to Max Gurtovoydrivers/nvme/target/core.c static void nvmet_init_cap(struct nvmet_ctrl *ctrl) · line 1208
Quoted 11 lines
drivers/nvme/target/core.c +1
-1@@ -1205,7 +1205,10 @@ static void nvmet_init_cap(struct nvmet_ctrl *ctrl)/* CC.EN timeout in 500msec units: */ ctrl->cap |= (15ULL <<24 );/* maximum queue entries supported: */ - ctrl->cap |=NVMET_QUEUE_SIZE -1 ; +if (ctrl->ops->get_queue_size)
Maybe call it max_queue_size? it is a maximum supported in essence.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 1/2] nvmet: add get_queue_size op for controllers
Quoted 14 lines · Sagi Grimberg
drivers/nvme/target/core.c static void nvmet_init_cap(struct nvmet_ctrl · line 1209
Quoted 12 lines
drivers/nvme/target/core.c +1
-1@@ -1205,7 +1205,10 @@ static void nvmet_init_cap(struct nvmet_ctrl *ctrl) /* CC.EN timeout in 500msec units: */ ctrl->cap |= (15ULL << 24); /* maximum queue entries supported: */ - ctrl->cap |= NVMET_QUEUE_SIZE - 1; + if (ctrl->ops->get_queue_size)Maybe call it
max_queue_size? it is a maximum supported in essence.
Yes, I can call it get_max_queue_size.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
PATCH 2/2 nvmet-rdma: implement get_queue_size controller op
In reply to Max GurtovoyLimit the maximal queue size for RDMA controllers. Today, the target reports a limit of 1024 and this limit isn't valid for some of the RDMA based controllers. For now, limit RDMA transport to 128 entries (the default queue depth configured for Linux NVMeoF host fabric drivers). Future general solution should use RDMA/core API to calculate this size according to device capabilities and number of WRs needed per NVMe IO request.
--- drivers/nvme/target/rdma.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/nvme/target/rdma.c +8 -0
@@ -36,6 +36,8 @@#define NVMET_RDMA_MAX_MDTS 8#define NVMET_RDMA_MAX_METADATA_MDTS 5 +#define NVMET_RDMA_QUEUE_SIZE 128 +struct nvmet_rdma_srq ;struct nvmet_rdma_cmd {
@@ -1975,6 +1977,11 @@ static u8 nvmet_rdma_get_mdts(const struct nvmet_ctrl *ctrl)return NVMET_RDMA_MAX_MDTS ; } +static u16 nvmet_rdma_get_queue_size (const struct nvmet_ctrl *ctrl) +{ +return NVMET_RDMA_QUEUE_SIZE ; +} +static const struct nvmet_fabrics_ops nvmet_rdma_ops = { .owner =THIS_MODULE , .type =NVMF_TRTYPE_RDMA ,
@@ -1986,6 +1993,7 @@ static const struct nvmet_fabrics_ops nvmet_rdma_ops = { .delete_ctrl = nvmet_rdma_delete_ctrl, .disc_traddr = nvmet_rdma_disc_port_addr, .get_mdts = nvmet_rdma_get_mdts, + .get_queue_size = nvmet_rdma_get_queue_size, };static void nvmet_rdma_remove_one (struct ib_device *ib_device,void *client_data)
Signature · 7 lines
2.18.1 _______________________________________________ Linux-nvme mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 10 lines · Max Gurtovoy
Limit the maximal queue size for RDMA controllers. Today, the target reports a limit of 1024 and this limit isn't valid for some of the RDMA based controllers. For now, limit RDMA transport to 128 entries (the default queue depth configured for Linux NVMeoF host fabric drivers). Future general solution should use RDMA/core API to calculate this size according to device capabilities and number of WRs needed per NVMe IO request.
Reported-by Mark Ruijter <[email protected]>Signed-off-by Max Gurtovoy <[email protected]>
Looks good.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Sagi Grimberg
maintainerRe: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
In reply to Max GurtovoyQuoted 8 lines
Limit the maximal queue size for RDMA controllers. Today, the target reports a limit of 1024 and this limit isn't valid for some of the RDMA based controllers. For now, limit RDMA transport to 128 entries (the default queue depth configured for Linux NVMeoF host fabric drivers). Future general solution should use RDMA/core API to calculate this size according to device capabilities and number of WRs needed per NVMe IO request.
What is preventing you from doing that today? You have the device, can't you check attr.max_qp_wr?
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 11 lines · Sagi Grimberg
Quoted 8 lines
Limit the maximal queue size for RDMA controllers. Today, the target reports a limit of 1024 and this limit isn't valid for some of the RDMA based controllers. For now, limit RDMA transport to 128 entries (the default queue depth configured for Linux NVMeoF host fabric drivers). Future general solution should use RDMA/core API to calculate this size according to device capabilities and number of WRs needed per NVMe IO request.
What is preventing you from doing that today? You have the device, can't you check attr.max_qp_wr?
max_qp_wr is giving me the maximal amount of wqe's one can issue (the minimal unit). In reality we have WRs that constructed from multiple WQEs.
Initially, I wanted to divide max_qp_wr by the maximal WR operation size in the low level driver. But that would cause ULPs that don't use this maximal WR to suffer.
So for now, as mentioned, till we have some ib_ API, lets set it to 128.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Christoph Hellwig
maintainerRe: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 1 line · Max Gurtovoy
So for now, as mentioned, till we have some
ib_API, lets set it to 128.
Please just add the proper ib_ API, it should not be a whole lot of work as we already do that calculation anyway for the R/W API setup.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 4 lines · Christoph Hellwig
Quoted 1 line · Max Gurtovoy
So for now, as mentioned, till we have some
ib_API, lets set it to 128.Please just add the proper
ib_API, it should not be a whole lot of work as we already do that calculation anyway for the R/W API setup.
We don't do this exact calculation since only the low level driver knows that number of WQEs we need for some sophisticated WR.
The API we need is like ib_get_qp_limits when one provides some input on the operations it will issue and will receive an output for it.
Then we need to divide it by some factor that will reflect the amount of max WRs per NVMe request (e.g mem_reg + mem_invalidation + rdma_op + pi_yes_no).
I spoke with Jason on that and we decided that it's not a trivial patch.
is it necessary for this submission or can we live with 128 depth for now ? with and without new ib_ API the queue depth will be in these sizes.
Quoted 1 line
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Sagi Grimberg
maintainerRe: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 5 lines
Quoted 4 lines
Quoted 2 lines
So for now, as mentioned, till we have some
ib_API, lets set it to 128.Please just add the proper
ib_API, it should not be a whole lot of work as we already do that calculation anyway for the R/W API setup.
Quoted 7 lines
We don't do this exact calculation since only the low level driver knows that number of WQEs we need for some sophisticated WR.
The API we need is like
ib_get_qp_limitswhen one provides some input on the operations it will issue and will receive an output for it.Then we need to divide it by some factor that will reflect the amount of max WRs per NVMe request (e.g
mem_reg+mem_invalidation+rdma_op+pi_yes_no).I spoke with Jason on that and we decided that it's not a trivial patch.
Can't you do this in rdmw_rw? all of the users of it will need the exact same value right?
Quoted 1 line
is it necessary for this submission or can we live with 128 depth for now ? with and without new
ib_API the queue depth will be in these sizes.
I am not sure I see the entire complexity. Even if this calc is not accurate, you are already proposing to hard-code it to 128, so you can do this to account for the boundaries there.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 9 lines · Sagi Grimberg
Quoted 9 lines
Quoted 4 lines
Quoted 2 lines
So for now, as mentioned, till we have some
ib_API, lets set it to 128.Please just add the proper
ib_API, it should not be a whole lot of work as we already do that calculation anyway for the R/W API setup.We don't do this exact calculation since only the low level driver knows that number of WQEs we need for some sophisticated WR.
The API we need is like
ib_get_qp_limitswhen one provides some input on the operations it will issue and will receive an output for it.
Quoted 7 lines
Quoted 4 lines
Then we need to divide it by some factor that will reflect the amount of max WRs per NVMe request (e.g
mem_reg+mem_invalidation+rdma_op
+pi_yes_no).I spoke with Jason on that and we decided that it's not a trivial patch.
Can't you do this in
rdmw_rw? all of the users of it will need the exact same value right?
The factor of the operations per IO req is to be added to RW API.
The factor of WR to WQE is in low level driver and is ib_ API.
Quoted 6 lines
Quoted 2 lines
is it necessary for this submission or can we live with 128 depth for now ? with and without new
ib_API the queue depth will be in these sizes.I am not sure I see the entire complexity. Even if this calc is not accurate, you are already proposing to hard-code it to 128, so you can do this to account for the boundaries there.
How does the ULP know the BBs per max WR operation ?
I prepared a patch to solve the case we say we support X but we actually support less than X.
128 Value is supported by mlx device and I assume by other RDMA devices as well since its the default value for the initiator.
The full solution include changes in RDMA_RW, ib_, low level drivers to implement ib_ API.
I wanted to divide it to early solution (this series) and full solution (the above).
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
In reply to Sagi GrimbergQuoted 2 lines · Sagi Grimberg
Can't you do this in
rdmw_rw? all of the users of it will need the exact same value right?
No, it depends on what ops the user is going to use.
Quoted 7 lines
Quoted 3 lines
is it necessary for this submission or can we live with 128 depth for now ? with and without new
ib_API the queue depth will be in these sizes.I am not sure I see the entire complexity. Even if this calc is not accurate, you are already proposing to hard-code it to 128, so you can do this to account for the boundaries there.
As I understood it the 128 is to match what the initiator hardcodes its limit to - both sides have the same basic problem with allocating the RDMA QP, they just had different hard coded limits. Due to this we know that 128 is OK for all RDMA HW as the initiator has proven it already.
For a stable fix to the interop problem this is a good approach.
If someone wants to add all sorts of complexity to try and figure out the actual device specific limit then they should probably also show that there is a performance win (or at least not a loss) to increasing this number further..
Jason
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 9 lines · Jason Gunthorpe
Quoted 2 lines · Sagi Grimberg
Can't you do this in
rdmw_rw? all of the users of it will need the exact same value right?No, it depends on what ops the user is going to use.
Quoted 3 lines
Quoted 3 lines
is it necessary for this submission or can we live with 128 depth for now ? with and without new
ib_API the queue depth will be in these sizes.
Quoted 8 lines
Quoted 3 lines
I am not sure I see the entire complexity. Even if this calc is not accurate, you are already proposing to hard-code it to 128, so you can do this to account for the boundaries there.
As I understood it the 128 is to match what the initiator hardcodes its limit to - both sides have the same basic problem with allocating the RDMA QP, they just had different hard coded limits. Due to this we know that 128 is OK for all RDMA HW as the initiator has proven it already.
Not exactly. The initiator 128 is the default value if not set differently in the connect command.
Probably this value can be bigger in initiator since it doesn't perform RDMA operation but only sends descriptors to the target.
So we'll need the ib_ future API for initiator as well, but not the RW API since the factor for NVMe IO will be 3 (MEM_REG, MEM_INVALID, SEND).
Quoted 7 lines
For a stable fix to the interop problem this is a good approach.
If someone wants to add all sorts of complexity to try and figure out the actual device specific limit then they should probably also show that there is a performance win (or at least not a loss) to increasing this number further..
Correct.
Quoted 1 line
Jason
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 19 lines · Max Gurtovoy
Quoted 8 lines · Jason Gunthorpe
Quoted 2 lines · Sagi Grimberg
Can't you do this in
rdmw_rw? all of the users of it will need the exact same value right?No, it depends on what ops the user is going to use.
Quoted 3 lines
Quoted 3 lines
is it necessary for this submission or can we live with 128 depth for now ? with and without new
ib_API the queue depth will be in these sizes.Quoted 8 lines
Quoted 3 lines
I am not sure I see the entire complexity. Even if this calc is not accurate, you are already proposing to hard-code it to 128, so you can do this to account for the boundaries there.
As I understood it the 128 is to match what the initiator hardcodes its limit to - both sides have the same basic problem with allocating the RDMA QP, they just had different hard coded limits. Due to this we know that 128 is OK for all RDMA HW as the initiator has proven it already.
Quoted 5 lines
Not exactly. The initiator 128 is the default value if not set differently in the connect command.
Probably this value can be bigger in initiator since it doesn't perform RDMA operation but only sends descriptors to the target.
Well, that means the initiator side needs fixing too. I see this:
if (token < NVMF_MIN_QUEUE_SIZE ||
token > NVMF_MAX_QUEUE_SIZE)
ERR
opts->queue_size = token;Which is probably still too big for what some HW can do.
Both host and target need to bring in an upper limit of queue_size from the RDMA layer. A ULP should not pass in a value to ib_qp_init_attr::max_send_wr that will cause QP creation to fail if the queue_size is programmable.
Currently there is no way to to get the device limit for QPs using IB_QP_CREATE_INTEGRITY_EN. We know at least that 128 works on all RDMA devices.
In any case I still view it as two tasks, fix the various interop problems by adjusting the current hardwired limits to something that works on all RDMA HW and computing the actual HW limit, adjusted by RW, etc.
Jason
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Re: [PATCH 2/2] nvmet-rdma: implement get_queue_size controller op
Quoted 23 lines · Jason Gunthorpe
Quoted 17 lines · Max Gurtovoy
Quoted 8 lines · Jason Gunthorpe
Quoted 2 lines · Sagi Grimberg
Can't you do this in
rdmw_rw? all of the users of it will need the exact same value right?No, it depends on what ops the user is going to use.
Quoted 3 lines
Quoted 3 lines
is it necessary for this submission or can we live with 128 depth for now ? with and without new
ib_API the queue depth will be in these sizes.Quoted 8 lines
Quoted 3 lines
I am not sure I see the entire complexity. Even if this calc is not accurate, you are already proposing to hard-code it to 128, so you can do this to account for the boundaries there.
As I understood it the 128 is to match what the initiator hardcodes its limit to - both sides have the same basic problem with allocating the RDMA QP, they just had different hard coded limits. Due to this we know that 128 is OK for all RDMA HW as the initiator has proven it already.
Quoted 5 lines
Not exactly. The initiator 128 is the default value if not set differently in the connect command.
Probably this value can be bigger in initiator since it doesn't perform RDMA operation but only sends descriptors to the target.
Quoted 8 lines
Well, that means the initiator side needs fixing too. I see this:
if (token < NVMF_MIN_QUEUE_SIZE || token > NVMF_MAX_QUEUE_SIZE) ERR opts->queue_size = token;Which is probably still too big for what some HW can do.
Yes. I'll fix it in V2.
Quoted 10 lines
Both host and target need to bring in an upper limit of
queue_sizefrom the RDMA layer. A ULP should not pass in a value toib_qp_init_attr::max_send_wrthat will cause QP creation to fail if thequeue_sizeis programmable.Currently there is no way to to get the device limit for QPs using
IB_QP_CREATE_INTEGRITY_EN. We know at least that 128 works on all RDMA devices.
Quoted 6 lines
In any case I still view it as two tasks, fix the various interop problems by adjusting the current hardwired limits to something that works on all RDMA HW and computing the actual HW limit, adjusted by RW, etc.
Jason
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Mark,
Quoted 20 lines · Max Gurtovoy
Hi all,
This series is solving the issue that was introduced by Mark Ruijter while testing SPDK initiators on Vmware-7.x while connecting to Linux RDMA target running on NVIDIA's ConnectX-6 Mellanox Technologies adapter. During connection establishment, the NVMf target controller expose a 1024 queue depth capability but wasn't able to satisfy this depth in reality. The reason for that is that the NVMf driver didn't take the underlying HW capabilities into consideration. For now, limit the RDMA queue depth to a value of 128 (that is the default and works for all the RDMA controllers probably). For that, introduce a new controller operation to return the possible queue size for a given HW. Other transport will continue with thier old behaviour.In the future, in order to increase this size, we'll need to create a special RDMA API to calculate a possible queue depth for ULPs. As we know, the RDMA IO operations sometimes are built from multiple WRs (such as memory registrations and invalidations) that the ULP driver should take this into consideration during device discovery and queue depth calculations.
Quoted 9 lines
Max Gurtovoy (2):
nvmet: addget_queue_sizeop for controllers
nvmet-rdma: implementget_queue_sizecontroller opdrivers/nvme/target/core.c | 8 +++++--- drivers/nvme/target/nvmet.h | 1 + drivers/nvme/target/rdma.c | 8 ++++++++ 3 files changed, 14 insertions(+), 3 deletions(-)
It will be great if you can provide tested by tag.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme
Hi Chaitanya,
I’ll try to run some tests asap and let you know.
—Mark
Quoted 29 lines
Op 21 sep. 2021 om 21:22 heeft Chaitanya Kulkarni <[email protected]> het volgende geschreven:
Mark,
Quoted 25 lines · Max Gurtovoy
Hi all,
This series is solving the issue that was introduced by Mark Ruijter while testing SPDK initiators on Vmware-7.x while connecting to Linux RDMA target running on NVIDIA's ConnectX-6 Mellanox Technologies adapter. During connection establishment, the NVMf target controller expose a 1024 queue depth capability but wasn't able to satisfy this depth in reality. The reason for that is that the NVMf driver didn't take the underlying HW capabilities into consideration. For now, limit the RDMA queue depth to a value of 128 (that is the default and works for all the RDMA controllers probably). For that, introduce a new controller operation to return the possible queue size for a given HW. Other transport will continue with thier old behaviour.In the future, in order to increase this size, we'll need to create a special RDMA API to calculate a possible queue depth for ULPs. As we know, the RDMA IO operations sometimes are built from multiple WRs (such as memory registrations and invalidations) that the ULP driver should take this into consideration during device discovery and queue depth calculations.
Max Gurtovoy (2):
nvmet: addget_queue_sizeop for controllers
nvmet-rdma: implementget_queue_sizecontroller op
Quoted 8 lines
Quoted 5 lines
drivers/nvme/target/core.c | 8 +++++--- drivers/nvme/target/nvmet.h | 1 + drivers/nvme/target/rdma.c | 8 ++++++++ 3 files changed, 14 insertions(+), 3 deletions(-)It will be great if you can provide tested by tag.
_______________________________________________
Linux-nvme mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-nvme