Skip to contentSkip to conversation

media: vivid: fix an error code in vivid_create_instance()

PATCH New Dan Carpenter 1 participant 1 message Sep 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 media: vivid: fix an error code in vivid_create_instance()

Preserve the error code stored in "dev->kthread_cec" before setting it to NULL.

Fixes 439e520995ab ("media: vivid: add signal-free time for cec message xfer")
---
 drivers/media/test-drivers/vivid/vivid-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/test-drivers/vivid/vivid-core.c +1 -1
index bcf03bea1e3c..04b75666bad4 100644
@@ -1934,9 +1934,9 @@ static int vivid_create_instance(struct platform_device *pdev, int inst)
 		dev->kthread_cec = kthread_run(vivid_cec_bus_thread, dev,
 					       "vivid_cec-%s", dev->v4l2_dev.name);
 		if (IS_ERR(dev->kthread_cec)) {
+			ret = PTR_ERR(dev->kthread_cec);
 			dev->kthread_cec = NULL;
 			v4l2_err(&dev->v4l2_dev, "kernel_thread() failed\n");
-			ret = PTR_ERR(dev->kthread_cec);
 			goto unreg_dev;
 		}
 	}
Signature · 1 line
2.20.1