mm: do not acquire zone lock in is_free_buddy_page()
Subsystems (2)
PATCH 1/1 mm: do not acquire zone lock in is_free_buddy_page()
From: Eric Dumazet <[email protected]>
Grabbing zone lock in is_free_buddy_page() gives a wrong sense of safety, and has potential performance implications when zone is experiencing lock contention.
In any case, if a caller needs a stable result, it should grab zone lock before calling this function.
Signed-off-by Eric Dumazet <[email protected]>
Cc Hugh Dickins <[email protected]>
--- mm/page_alloc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
mm/page_alloc.c +5 -5
@@ -9354,21 +9354,21 @@ void __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) }#endif +/* +* This function returns a stable result only if called under zone lock. +*/ bool is_free_buddy_page (struct page *page) { -struct zone *zone =page_zone (page);unsigned long pfn =page_to_pfn (page); -unsigned long flags;unsigned int order; -spin_lock_irqsave (&zone->lock, flags);for (order =0 ; order <MAX_ORDER ; order++) {struct page *page_head = page - (pfn & ((1 << order) -1 )); -if (PageBuddy (page_head) &&buddy_order (page_head) >= order) +if (PageBuddy (page_head) && +buddy_order_unsafe (page_head) >= order)break ; } -spin_unlock_irqrestore (&zone->lock, flags);return order <MAX_ORDER ; }
Signature · 1 line
2.33.0.464.g1972c5931b-goog
Quoted 11 lines · Eric Dumazet
From: Eric Dumazet <[email protected]>
Grabbing zone lock in
is_free_buddy_page()gives a wrong sense of safety, and has potential performance implications when zone is experiencing lock contention.In any case, if a caller needs a stable result, it should grab zone lock before calling this function.
Signed-off-by Eric Dumazet <[email protected]>Cc Hugh Dickins <[email protected]>
Yes indeed, and you have already explained it well above: thanks.
Acked-by Hugh Dickins <[email protected]>
Quoted 37 lines
--- mm/page_alloc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)mm/page_alloc.c +5
-5@@ -9354,21 +9354,21 @@ void __offline_isolated_pages(unsigned long start_pfn, unsigned long end_pfn) }#endif +/* +* This function returns a stable result only if called under zone lock. +*/ bool is_free_buddy_page (struct page *page) { -struct zone *zone =page_zone (page);unsigned long pfn =page_to_pfn (page); -unsigned long flags;unsigned int order; -spin_lock_irqsave (&zone->lock, flags);for (order =0 ; order <MAX_ORDER ; order++) {struct page *page_head = page - (pfn & ((1 << order) -1 )); -if (PageBuddy (page_head) &&buddy_order (page_head) >= order) +if (PageBuddy (page_head) && +buddy_order_unsafe (page_head) >= order)break ; } -spin_unlock_irqrestore (&zone->lock, flags);return order <MAX_ORDER ; }Signature · 1 line
2.33.0.464.g1972c5931b-goog