gpio: 74x164: Add SPI device ID table
PATCH v2 1/1 gpio: 74x164: Add SPI device ID table
Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding a SPI device ID table.
Fixes 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by Mark Brown <[email protected]>
Reviewed-by Linus Walleij <[email protected]>
---
v2: Fix typos in the device names, sorry.
drivers/gpio/gpio-74x164.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpio/gpio-74x164.c +8 -0
@@ -174,6 +174,13 @@ static int gen_74x164_remove(struct spi_device *spi)return 0 ; } +static const struct spi_device_id gen_74x164_spi_ids[] = { + { .name ="74hc595" }, + { .name ="74lvc594" }, + {}, +}; +MODULE_DEVICE_TABLE (spi, gen_74x164_spi_ids); +static const struct of_device_id gen_74x164_dt_ids[] = { { .compatible ="fairchild,74hc595" }, { .compatible ="nxp,74lvc594" },
@@ -188,6 +195,7 @@ static struct spi_driver gen_74x164_driver = { }, .probe = gen_74x164_probe, .remove = gen_74x164_remove, + .id_table = gen_74x164_spi_ids, };module_spi_driver (gen_74x164_driver);
Signature · 1 line
2.20.1
Bartosz Golaszewski
AppliedQuoted 43 lines · Mark Brown
Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding a SPI device ID table.
Fixes 96c8395e2166 ("spi: Revert modalias changes")Signed-off-by Mark Brown <[email protected]>Reviewed-by Linus Walleij <[email protected]>---
v2: Fix typos in the device names, sorry.
drivers/gpio/gpio-74x164.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/gpio/gpio-74x164.c +8
-1@@ -174,6 +174,13 @@ static int gen_74x164_remove(struct spi_device *spi)return 0 ; } +static const struct spi_device_id gen_74x164_spi_ids[] = { + { .name ="74hc595" }, + { .name ="74lvc594" }, + {}, +}; +MODULE_DEVICE_TABLE (spi, gen_74x164_spi_ids); +static const struct of_device_id gen_74x164_dt_ids[] = { { .compatible ="fairchild,74hc595" }, { .compatible ="nxp,74lvc594" },@@ -188,6 +195,7 @@ static struct spi_driver gen_74x164_driver = { }, .probe = gen_74x164_probe, .remove = gen_74x164_remove, + .id_table = gen_74x164_spi_ids, };module_spi_driver (gen_74x164_driver); --
Quoted 2 lines
2.20.1
Applied, thanks!
Bartosz