spi: spidev: Add SPI ID table
Mark Brown
maintainerPATCH 1/1 spi: spidev: Add SPI ID table
Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding an id_table listing the SPI IDs for everything.
--- drivers/spi/spidev.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/spi/spidev.c +14 -0
@@ -673,6 +673,19 @@ static const struct file_operations spidev_fops = {static struct class *spidev_class; +static const struct spi_device_id spidev_spi_ids[] = { + { .name ="dh2228fv" }, + { .name ="ltc2488" }, + { .name ="sx1301" }, + { .name ="bk4" }, + { .name ="dhcom-board" }, + { .name ="m53cpld" }, + { .name ="spi-petra" }, + { .name ="spi-authenta" }, + {}, +}; +MODULE_DEVICE_TABLE (of, spidev_dt_ids); +#ifdef CONFIG_OF static const struct of_device_id spidev_dt_ids[] = { { .compatible = "rohm,dh2228fv" },
@@ -818,6 +831,7 @@ static struct spi_driver spidev_spi_driver = { }, .probe = spidev_probe, .remove = spidev_remove, + .id_table = spidev_spi_ids,/* NOTE: suspend/resume methods are not necessary here. * We don't do anything except pass the requests to/from
Signature · 1 line
2.20.1
Mark Brown
maintainerQuoted 8 lines · Mark Brown
Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding an
id_tablelisting the SPI IDs for everything.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Thanks!
[1/1] spi: spidev: Add SPI ID table
commit: 6840615f85f6046039ebc4989870ddb12892b7fc
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark