scsi: ufs: Fix illegal address reading in upiu event trace

PATCH Superseded Jonathan Hsu 1 participant 1 message Sep 24, 2021

Subsystems (2)

Stable branch SCSI

lore

Share & tools

lore

Jonathan Hsu

author

2021-09-24 08:44 UTC #0 lore raw

PATCH v3 1/1 scsi: ufs: Fix illegal address reading in upiu event trace

Fix incorrect index for UTMRD reference in ufshcd_add_tm_upiu_trace().

Fixes 4b42d557a8ad ("scsi: ufs: core: Fix wrong Task Tag used in task management request UPIUs")

Signed-off-by Jonathan Hsu <[email protected]>

Cc [email protected]

---
 drivers/scsi/ufs/ufshcd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

drivers/scsi/ufs/ufshcd.c +1 -2

index 3841ab49f556..36aa27cdc2ab 100644
@@ -319,8 +319,7 @@ static void ufshcd_add_query_upiu_trace(struct ufs_hba *hba,
 static void ufshcd_add_tm_upiu_trace(struct ufs_hba *hba, unsigned int tag,
 				     enum ufs_trace_str_t str_t)
 {
-	int off = (int)tag - hba->nutrs;
-	struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[off];
+	struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[tag];
 
 	if (!trace_ufshcd_upiu_enabled())
 		return;

Signature · 1 line

2.18.0