Skip to contentSkip to conversation

gpu: host1x: select CONFIG_DMA_SHARED_BUFFER

PATCH Applied Arnd Bergmann 3 participants 3 messages Sep 27, 2021 – Oct 7, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpu: host1x: select CONFIG_DMA_SHARED_BUFFER

From: Arnd Bergmann <[email protected]>

Linking fails when dma-buf is disabled:

ld.lld: error: undefined symbol: dma_fence_release

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

referenced by fence.c
gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
referenced by fence.c
gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
referenced by fence.c
gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a

Fixes 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
---
 drivers/gpu/host1x/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/host1x/Kconfig +1 -0
index 6dab94adf25e..6815b4db17c1 100644
@@ -2,6 +2,7 @@
 config TEGRA_HOST1X
 	tristate "NVIDIA Tegra host1x driver"
 	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+	select DMA_SHARED_BUFFER
 	select IOMMU_IOVA
 	help
 	  Driver for the NVIDIA Tegra host1x hardware.
Signature · 1 line
2.29.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 24 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Linking fails when dma-buf is disabled:

ld.lld: error: undefined symbol: dma_fence_release

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

referenced by fence.c
gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
referenced by fence.c
gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
referenced by fence.c
gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a

Fixes 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
---
  drivers/gpu/host1x/Kconfig | 1 +
  1 file changed, 1 insertion(+)
drivers/gpu/host1x/Kconfig +0 -0
index 6dab94adf25e..6815b4db17c1 100644

drivers/gpu/host1x/Kconfig line 8

Quoted 7 lines
drivers/gpu/host1x/Kconfig +1 -0
@@ -2,6 +2,7 @@
  config TEGRA_HOST1X
  	tristate "NVIDIA Tegra host1x driver"
  	depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+	select DMA_SHARED_BUFFER
  	select IOMMU_IOVA
  	help
  	  Driver for the NVIDIA Tegra host1x hardware.

Thanks!

#2 lore raw
In reply to Arnd Bergmann
Quoted 12 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Linking fails when dma-buf is disabled:

ld.lld: error: undefined symbol: dma_fence_release

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

referenced by fence.c
gpu/host1x/fence.o:(host1x_syncpt_fence_enable_signaling) in archive drivers/built-in.a
referenced by fence.c
gpu/host1x/fence.o:(host1x_fence_signal) in archive drivers/built-in.a
referenced by fence.c
gpu/host1x/fence.o:(do_fence_timeout) in archive drivers/built-in.a

Quoted 5 lines
Fixes 687db2207b1b ("gpu: host1x: Add DMA fence implementation")
---
 drivers/gpu/host1x/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Thierry