Skip to contentSkip to conversation

rtc: mcp795: Add SPI ID table

PATCH Applied Mark Brown 2 participants 2 messages Sep 27, 2021 – Oct 1, 2021 Real time clock (RTC)

lore
Share & tools
lore

Mark Brown

author
#0 lore raw

PATCH 1/1 rtc: mcp795: Add SPI ID table

Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding an id_table listing the SPI IDs for everything.

Fixes 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by Mark Brown <[email protected]>
---
 drivers/rtc/rtc-mcp795.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/rtc/rtc-mcp795.c +7 -0
index bad7792b6ca5..0d515b3df571 100644
@@ -430,12 +430,19 @@ static const struct of_device_id mcp795_of_match[] = {
 MODULE_DEVICE_TABLE(of, mcp795_of_match);
 #endif
 
+static const struct spi_device_id mcp795_spi_ids[] = {
+	{ .name = "mcp795" },
+	{ }
+};
+MODULE_DEVICE_TABLE(spi, mcp795_spi_ids);
+
 static struct spi_driver mcp795_driver = {
 		.driver = {
 				.name = "rtc-mcp795",
 				.of_match_table = of_match_ptr(mcp795_of_match),
 		},
 		.probe = mcp795_probe,
+		.id_table = mcp795_spi_ids,
 };
 
 module_spi_driver(mcp795_driver);
Signature · 1 line
2.20.1
maintainer Applied
#1 lore raw
Quoted 8 lines · Mark Brown

Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding an id_table listing the SPI IDs for everything.

[...]

Applied, thanks!

[1/1] rtc: mcp795: Add SPI ID table

      commit: 3109151c47343c80300177ec7704e0757064efdc

Best regards,

Signature · 1 line
Alexandre Belloni <[email protected]>