thunderbolt: fix -Wrestrict warning
Subsystems (2)
PATCH 1/1 thunderbolt: fix -Wrestrict warning
From: Arnd Bergmann <[email protected]>
gcc-11 warns when building with W=1:
drivers/thunderbolt/xdomain.c: In function 'modalias_show':drivers/thunderbolt/xdomain.c:733:16: error: 'sprintf' argument 3 overlaps destination object 'buf' [-Werror=restrict]
733 | return sprintf(buf, "%s\n", buf);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/thunderbolt/xdomain.c:727:36: note: destination object referenced by 'restrict'-qualified argument 1 was declared here
727 | char *buf)
| ~~~~~~^~~There is no need for the sprintf() here when a strcat() does the same thing.
Signed-off-by Arnd Bergmann <[email protected]>
--- drivers/thunderbolt/xdomain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/thunderbolt/xdomain.c +1 -1
@@ -730,7 +730,7 @@ static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,/* Full buffer size except new line and null termination */ get_modalias (svc, buf,PAGE_SIZE -2 ); -return sprintf (buf,"%s\n" , buf); +return strlen (strcat (buf,"\n" )); }static DEVICE_ATTR_RO (modalias);
Signature · 1 line
2.29.2
Mika Westerberg
AppliedQuoted 12 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
gcc-11 warns when building with W=1:
drivers/thunderbolt/xdomain.c: In function 'modalias_show':drivers/thunderbolt/xdomain.c:733:16: error: 'sprintf' argument 3 overlaps destination object 'buf' [-Werror=restrict]733 | return sprintf(buf, "%s\n", buf); | ^~~~~~~~~~~~~~~~~~~~~~~~~ drivers/thunderbolt/xdomain.c:727:36: note: destination object referenced by 'restrict'-qualified argument 1 was declared here 727 | char *buf) | ~~~~~~^~~
Quoted 4 lines
There is no need for the
sprintf()here when astrcat()does the same thing.Signed-off-by Arnd Bergmann <[email protected]>
Applied, thanks!