RDMA/hfi1: Use struct_size() and flex_array_size() helpers
Subsystems (2)
PATCH 1/1 RDMA/hfi1: Use struct_size() and flex_array_size() helpers
Make use of the struct_size() and flex_array_size() helpers instead of open-coded versions, in order to avoid any potential type mistakes or integer overflows that, in the worse scenario, could lead to heap overflows.
--- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/infiniband/hw/hfi1/user_exp_rcv.c +2 -3
@@ -692,8 +692,7 @@ static int set_rcvarray_entry(struct hfi1_filedata *fd,* Allocate the node first so we can handle a potential * failure before we've programmed anything. */ - node =kzalloc (sizeof (*node) + (sizeof (struct page *) * npages), -GFP_KERNEL ); + node =kzalloc (struct_size (node, pages, npages),GFP_KERNEL );if (!node)return -ENOMEM ;
@@ -713,7 +712,7 @@ static int set_rcvarray_entry(struct hfi1_filedata *fd, node->dma_addr = phys; node->grp = grp; node->freed = false; -memcpy (node->pages, pages,sizeof (struct page *) * npages); +memcpy (node->pages, pages,flex_array_size (node, pages, npages));if (fd->use_mn) { ret = mmu_interval_notifier_insert(
Signature · 1 line
2.27.0
Quoted 10 lines · Gustavo A. R. Silva
Make use of the
struct_size()andflex_array_size()helpers instead of open-coded versions, in order to avoid any potential type mistakes or integer overflows that, in the worse scenario, could lead to heap overflows.--- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Applied to for-next, thanks
Jason
Quoted 2 lines · Jason Gunthorpe
Applied to for-next, thanks
Thanks, Jason.
--
Gustavo