hwmon: (occ) Fix P10 VRM temp sensors
PATCH 1/1 hwmon: (occ) Fix P10 VRM temp sensors
The P10 (temp sensor version 0x10) doesn't do the same VRM status reporting that was used on P9. It just reports the temperature, so drop the check for VRM fru type in the sysfs show function, and don't set the name to "alarm".
Fixes db4919ec86 ("hwmon: (occ) Add new temperature sensor type")
Signed-off-by Eddie James <[email protected]>
--- drivers/hwmon/occ/common.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)
drivers/hwmon/occ/common.c +5 -12
@@ -340,18 +340,11 @@ static ssize_t occ_show_temp_10(struct device *dev,if (val ==OCC_TEMP_SENSOR_FAULT )return -EREMOTEIO ; -/* -* VRM doesn't return temperature, only alarm bit. This -* attribute maps to tempX_alarm instead of tempX_input for -* VRM -*/ -if (temp->fru_type !=OCC_FRU_TYPE_VRM ) { -/* sensor not ready */ -if (val ==0 ) -return -EAGAIN ; +/* sensor not ready */ +if (val ==0 ) +return -EAGAIN ; - val *=1000 ; - } + val *=1000 ;break ;case 2 : val = temp->fru_type;
@@ -886,7 +879,7 @@ static int occ_setup_sensor_attrs(struct occ *occ) 0, i); attr++; -if (sensors->temp.version >1 && +if (sensors->temp.version ==2 && temp->fru_type ==OCC_FRU_TYPE_VRM ) {snprintf (attr->name,sizeof (attr->name),"temp%d_alarm" , s);
Signature · 1 line
2.27.0
Quoted 7 lines · Eddie James
The P10 (temp sensor version
0x10) doesn't do the same VRM status reporting that was used on P9. It just reports the temperature, so drop the check for VRM fru type in the sysfs show function, and don't set the name to "alarm".Fixes db4919ec86 ("hwmon: (occ) Add new temperature sensor type")Signed-off-by Eddie James <[email protected]>
Applied.
Thanks,
Guenter
Quoted 40 lines
--- drivers/hwmon/occ/common.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-)drivers/hwmon/occ/common.c +5
-12@@ -340,18 +340,11 @@ static ssize_t occ_show_temp_10(struct device *dev,if (val ==OCC_TEMP_SENSOR_FAULT )return -EREMOTEIO ; -/* -* VRM doesn't return temperature, only alarm bit. This -* attribute maps to tempX_alarm instead of tempX_input for -* VRM -*/ -if (temp->fru_type !=OCC_FRU_TYPE_VRM ) { -/* sensor not ready */ -if (val ==0 ) -return -EAGAIN ; +/* sensor not ready */ +if (val ==0 ) +return -EAGAIN ; - val *=1000 ; - } + val *=1000 ;break ;case 2 : val = temp->fru_type;@@ -886,7 +879,7 @@ static int occ_setup_sensor_attrs(struct occ *occ) 0, i); attr++; -if (sensors->temp.version >1 && +if (sensors->temp.version ==2 && temp->fru_type ==OCC_FRU_TYPE_VRM ) {snprintf (attr->name,sizeof (attr->name),"temp%d_alarm" , s);