net: sched: Use struct_size() helper in kvmalloc()

PATCH New Gustavo A. R. Silva 1 participant 1 message Sep 29, 2021

Subsystems (4)

Networking Network drivers Traffic control (tc) Netem network emulator

lore

Share & tools

lore

Gustavo A. R. Silva

author

2021-09-29 20:13 UTC #0 lore raw

PATCH 1/1 net: sched: Use struct_size() helper in kvmalloc()

Make use of the struct_size() helper instead of an open-coded version, in order to avoid any potential type mistakes or integer overflows that, in the worst scenario, could lead to heap overflows.

Link https://github.com/KSPP/linux/issues/160

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 net/sched/sch_netem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

net/sched/sch_netem.c +1 -1

index 0c345e43a09a..ecbb10db1111 100644
@@ -785,7 +785,7 @@ static int get_dist_table(struct Qdisc *sch, struct disttable **tbl,
 	if (!n || n > NETEM_DIST_MAX)
 		return -EINVAL;
 
-	d = kvmalloc(sizeof(struct disttable) + n * sizeof(s16), GFP_KERNEL);
+	d = kvmalloc(struct_size(d, table, n), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;

Signature · 1 line

2.27.0