Skip to contentSkip to conversation

tools/mgmt-tester: Fix Read Experiemental Feature test case

PATCH Applied Tedd Ho-Jeong An 3 participants 3 messages Sep 29, 2021 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tools/mgmt-tester: Fix Read Experiemental Feature test case

From: Tedd Ho-Jeong An <[email protected]>

The quality report feature is supported only if the device support it. Current emulator/btdev doesn't support it yet.

This patch updates the supported experimental feature list to align with the current btdev implementation.

---
 tools/mgmt-tester.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
tools/mgmt-tester.c +2 -6
index 9c5b26c9a..e62c4dcdc 100644
@@ -9334,7 +9334,7 @@ static const struct generic_data set_dev_flags_fail_3 = {
 };
 
 static const uint8_t read_exp_feat_param_success[] = {
-	0x04, 0x00,				/* Feature Count */
+	0x03, 0x00,				/* Feature Count */
 	0xd6, 0x49, 0xb0, 0xd1, 0x28, 0xeb,	/* UUID - Simultaneous */
 	0x27, 0x92, 0x96, 0x46, 0xc0, 0x42,	/* Central Peripheral */
 	0xb5, 0x10, 0x1b, 0x67,
@@ -9343,14 +9343,10 @@ static const uint8_t read_exp_feat_param_success[] = {
 	0xde, 0xb3, 0xea, 0x11, 0x73, 0xc2,
 	0x48, 0xa1, 0xc0, 0x15,
 	0x02, 0x00, 0x00, 0x00,			/* Flags */
-	0x7f, 0x03, 0x14, 0x06, 0x6f, 0x9a,	/* UUID - Quality Report */
-	0x70, 0x93, 0x2d, 0x49, 0x06, 0x75,
-	0xbc, 0x59, 0x08, 0x33,
-	0x00, 0x00, 0x00, 0x00,			/* Flags */
 	0xaf, 0x29, 0xc6, 0x66, 0xac, 0x5f,	/* UUID - Codec Offload */
 	0x1a, 0x88, 0xb9, 0x4f, 0x7f, 0xee,
 	0xce, 0x5a, 0x69, 0xa6,
-	0x01, 0x00, 0x00, 0x00			/* Flags */
+	0x00, 0x00, 0x00, 0x00			/* Flags */
 };
 
 static const struct generic_data read_exp_feat_success = {
Signature · 1 line
2.25.1
#1 lore raw

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=555241

---Test result---

Test Summary:

CheckPatch                    PASS      1.29 seconds
GitLint                       PASS      0.92 seconds
Prep - Setup ELL              PASS      41.56 seconds
Build - Prep                  PASS      0.48 seconds
Build - Configure             PASS      7.62 seconds
Build - Make                  PASS      177.64 seconds
Make Check                    PASS      9.26 seconds
Make Distcheck                PASS      212.31 seconds
Build w/ext ELL - Configure   PASS      7.82 seconds
Build w/ext ELL - Make        PASS      168.61 seconds

---
Regards,
Linux Bluetooth

maintainer Applied
#2 lore raw
In reply to Tedd Ho-Jeong An

Hi Tedd,

Quoted 42 lines · Tedd Ho-Jeong An

From: Tedd Ho-Jeong An <[email protected]>

The quality report feature is supported only if the device support it. Current emulator/btdev doesn't support it yet.

This patch updates the supported experimental feature list to align with the current btdev implementation.

---
 tools/mgmt-tester.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)
tools/mgmt-tester.c +2 -7
index 9c5b26c9a..e62c4dcdc 100644
@@ -9334,7 +9334,7 @@ static const struct generic_data set_dev_flags_fail_3 = {
 };
 
 static const uint8_t read_exp_feat_param_success[] = {
-       0x04, 0x00,                             /* Feature Count */
+       0x03, 0x00,                             /* Feature Count */
        0xd6, 0x49, 0xb0, 0xd1, 0x28, 0xeb,     /* UUID - Simultaneous */
        0x27, 0x92, 0x96, 0x46, 0xc0, 0x42,     /* Central Peripheral */
        0xb5, 0x10, 0x1b, 0x67,
@@ -9343,14 +9343,10 @@ static const uint8_t read_exp_feat_param_success[] = {
        0xde, 0xb3, 0xea, 0x11, 0x73, 0xc2,
        0x48, 0xa1, 0xc0, 0x15,
        0x02, 0x00, 0x00, 0x00,                 /* Flags */
-       0x7f, 0x03, 0x14, 0x06, 0x6f, 0x9a,     /* UUID - Quality Report */
-       0x70, 0x93, 0x2d, 0x49, 0x06, 0x75,
-       0xbc, 0x59, 0x08, 0x33,
-       0x00, 0x00, 0x00, 0x00,                 /* Flags */
        0xaf, 0x29, 0xc6, 0x66, 0xac, 0x5f,     /* UUID - Codec Offload */
        0x1a, 0x88, 0xb9, 0x4f, 0x7f, 0xee,
        0xce, 0x5a, 0x69, 0xa6,
-       0x01, 0x00, 0x00, 0x00                  /* Flags */
+       0x00, 0x00, 0x00, 0x00                  /* Flags */
 };
 
 static const struct generic_data read_exp_feat_success = {
--
Quoted 1 line

2.25.1

Applied, thanks.

Signature · 1 line
Luiz Augusto von Dentz