mm: remove useless lines in enable_cpucache()
PATCH 1/1 mm: remove useless lines in enable_cpucache()
These lines are useless, so remove them.
Signed-off-by Shi Lei <[email protected]>
--- mm/slab.c | 3 --- 1 file changed, 3 deletions(-)
mm/slab.c +0 -3
@@ -3900,8 +3900,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp)if (err) goto end; -if (limit && shared && batchcount) - goto skip_setup;/* * The head array serves three purposes: * - create a LIFO ordering, i.e. return objects that are cache-warm
@@ -3944,7 +3942,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp) limit =32 ;#endif batchcount = (limit +1 ) /2 ; -skip_setup: err =do_tune_cpucache (cachep, limit, batchcount, shared, gfp); end:if (err)
Signature · 1 line
2.25.1
Quoted 1 line · Shi Lei
These lines are useless, so remove them.
I would clarify that they are useless after commit 10befea91b61 ("mm:
memcg/slab: use a single set of kmem_caches for all allocations")
Quoted 1 line
Signed-off-by Shi Lei <[email protected]>
Reviewed-by Vlastimil Babka <[email protected]>
Quoted 26 lines
--- mm/slab.c | 3 --- 1 file changed, 3 deletions(-)mm/slab.c +0
-3@@ -3900,8 +3900,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp)if (err) goto end; -if (limit && shared && batchcount) - goto skip_setup;/* * The head array serves three purposes: * - create a LIFO ordering, i.e. return objects that are cache-warm @@ -3944,7 +3942,6 @@ static int enable_cpucache(struct kmem_cache *cachep, gfp_t gfp) limit =32 ;#endif batchcount = (limit +1 ) /2 ; -skip_setup: err =do_tune_cpucache (cachep, limit, batchcount, shared, gfp); end:if (err)
Quoted 3 lines · Shi Lei
These lines are useless, so remove them.
Signed-off-by Shi Lei <[email protected]>
Acked-by David Rientjes <[email protected]>