Skip to contentSkip to conversation

staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform()

PATCH Superseded Michael Straube 2 participants 2 messages Sep 30, 2021 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: r8188eu: remove rtl8188e_silentreset_for_specific_platform()

Function rtl8188e_silentreset_for_specific_platform() is empty, remove it.

---
 drivers/staging/r8188eu/hal/rtl8188e_sreset.c     | 6 ------
 drivers/staging/r8188eu/include/rtl8188e_sreset.h | 1 -
 drivers/staging/r8188eu/os_dep/ioctl_linux.c      | 1 -
 3 files changed, 8 deletions(-)
drivers/staging/r8188eu/hal/rtl8188e_sreset.c +0 -6
index 16fa249e35d3..a16f10b438ad 100644
@@ -6,10 +6,6 @@
 #include "../include/rtl8188e_sreset.h"
 #include "../include/rtl8188e_hal.h"
 
-void rtl8188e_silentreset_for_specific_platform(struct adapter *padapter)
-{
-}
-
 void rtl8188e_sreset_xmit_status_check(struct adapter *padapter)
 {
 	struct hal_data_8188e	*pHalData = GET_HAL_DATA(padapter);
@@ -24,7 +20,6 @@ void rtl8188e_sreset_xmit_status_check(struct adapter *padapter)
 	if (txdma_status != 0x00) {
 		DBG_88E("%s REG_TXDMA_STATUS:0x%08x\n", __func__, txdma_status);
 		rtw_write32(padapter, REG_TXDMA_STATUS, txdma_status);
-		rtl8188e_silentreset_for_specific_platform(padapter);
 	}
 	/* total xmit irp = 4 */
 	current_time = jiffies;
@@ -38,7 +33,6 @@ void rtl8188e_sreset_xmit_status_check(struct adapter *padapter)
 				diff_time = jiffies_to_msecs(current_time - psrtpriv->last_tx_complete_time);
 				if (diff_time > 4000) {
 					DBG_88E("%s tx hang\n", __func__);
-					rtl8188e_silentreset_for_specific_platform(padapter);
 				}
 			}
 		}
drivers/staging/r8188eu/include/rtl8188e_sreset.h +0 -1
index 880c5792d5dd..5d7fec78a27b 100644
@@ -8,7 +8,6 @@
 #include "drv_types.h"
 #include "rtw_sreset.h"
 
-void rtl8188e_silentreset_for_specific_platform(struct adapter *padapter);
 void rtl8188e_sreset_xmit_status_check(struct adapter *padapter);
 void rtl8188e_sreset_linked_status_check(struct adapter *padapter);
 
drivers/staging/r8188eu/os_dep/ioctl_linux.c +0 -1
index dd47098ed1e5..852f8e0bbf64 100644
@@ -4005,7 +4005,6 @@ static int rtw_dbg_port(struct net_device *dev,
 		case 0x0f:
 			if (extra_arg == 0) {
 				DBG_88E("###### silent reset test.......#####\n");
-				rtl8188e_silentreset_for_specific_platform(padapter);
 			}
 			break;
 		case 0x15:
Signature · 1 line
2.33.0
#1 lore raw

drivers/staging/r8188eu/os_dep/ioctl_linux.c static int rtw_dbg_port(struct net_device *dev, · line 4008

Quoted 10 lines · Michael Straube
drivers/staging/r8188eu/os_dep/ioctl_linux.c +0 -1
index dd47098ed1e5..852f8e0bbf64 100644
@@ -4005,7 +4005,6 @@ static int rtw_dbg_port(struct net_device *dev,
 		case 0x0f:
 			if (extra_arg == 0) {
 				DBG_88E("###### silent reset test.......#####\n");
-				rtl8188e_silentreset_for_specific_platform(padapter);
 			}

This introduces a new checkpatch warning about unnessary curly braces. Just delete the whole if statement.

regards,
dan carpenter