PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()

PATCH Applied Krzysztof Wilczyński 3 participants 3 messages Oct 1, 2021 – Oct 5, 2021

Subsystems (3)

PCI PCI native host bridge and endpoint drivers Arm/Toshiba visconti architecture

lore

Share & tools

lore

Krzysztof Wilczyński

author

2021-10-01 01:16 UTC #0 lore raw

PATCH 1/1 PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()

There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error

Signed-off-by Krzysztof Wilczyński <[email protected]>

---
 drivers/pci/controller/dwc/pcie-visconti.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

drivers/pci/controller/dwc/pcie-visconti.c +1 -3

index a88eab6829bb..076da46726a7 100644
@@ -282,10 +282,8 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
 	struct device *dev = &pdev->dev;
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
-	if (pp->irq < 0) {
-		dev_err(dev, "Interrupt intr is missing");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	pp->ops = &visconti_pcie_host_ops;

Signature · 1 line

2.33.0

[email protected]

Acked-by on v1 1/1

2021-10-01 04:38 UTC #1 lore raw

Hi,

Quoted 17 lines

-----Original Message-----
From: Krzysztof Wilczyński [mailto:[email protected]]
Sent: Friday, October 1, 2021 10:16 AM
To: Bjorn Helgaas <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>; iwamatsu nobuhiro(岩松信洋 □ＳＷＣ◯ＡＣＴ) <[email protected]>; [email protected]; [email protected]
Subject: [PATCH] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()
There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.
This change is as per suggestions from Coccinelle, e.g.,
drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints
an error

Quoted 8 lines

Related:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/
Signed-off-by Krzysztof Wilczyński <[email protected]>
---
 drivers/pci/controller/dwc/pcie-visconti.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Thanks for your patch.

Acked-by Nobuhiro Iwamatsu <[email protected]>

Quoted 18 lines

drivers/pci/controller/dwc/pcie-visconti.c +1 -4

index a88eab6829bb..076da46726a7 100644
@@ -282,10 +282,8 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
 	struct device *dev = &pdev->dev;
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
-	if (pp->irq < 0) {
-		dev_err(dev, "Interrupt intr is missing");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	pp->ops = &visconti_pcie_host_ops;
 
--

Quoted 1 line

2.33.0

Best regards,
Nobuhiro

Lorenzo Pieralisi

Applied

2021-10-05 08:59 UTC #2 lore raw

In reply to Krzysztof Wilczyński

Quoted 9 lines · Krzysztof Wilczyński

There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.
This change is as per suggestions from Coccinelle, e.g.,
drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error
[...]

Applied to pci/dwc, thanks!

[1/1] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()

      https://git.kernel.org/lpieralisi/pci/c/99e8fc7d35

Thanks,
Lorenzo