PCI: imx6: Remove unused assignment to variable ret
Subsystems (4)
PATCH 1/1 PCI: imx6: Remove unused assignment to variable ret
Previously, the maximum link speed was set following an "fsl,max-link-speed" property read, and should the read failed, then the PCIe generation was manually set to PCIe Gen1 and thus limiting the link speed to 2.5 GT/s.
Code refactoring completed in the commit 39bc5006501c ("PCI: dwc:
Centralize link gen setting") changed to the logic that was previously used to limit the maximum link speed leaving behind an unused assignment to a variable "ret".
Since the value returned from the of_property_read_u32() and stored in the variable "ret" is never used in any meaningful way, and it's also immediately reassigned in the code that follows, the assignment can be removed.
--- drivers/pci/controller/dwc/pci-imx6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/controller/dwc/pci-imx6.c +1 -1
@@ -1132,7 +1132,7 @@ static int imx6_pcie_probe(struct platform_device *pdev)/* Limit link speed */ pci->link_gen =1 ; - ret =of_property_read_u32 (node,"fsl,max-link-speed" , &pci->link_gen); +of_property_read_u32 (node,"fsl,max-link-speed" , &pci->link_gen); imx6_pcie->vpcie =devm_regulator_get_optional (&pdev->dev,"vpcie" );if (IS_ERR (imx6_pcie->vpcie)) {
Signature · 1 line
2.33.0
Lorenzo Pieralisi
AppliedQuoted 10 lines · Krzysztof Wilczyński
Previously, the maximum link speed was set following an "fsl,max-link-speed" property read, and should the read failed, then the PCIe generation was manually set to PCIe Gen1 and thus limiting the link speed to 2.5 GT/s.
Code refactoring completed in the commit
39bc5006501c("PCI: dwc:
Centralize link gen setting") changed to the logic that was previously used to limit the maximum link speed leaving behind an unused assignment to a variable "ret".[...]
Applied to pci/imx6, thanks!
[1/1] PCI: imx6: Remove unused assignment to variable ret
https://git.kernel.org/lpieralisi/pci/c/65315ec52c
Thanks,
Lorenzo