scsi: efct: Delete stray unlock statement
PATCH 1/1 scsi: efct: Delete stray unlock statement
It's not holding the lock at this stage and the IRQ "flags" are not correct so it would restore something bogus. Delete the unlock statement.
Fixes 3e6414003bf9 ("scsi: elx: efct: SCSI I/O handling routines")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/scsi/elx/efct/efct_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/scsi/elx/efct/efct_scsi.c +1 -2
@@ -32,7 +32,7 @@ efct_scsi_io_alloc(struct efct_node *node)struct efct *efct;struct efct_xport *xport;struct efct_io *io; -unsigned long flags =0 ; +unsigned long flags; efct = node->efct;
@@ -42,7 +42,6 @@ efct_scsi_io_alloc(struct efct_node *node)if (!io) {efc_log_err (efct,"IO alloc Failed\n" );atomic_add_return (1 , &xport->io_alloc_failed_count); -spin_unlock_irqrestore (&node->active_ios_lock, flags);return NULL ; }
Signature · 1 line
2.20.1
Martin K. Petersen
AppliedQuoted 5 lines · Dan Carpenter
It's not holding the lock at this stage and the IRQ "flags" are not correct so it would restore something bogus. Delete the unlock statement.
Applied to 5.15/scsi-fixes, thanks!
[1/1] scsi: efct: Delete stray unlock statement
https://git.kernel.org/mkp/scsi/c/a013c71c6315
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering