Skip to contentSkip to conversation

usb: gadget: udc: core: Use pr_fmt() to prefix messages

PATCH New Andy Shevchenko 1 participant 2 messages Oct 4, 2021 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 usb: gadget: udc: core: Use pr_fmt() to prefix messages

Instead of duplicating, use pr_fmt() to prefix pr_*() messages.

---
 drivers/usb/gadget/udc/core.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/core.c +4 -2
index 14fdf918ecfe..f66ac6f8011e 100644
@@ -6,6 +6,8 @@
  * Author: Felipe Balbi <[email protected]>
  */
 
+#define pr_fmt(fmt)	"UDC core: " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/device.h>
@@ -1555,14 +1557,14 @@ int usb_gadget_probe_driver(struct usb_gadget_driver *driver)
 
 	if (!driver->match_existing_only) {
 		list_add_tail(&driver->pending, &gadget_driver_pending_list);
-		pr_info("udc-core: couldn't find an available UDC - added [%s] to list of pending drivers\n",
+		pr_info("couldn't find an available UDC - added [%s] to list of pending drivers\n",
 			driver->function);
 		ret = 0;
 	}
 
 	mutex_unlock(&udc_lock);
 	if (ret)
-		pr_warn("udc-core: couldn't find an available UDC or it's busy\n");
+		pr_warn("couldn't find an available UDC or it's busy\n");
 	return ret;
 found:
 	ret = udc_bind_to_driver(udc, driver);
Signature · 1 line
2.33.0
#1 lore raw

PATCH 2/2 usb: gadget: udc: core: Print error code in usb_gadget_probe_driver()

When the UDC is not found, print also the error code for easier debugging.

---
 drivers/usb/gadget/udc/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/udc/core.c +1 -1
index f66ac6f8011e..d6265118647b 100644
@@ -1564,7 +1564,7 @@ int usb_gadget_probe_driver(struct usb_gadget_driver *driver)
 
 	mutex_unlock(&udc_lock);
 	if (ret)
-		pr_warn("couldn't find an available UDC or it's busy\n");
+		pr_warn("couldn't find an available UDC or it's busy: %d\n", ret);
 	return ret;
 found:
 	ret = udc_bind_to_driver(udc, driver);
Signature · 1 line
2.33.0