rtw88: fix RX clock gate setting while fifo dump
Ping-Ke Shih
maintainerPATCH 1/1 rtw88: fix RX clock gate setting while fifo dump
From: Zong-Zhe Yang <[email protected]>
When fw fifo dumps, RX clock gating should be disabled to avoid something unexpected. However, the register operation ran into a mistake. So, we fix it.
Signed-off-by Zong-Zhe Yang <[email protected]>
Signed-off-by Ping-Ke Shih <[email protected]>
--- drivers/net/wireless/realtek/rtw88/fw.c | 7 +++---- drivers/net/wireless/realtek/rtw88/reg.h | 1 + 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/net/wireless/realtek/rtw88/fw.c +3 -4
@@ -1582,12 +1582,10 @@ static void rtw_fw_read_fifo_page(struct rtw_dev *rtwdev, u32 offset, u32 size,u32 i;u16 idx =0 ;u16 ctl; -u8 rcr; - rcr =rtw_read8 (rtwdev,REG_RCR +2 ); ctl =rtw_read16 (rtwdev,REG_PKTBUF_DBG_CTRL ) &0xf000 ;/* disable rx clock gate */ -rtw_write8 (rtwdev,REG_RCR , rcr |BIT (3 )); +rtw_write32_set (rtwdev,REG_RCR ,BIT_DISGCLK ); do { rtw_write16(rtwdev, REG_PKTBUF_DBG_CTRL, start_pg | ctl);
@@ -1606,7 +1604,8 @@ static void rtw_fw_read_fifo_page(struct rtw_dev *rtwdev, u32 offset, u32 size, out:rtw_write16 (rtwdev,REG_PKTBUF_DBG_CTRL , ctl); -rtw_write8 (rtwdev,REG_RCR +2 , rcr); +/* restore rx clock gate */ +rtw_write32_clr (rtwdev,REG_RCR ,BIT_DISGCLK ); } static void rtw_fw_read_fifo(struct rtw_dev *rtwdev, enum rtw_fw_fifo_sel sel,
drivers/net/wireless/realtek/rtw88/reg.h +1 -0
@@ -408,6 +408,7 @@#define BIT_MFBEN BIT(22)#define BIT_DISCHKPPDLLEN BIT(21)#define BIT_PKTCTL_DLEN BIT(20) +#define BIT_DISGCLK BIT(19)#define BIT_TIM_PARSER_EN BIT(18)#define BIT_BC_MD_EN BIT(17)#define BIT_UC_MD_EN BIT(16)
Signature · 1 line
2.25.1
Quoted 8 lines · Ping-Ke Shih
From: Zong-Zhe Yang <[email protected]>
When fw fifo dumps, RX clock gating should be disabled to avoid something unexpected. However, the register operation ran into a mistake. So, we fix it.
Signed-off-by Zong-Zhe Yang <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
c5a8e90730a3 rtw88: fix RX clock gate setting while fifo dump
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches