clk:aspeed:Fix reset driver probe from builtin_platform to core_initcal
PATCH 1/1 clk:aspeed:Fix reset driver probe from builtin_platform to core_initcal
Change the reset probe sequence from builtin_platform to core_initcal. For avoid some driver is probe but failed due to reset driver not probe.
--- drivers/clk/clk-ast2600.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/clk/clk-ast2600.c +7 -1
@@ -686,7 +686,13 @@ static struct platform_driver aspeed_g6_clk_driver = { .suppress_bind_attrs = true, }, }; -builtin_platform_driver (aspeed_g6_clk_driver); + +static int __init aspeed_g6_clk_init (void ) +{ +return platform_driver_register (&aspeed_g6_clk_driver); +} + +core_initcall (aspeed_g6_clk_init);static const u32 ast2600_a0_axi_ahb_div_table[] = { 2, 2, 3, 5,
Signature · 1 line
2.17.1
Stephen Boyd
maintainerQuoting Ryan Chen (2021-10-04 23:45:13)
Quoted 2 lines
Change the reset probe sequence from
builtin_platformtocore_initcal. For avoid some driver is probe but failed due to reset driver not probe.
I don't get it. Does something never try probe again because it can't get the reset it wants? I understand that builtin_platform_driver() moves the initcall level later than core_initcall() so this is a workaround for some driver probe ordering problem?
Quoted 3 lines
Fixes d3d04f6c330a ("clk: Add support for AST2600 SoC")Signed-off-by Ryan Chen <[email protected]>
Hello,
Quoted 9 lines
-----Original Message-----
From: Stephen Boyd <[email protected]>
Sent: Sunday, October 17, 2021 9:45 AM
To: Andrew Jeffery <[email protected]>; Joel Stanley <[email protected]>; Michael Turquette <[email protected]>; [email protected]; [email protected]; Ryan Chen <[email protected]>
Subject: Re: [PATCH] clk:aspeed:Fix reset driver probe frombuiltin_platformtocore_initcal
Quoted 8 lines
Quoting Ryan Chen (2021-10-04 23:45:13)
Quoted 2 lines
Change the reset probe sequence from
builtin_platformtocore_initcal. For avoid some driver is probe but failed due to reset driver not probe.I don't get it. Does something never try probe again because it can't get the reset it wants? I understand that
builtin_platform_driver()moves the initcall level later thancore_initcall()so this is a workaround for some driver probe ordering problem?
The most of driver have reset function in probe. if driver probe need do the reset
(ex: devm_reset_control_get_shared) but reset driver not ready (devm_reset_controller_register), that driver probe will cause the fail, than after reset driver probe, there will have second probe In driver. That the reason I put reset probe in core_initcall.
And also you can see that the reason most soc chip do the devm_reset_controller_register in core_initcall.
Quoted 4 lines
Quoted 4 lines
Fixes d3d04f6c330a ("clk: Add support for AST2600 SoC")Signed-off-by Ryan Chen <[email protected]>
Quoted 5 lines · Ryan Chen
Change the reset probe sequence from
builtin_platformtocore_initcal. For avoid some driver is probe but failed due to reset driver not probe.Fixes d3d04f6c330a ("clk: Add support for AST2600 SoC")Signed-off-by Ryan Chen <[email protected]>
Quoted 25 lines
---
drivers/clk/clk-ast2600.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)diff --git a/drivers/clk/clk-ast2600.c b/drivers/clk/clk-ast2600.c index 085d0a18b2b6..6293d8d1a6a8 100644 --- a/drivers/clk/clk-ast2600.c +++ b/drivers/clk/clk-ast2600.c @@ -686,7 +686,13 @@ static struct platform_driver aspeed_g6_clk_driver = { .suppress_bind_attrs = true, }, }; -builtin_platform_driver(aspeed_g6_clk_driver); + +static int __init aspeed_g6_clk_init(void) +{ + return platform_driver_register(&aspeed_g6_clk_driver); +} + +core_initcall(aspeed_g6_clk_init);static const u32 ast2600_a0_axi_ahb_div_table[] = { 2, 2, 3, 5,--
2.17.1