clk: imx: Make CLK_IMX8ULP select MXC_CLK
Subsystems (3)
Fabio Estevam
reviewerPATCH 1/1 clk: imx: Make CLK_IMX8ULP select MXC_CLK
Building CLK_IMX8ULP without selecting MXC_CLK causes the following build errors:
ld: drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
Avoid this problem by making CLK_IMX8ULP select MXC_CLK.
--- drivers/clk/imx/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/clk/imx/Kconfig +1 -0
@@ -102,5 +102,6 @@ config CLK_IMX8QXP config CLK_IMX8ULP tristate "IMX8ULP CCM Clock Driver" depends on ARCH_MXC || COMPILE_TEST + select MXC_CLK help Build the driver for i.MX8ULP CCM Clock Driver
Signature · 1 line
2.25.1
Quoted 8 lines · Fabio Estevam
Building
CLK_IMX8ULPwithout selectingMXC_CLKcauses the following build errors:ld:
drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
Quoted 5 lines
Avoid this problem by making
CLK_IMX8ULPselectMXC_CLK.Fixes c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")Reported-by Randy Dunlap <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Thanks.
Quoted 16 lines
--- drivers/clk/imx/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/clk/imx/Kconfig +1
-0@@ -102,5 +102,6 @@ config CLK_IMX8QXP config CLK_IMX8ULP tristate "IMX8ULP CCM Clock Driver" depends on ARCH_MXC || COMPILE_TEST + select MXC_CLK help Build the driver for i.MX8ULP CCM Clock Driver
Signature · 1 line
~Randy
Quoted 8 lines · Fabio Estevam
Building
CLK_IMX8ULPwithout selectingMXC_CLKcauses the following build errors:ld:
drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
Quoted 5 lines
Avoid this problem by making
CLK_IMX8ULPselectMXC_CLK.Fixes c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")Reported-by Randy Dunlap <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Good catch, Randy.
Thanks for the fix, Fabio.
Quoted 18 lines
--- drivers/clk/imx/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/clk/imx/Kconfig +1
-0@@ -102,5 +102,6 @@ config CLK_IMX8QXP config CLK_IMX8ULP tristate "IMX8ULP CCM Clock Driver" depends on ARCH_MXC || COMPILE_TEST + select MXC_CLK help Build the driver for i.MX8ULP CCM Clock DriverSignature · 1 line
2.25.1
Quoted 8 lines · Fabio Estevam
Building
CLK_IMX8ULPwithout selectingMXC_CLKcauses the following build errors:ld:
drivers/clk/imx/clk-imx8ulp.o: in function `imx8ulp_clk_cgc2_init':
clk-imx8ulp.c:(.text+0xd0): undefined reference to `imx_ccm_lock'
ld: clk-imx8ulp.c:(.text+0x14f): undefined reference to `imx_clk_hw_pllv4'
ld: clk-imx8ulp.c:(.text+0x15a): undefined reference to `imx_ccm_lock'
Quoted 5 lines
Avoid this problem by making
CLK_IMX8ULPselectMXC_CLK.Fixes c43a801a5789 ("clk: imx: Add clock driver for imx8ulp")Reported-by Randy Dunlap <[email protected]>Signed-off-by Fabio Estevam <[email protected]>
Applied with Randy's ack and my R-b tag. Thanks.
Quoted 18 lines
--- drivers/clk/imx/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/clk/imx/Kconfig +1
-0@@ -102,5 +102,6 @@ config CLK_IMX8QXP config CLK_IMX8ULP tristate "IMX8ULP CCM Clock Driver" depends on ARCH_MXC || COMPILE_TEST + select MXC_CLK help Build the driver for i.MX8ULP CCM Clock DriverSignature · 1 line
2.25.1