PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()

There is no need to call the dev_err() function directly to print a custom message when handling an error from either the platform_get_irq() or platform_get_irq_byname() functions as both are going to display an appropriate error message in case of a failure.

This change is as per suggestions from Coccinelle, e.g.,
drivers/pci/controller/dwc/pcie-visconti.c:286:2-9: line 286 is redundant because platform_get_irq() already prints an error

Related:
https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/

---
Changes in v2:
Remove unused "dev" variable following removal of the dev_err() as reported by Intel's CI bot.

 drivers/pci/controller/dwc/pcie-visconti.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

index a88eab6829bb..50f80f07e4db 100644
@@ -279,13 +279,10 @@ static int visconti_add_pcie_port(struct visconti_pcie *pcie,
 {
 	struct dw_pcie *pci = &pcie->pci;
 	struct pcie_port *pp = &pci->pp;
-	struct device *dev = &pdev->dev;
 
 	pp->irq = platform_get_irq_byname(pdev, "intr");
-	if (pp->irq < 0) {
-		dev_err(dev, "Interrupt intr is missing");
+	if (pp->irq < 0)
 		return pp->irq;
-	}
 
 	pp->ops = &visconti_pcie_host_ops;
 

2.33.0

Hi Lorenzo,

[...]

Apologies for causing you more work. Especially, since you already applied previous version to your "pci/dwc" branch.

Krzysztof

Applied to pci/dwc, thanks!

[1/1] PCI: visconti: Remove surplus dev_err() when using platform_get_irq_byname()

      https://git.kernel.org/lpieralisi/pci/c/5b8402562e

Thanks,
Lorenzo