Skip to contentSkip to conversation

ocfs2/dlm: Remove redundant assignment of variable ret

PATCH Applied Colin King 2 participants 2 messages Oct 7, 2021 – Oct 8, 2021

Subsystems (2)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 ocfs2/dlm: Remove redundant assignment of variable ret

From: Colin Ian King <[email protected]>

The variable ret is being assigned a value that is never read, it is updated later on with a different value. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")

---
 fs/ocfs2/dlm/dlmrecovery.c | 1 -
 1 file changed, 1 deletion(-)
fs/ocfs2/dlm/dlmrecovery.c +0 -1
index e24e327524f8..52ad342fec3e 100644
@@ -2698,7 +2698,6 @@ static int dlm_send_begin_reco_message(struct dlm_ctxt *dlm, u8 dead_node)
 			continue;
 		}
 retry:
-		ret = -EINVAL;
 		mlog(0, "attempting to send begin reco msg to %d\n",
 			  nodenum);
 		ret = o2net_send_message(DLM_BEGIN_RECO_MSG, dlm->key,
Signature · 1 line
2.32.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 8 lines · Colin King

From: Colin Ian King <[email protected]>

The variable ret is being assigned a value that is never read, it is updated later on with a different value. The assignment is redundant and can be removed.

Addresses-Coverity: ("Unused value")

Quoted 17 lines
---
 fs/ocfs2/dlm/dlmrecovery.c | 1 -
 1 file changed, 1 deletion(-)
fs/ocfs2/dlm/dlmrecovery.c +0 -1
index e24e327524f8..52ad342fec3e 100644
@@ -2698,7 +2698,6 @@ static int dlm_send_begin_reco_message(struct dlm_ctxt *dlm, u8 dead_node)
 			continue;
 		}
 retry:
-		ret = -EINVAL;
 		mlog(0, "attempting to send begin reco msg to %d\n",
 			  nodenum);
 		ret = o2net_send_message(DLM_BEGIN_RECO_MSG, dlm->key,