Skip to contentSkip to conversation

generic/095: align DIO read/writes with the supported sector size for the device

PATCH New Luís Henriques 1 participant 1 message Oct 11, 2021

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 generic/095: align DIO read/writes with the supported sector size for the device

This test creates fio DIO jobs with bs=1k, which will fail when using block devices that have logical sector size bigger than 1k (such as zram, advanced format HDD's with 4k sectors, DASD's on mainframes with 2k sectors, etc).

Fix the test by using _min_dio_alignment instead to get the correct size.

---
Changes since v1:
- Updated commit subject and description as suggested by Ted (thanks for the review!)

 tests/generic/095 | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
tests/generic/095 +3 -2
index c4693917b3e1..80448200bb86 100755
@@ -23,6 +23,7 @@ iodepth_batch=$((8 * LOAD_FACTOR))
 numjobs=$((5 * LOAD_FACTOR))
 fio_config=$tmp.fio
 fio_out=$tmp.fio.out
+blksz=$(_min_dio_alignment $SCRATCH_DEV)
 cat >$fio_config <<EOF
 [global]
 bs=8k
@@ -34,7 +35,7 @@ directory=$SCRATCH_MNT
 numjobs=$numjobs
 [job1]
 ioengine=sync
-bs=1k
+bs=$blksz
 direct=1
 rw=randread
 filename=file1:file2
@@ -44,7 +45,7 @@ rw=randwrite
 direct=1
 filename=file1:file2
 [job3]
-bs=1k
+bs=$blksz
 ioengine=posixaio
 rw=randwrite
 direct=1