xfs: Use kvcalloc() instead of kvzalloc()
PATCH 1/1 xfs: Use kvcalloc() instead of kvzalloc()
Use 2-factor argument multiplication form kvcalloc() instead of kvzalloc().
--- fs/xfs/xfs_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
fs/xfs/xfs_ioctl.c +3 -3
@@ -1547,7 +1547,7 @@ xfs_ioc_getbmap(if (bmx.bmv_count >ULONG_MAX / recsize)return -ENOMEM ; - buf =kvzalloc (bmx.bmv_count *sizeof (*buf),GFP_KERNEL ); + buf =kvcalloc (bmx.bmv_count,sizeof (*buf),GFP_KERNEL );if (!buf)return -ENOMEM ;
@@ -1601,11 +1601,11 @@ xfs_ioc_getfsmap(*/ count = min_t(unsigned int, head.fmh_count,131072 /sizeof (struct fsmap )); - recs =kvzalloc (count *sizeof (struct fsmap ),GFP_KERNEL ); + recs =kvcalloc (count,sizeof (struct fsmap ),GFP_KERNEL );if (!recs) { count = min_t(unsigned int, head.fmh_count,PAGE_SIZE /sizeof (struct fsmap )); - recs =kvzalloc (count *sizeof (struct fsmap ),GFP_KERNEL ); + recs =kvcalloc (count,sizeof (struct fsmap ),GFP_KERNEL );if (!recs)return -ENOMEM ; }
Signature · 1 line
2.27.0
Quoted 5 lines · Gustavo A. R. Silva
Use 2-factor argument multiplication form
kvcalloc()instead ofkvzalloc().
Oooh, fun, checks for multiplication overflows.
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 34 lines
--- fs/xfs/xfs_ioctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)fs/xfs/xfs_ioctl.c +3
-3@@ -1547,7 +1547,7 @@ xfs_ioc_getbmap(if (bmx.bmv_count >ULONG_MAX / recsize)return -ENOMEM ; - buf =kvzalloc (bmx.bmv_count *sizeof (*buf),GFP_KERNEL ); + buf =kvcalloc (bmx.bmv_count,sizeof (*buf),GFP_KERNEL );if (!buf)return -ENOMEM ;@@ -1601,11 +1601,11 @@ xfs_ioc_getfsmap(*/ count = min_t(unsigned int, head.fmh_count,131072 /sizeof (struct fsmap )); - recs =kvzalloc (count *sizeof (struct fsmap ),GFP_KERNEL ); + recs =kvcalloc (count,sizeof (struct fsmap ),GFP_KERNEL );if (!recs) { count = min_t(unsigned int, head.fmh_count,PAGE_SIZE /sizeof (struct fsmap )); - recs =kvzalloc (count *sizeof (struct fsmap ),GFP_KERNEL ); + recs =kvcalloc (count,sizeof (struct fsmap ),GFP_KERNEL );if (!recs)return -ENOMEM ; }Signature · 1 line
2.27.0