media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor()
Subsystems (3)
PATCH 1/1 media: ipu3-cio2: fix error code in cio2_bridge_connect_sensor()
Return -ENODEV if acpi_get_physical_device_location() fails. Don't return success.
Fixes 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")
Signed-off-by Dan Carpenter <[email protected]>
--- drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/pci/intel/ipu3/cio2-bridge.c +3 -1
@@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, goto err_put_adev; status =acpi_get_physical_device_location (adev->handle, &sensor->pld); -if (ACPI_FAILURE (status)) +if (ACPI_FAILURE (status)) { + ret = -ENODEV ; goto err_put_adev; + }if (sensor->ssdb.lanes >CIO2_MAX_LANES ) { dev_err(&adev->dev,
Signature · 1 line
2.20.1
Hi Dan
Quoted 5 lines · Dan Carpenter
Return
-ENODEVifacpi_get_physical_device_location()fails. Don't return success.Fixes 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")Signed-off-by Dan Carpenter <[email protected]>
Thanks for catching that.
Reviewed-by Daniel Scally <[email protected]>
Quoted 20 lines
--- drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/pci/intel/ipu3/cio2-bridge.c +3
-1@@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, goto err_put_adev; status =acpi_get_physical_device_location (adev->handle, &sensor->pld); -if (ACPI_FAILURE (status)) +if (ACPI_FAILURE (status)) { + ret = -ENODEV ; goto err_put_adev; + }if (sensor->ssdb.lanes >CIO2_MAX_LANES ) { dev_err(&adev->dev,
Quoting Dan Carpenter (2021-10-13 08:53:19)
Quoted 5 lines
Return
-ENODEVifacpi_get_physical_device_location()fails. Don't return success.Fixes 485aa3df0dff ("media: ipu3-cio2: Parse sensor orientation and rotation")Signed-off-by Dan Carpenter <[email protected]>
Reviewed-by Kieran Bingham <[email protected]>
Quoted 23 lines
--- drivers/media/pci/intel/ipu3/cio2-bridge.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/pci/intel/ipu3/cio2-bridge.c +3
-1@@ -238,8 +238,10 @@ static int cio2_bridge_connect_sensor(const struct cio2_sensor_config *cfg, goto err_put_adev; status =acpi_get_physical_device_location (adev->handle, &sensor->pld); -if (ACPI_FAILURE (status)) +if (ACPI_FAILURE (status)) { + ret = -ENODEV ; goto err_put_adev; + }if (sensor->ssdb.lanes >CIO2_MAX_LANES ) { dev_err(&adev->dev,Signature · 1 line
2.20.1