Skip to contentSkip to conversation

drm/tegra: mark nvdec_writel as inline

PATCH Applied Arnd Bergmann 2 participants 2 messages Oct 13, 2021 – Oct 18, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/tegra: mark nvdec_writel as inline

From: Arnd Bergmann <[email protected]>

Without CONFIG_IOMMU_API, the nvdec_writel() function is unused, causing a warning:

drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function]
48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)

      |             ^~~~~~~~~~~~

As this is a trivial wrapper around an inline function, mark it as inline itself, which avoids the warning as well.

Fixes e76599df354d ("drm/tegra: Add NVDEC driver")
---
 drivers/gpu/drm/tegra/nvdec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/tegra/nvdec.c +2 -1
index 410333e05de8..791bf1acf5f0 100644
@@ -45,7 +45,8 @@ static inline struct nvdec *to_nvdec(struct tegra_drm_client *client)
 	return container_of(client, struct nvdec, client);
 }
 
-static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)
+static inline void nvdec_writel(struct nvdec *nvdec, u32 value,
+				unsigned int offset)
 {
 	writel(value, nvdec->regs + offset);
 }
Signature · 1 line
2.29.2
#1 lore raw
Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Without CONFIG_IOMMU_API, the nvdec_writel() function is unused, causing a warning:

drivers/gpu/drm/tegra/nvdec.c:48:13: error: 'nvdec_writel' defined but not used [-Werror=unused-function]
48 | static void nvdec_writel(struct nvdec *nvdec, u32 value, unsigned int offset)

      |             ^~~~~~~~~~~~
Quoted 8 lines

As this is a trivial wrapper around an inline function, mark it as inline itself, which avoids the warning as well.

Fixes e76599df354d ("drm/tegra: Add NVDEC driver")
---
 drivers/gpu/drm/tegra/nvdec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry