DAMON: Support Physical Memory Address Space Monitoring
Subsystems (4)
SeongJae Park
maintainercover DAMON: Support Physical Memory Address Space Monitoring
Changes from Previous Version (RFC[1])
======================================
- Rebase on latest -mm tree
- Remove page granularity idleness monitoring part
[1] https://lore.kernel.org/linux-mm/[email protected]/
Introduction
============
DAMON is currently supporting only virtual address spaces monitoring. It can be easily extended for various use cases and address spaces by configuring its monitoring primitives layer to use appropriate primitives implementations, though. This patchset implements monitoring primitives for the physical address space monitoring using the structure.
Baseline and Complete Git Trees
===============================
The patches are based on the latest -mm tree (v5.15-rc4-mmots-2021-10-10-18-34)[1]. You can also clone the complete git tree:
$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git -b damon-paddr/patches/v1
The web is also available:
https://git.kernel.org/pub/scm/linux/kernel/git/sj/linux.git/tag/?h=damon-paddr/patches/v1
[1] https://github.com/hnaz/linux-mm/tree/v5.15-rc4-mmots-2021-10-10-18-34
Sequence of Patches
===================
The first 3 patches allow the user space users manually set the monitoring regions. The 1st patch implements the feature in the 'damon-dbgfs'. Then, patches for adding a unit tests (the 2nd patch) and updating the documentation (the 3rd patch) follow.
Following 4 patches implement the physical address space monitoring primitives. The 4th patch makes some primitive functions for the virtual address spaces primitives reusable. The 5th patch implements the physical address space monitoring primitives. The 6th patch links the primitives to the 'damon-dbgfs'. Finally, 7th patch documents this new features.
Patch History
=============
Changes from RFC v10
(https://lore.kernel.org/linux-mm/[email protected]/)
- Rebase on latest -mm tree
- Remove page granularity idleness monitoring part
Please refer to RFC v10 for previous history.
SeongJae Park (7):
mm/damon/dbgfs: Allow users to set initial monitoring target regions mm/damon/dbgfs-test: Add a unit test case for 'init_regions' Docs/admin-guide/mm/damon: Document 'init_regions' feature mm/damon/vaddr: Separate commonly usable functions mm/damon: Implement primitives for physical address space monitoring mm/damon/dbgfs: Support physical memory monitoring Docs/DAMON: Document physical memory monitoring support
Documentation/admin-guide/mm/damon/usage.rst | 62 ++++- Documentation/vm/damon/design.rst | 29 ++- Documentation/vm/damon/faq.rst | 5 +- include/linux/damon.h | 10 + mm/damon/Kconfig | 10 +- mm/damon/Makefile | 3 +- mm/damon/dbgfs-test.h | 54 +++++ mm/damon/dbgfs.c | 177 ++++++++++++++- mm/damon/paddr.c | 224 +++++++++++++++++++ mm/damon/prmtv-common.c | 88 ++++++++ mm/damon/prmtv-common.h | 17 ++ mm/damon/vaddr.c | 87 +------ 12 files changed, 655 insertions(+), 111 deletions(-) create mode 100644 mm/damon/paddr.c create mode 100644 mm/damon/prmtv-common.c create mode 100644 mm/damon/prmtv-common.h
Signature · 1 line
2.17.1
SeongJae Park
maintainerPATCH 1/7 mm/damon/dbgfs: Allow users to set initial monitoring target regions
Some 'damon-dbgfs' users would want to monitor only a part of the entire virtual memory address space. The program interface users in the kernel space could use '->before_start()' callback or set the regions inside the context struct as they want, but 'damon-dbgfs' users cannot.
For the reason, this commit introduces a new debugfs file called 'init_region'. 'damon-dbgfs' users can specify which initial monitoring target address regions they want by writing special input to the file. The input should describe each region in each line in the below form:
<pid> <start address> <end address>
Note that the regions will be updated to cover entire memory mapped regions after a 'regions update interval' is passed. If you want the regions to not be updated after the initial setting, you could set the interval as a very long time, say, a few decades.
--- mm/damon/dbgfs.c | 156 ++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 154 insertions(+), 2 deletions(-)
mm/damon/dbgfs.c +154 -2
@@ -394,6 +394,152 @@ static ssize_t dbgfs_target_ids_write(struct file *file,return ret; } +static ssize_t sprint_init_regions (struct damon_ctx *c,char *buf,ssize_t len) +{ +struct damon_target *t; +struct damon_region *r; +int written =0 ; +int rc; + +damon_for_each_target (t, c) { +damon_for_each_region (r, t) { + rc =scnprintf (&buf[written], len - written, +"%lu %lu %lu\n" , + t->id, r->ar.start, r->ar.end); +if (!rc) +return -ENOMEM ; + written += rc; + } + } +return written; +} + +static ssize_t dbgfs_init_regions_read (struct file *file,char __user *buf, +size_t count,loff_t *ppos) +{ +struct damon_ctx *ctx = file->private_data; +char *kbuf; +ssize_t len; + + kbuf =kmalloc (count,GFP_KERNEL ); +if (!kbuf) +return -ENOMEM ; + +mutex_lock (&ctx->kdamond_lock); +if (ctx->kdamond) { +mutex_unlock (&ctx->kdamond_lock); + len = -EBUSY ; + goto out; + } + + len =sprint_init_regions (ctx, kbuf, count); +mutex_unlock (&ctx->kdamond_lock); +if (len <0 ) + goto out; + len =simple_read_from_buffer (buf, count, ppos, kbuf, len); + +out: +kfree (kbuf); +return len; +} + +static int add_init_region (struct damon_ctx *c, +unsigned long target_id,struct damon_addr_range *ar) +{ +struct damon_target *t; +struct damon_region *r, *prev; +unsigned long id; +int rc = -EINVAL ; + +if (ar->start >= ar->end) +return -EINVAL ; + +damon_for_each_target (t, c) { + id = t->id; +if (targetid_is_pid (c)) + id = (unsigned long )pid_vnr ((struct pid *)id); +if (id == target_id) { + r =damon_new_region (ar->start, ar->end); +if (!r) +return -ENOMEM ; +damon_add_region (r, t); +if (damon_nr_regions (t) >1 ) { + prev =damon_prev_region (r); +if (prev->ar.end > r->ar.start) { +damon_destroy_region (r, t); +return -EINVAL ; + } + } + rc =0 ; + } + } +return rc; +} + +static int set_init_regions (struct damon_ctx *c,const char *str,ssize_t len) +{ +struct damon_target *t; +struct damon_region *r, *next; +int pos =0 , parsed, ret; +unsigned long target_id; +struct damon_addr_range ar; +int err; + +damon_for_each_target (t, c) { +damon_for_each_region_safe (r, next, t) +damon_destroy_region (r, t); + } + +while (pos < len) { + ret =sscanf (&str[pos],"%lu %lu %lu%n" , + &target_id, &ar.start, &ar.end, &parsed); +if (ret !=3 ) +break ; + err =add_init_region (c, target_id, &ar); +if (err) + goto fail; + pos += parsed; + } + +return 0 ; + +fail: +damon_for_each_target (t, c) { +damon_for_each_region_safe (r, next, t) +damon_destroy_region (r, t); + } +return err; +} + +static ssize_t dbgfs_init_regions_write (struct file *file, +const char __user *buf,size_t count, +loff_t *ppos) +{ +struct damon_ctx *ctx = file->private_data; +char *kbuf; +ssize_t ret = count; +int err; + + kbuf =user_input_str (buf, count, ppos); +if (IS_ERR (kbuf)) +return PTR_ERR (kbuf); + +mutex_lock (&ctx->kdamond_lock); +if (ctx->kdamond) { + ret = -EBUSY ; + goto unlock_out; + } + + err =set_init_regions (ctx, kbuf, ret); +if (err) + ret = err; + +unlock_out: +mutex_unlock (&ctx->kdamond_lock); +kfree (kbuf); +return ret; +} +static ssize_t dbgfs_kdamond_pid_read (struct file *file,char __user *buf,size_t count,loff_t *ppos) {
@@ -445,6 +591,12 @@ static const struct file_operations target_ids_fops = { .write = dbgfs_target_ids_write, }; +static const struct file_operations init_regions_fops = { + .open = damon_dbgfs_open, + .read = dbgfs_init_regions_read, + .write = dbgfs_init_regions_write, +}; +static const struct file_operations kdamond_pid_fops = { .open = damon_dbgfs_open, .read = dbgfs_kdamond_pid_read,
@@ -453,9 +605,9 @@ static const struct file_operations kdamond_pid_fops = {static void dbgfs_fill_ctx_dir (struct dentry *dir,struct damon_ctx *ctx) {const char *const file_names[] = {"attrs" ,"schemes" ,"target_ids" , -"kdamond_pid" }; +"init_regions" ,"kdamond_pid" };const struct file_operations *fops[] = {&attrs_fops, &schemes_fops, - &target_ids_fops, &kdamond_pid_fops}; + &target_ids_fops, &init_regions_fops, &kdamond_pid_fops};int i;for (i =0 ; i <ARRAY_SIZE (file_names); i++)
Signature · 1 line
2.17.1
Andrew Morton
maintainerRe: [PATCH 1/7] mm/damon/dbgfs: Allow users to set initial monitoring target regions
Quoted 24 lines · On Tue, 12 Oct 2021 20:57:05 +0000 SeongJae Park <[email protected]> wrote:
Some 'damon-dbgfs' users would want to monitor only a part of the entire virtual memory address space. The program interface users in the kernel space could use '->before_start()' callback or set the regions inside the context struct as they want, but 'damon-dbgfs' users cannot.
For the reason, this commit introduces a new debugfs file called '
init_region'. 'damon-dbgfs' users can specify which initial monitoring target address regions they want by writing special input to the file. The input should describe each region in each line in the below form:<pid> <start address> <end address>
Note that the regions will be updated to cover entire memory mapped regions after a 'regions update interval' is passed. If you want the regions to not be updated after the initial setting, you could set the interval as a very long time, say, a few decades.
...
mm/damon/dbgfs.c +5
-0+static int add_init_region (struct damon_ctx *c, +unsigned long target_id,struct damon_addr_range *ar) +{ +struct damon_target *t; +struct damon_region *r, *prev;
mm/damon/dbgfs.c static ssize_t dbgfs_target_ids_write(struct file *file, · line 460
Quoted 10 lines
mm/damon/dbgfs.c +10
-0+unsigned long id; +int rc = -EINVAL ; + +if (ar->start >= ar->end) +return -EINVAL ; + +damon_for_each_target (t, c) { + id = t->id; +if (targetid_is_pid (c)) + id = (unsigned long )pid_vnr ((struct pid *)id);
This is a bit ugly. Did you consider making damon_target.id a union of all the possible types it can contain? This will avoid typecasts, has documentation value and reflacts what is actually going on.
Quoted 18 lines
mm/damon/dbgfs.c +18
-0+if (id == target_id) { + r =damon_new_region (ar->start, ar->end); +if (!r) +return -ENOMEM ; +damon_add_region (r, t); +if (damon_nr_regions (t) >1 ) { + prev =damon_prev_region (r); +if (prev->ar.end > r->ar.start) { +damon_destroy_region (r, t); +return -EINVAL ; + } + } + rc =0 ; + } + } +return rc; +} +
SeongJae Park
maintainerRe: [PATCH 1/7] mm/damon/dbgfs: Allow users to set initial monitoring target regions
Quoted 32 lines · On Wed, 13 Oct 2021 15:45:35 -0700 Andrew Morton <[email protected]>…
Quoted 30 lines · On Tue, 12 Oct 2021 20:57:05 +0000 SeongJae Park <[email protected]> wrote:
Some 'damon-dbgfs' users would want to monitor only a part of the entire virtual memory address space. The program interface users in the kernel space could use '->before_start()' callback or set the regions inside the context struct as they want, but 'damon-dbgfs' users cannot.
For the reason, this commit introduces a new debugfs file called '
init_region'. 'damon-dbgfs' users can specify which initial monitoring target address regions they want by writing special input to the file. The input should describe each region in each line in the below form:<pid> <start address> <end address>
Note that the regions will be updated to cover entire memory mapped regions after a 'regions update interval' is passed. If you want the regions to not be updated after the initial setting, you could set the interval as a very long time, say, a few decades.
...
mm/damon/dbgfs.c +11
-0+static int add_init_region (struct damon_ctx *c, +unsigned long target_id,struct damon_addr_range *ar) +{ +struct damon_target *t; +struct damon_region *r, *prev; +unsigned long id; +int rc = -EINVAL ; + +if (ar->start >= ar->end) +return -EINVAL ; +
Quoted 8 lines
mm/damon/dbgfs.c static ssize_t dbgfs_target_ids_write(struct file *file, · line 460
Quoted 4 lines
mm/damon/dbgfs.c +4
-0+damon_for_each_target (t, c) { + id = t->id; +if (targetid_is_pid (c)) + id = (unsigned long )pid_vnr ((struct pid *)id);This is a bit ugly. Did you consider making damon_target.id a union of all the possible types it can contain? This will avoid typecasts, has documentation value and reflacts what is actually going on.
Agreed, thank you for this great comment! I will make it at least before adding another type of monitoring target.
Thanks,
SJ
Quoted 21 lines
Quoted 19 lines
mm/damon/dbgfs.c +18
-0+if (id == target_id) { + r =damon_new_region (ar->start, ar->end); +if (!r) +return -ENOMEM ; +damon_add_region (r, t); +if (damon_nr_regions (t) >1 ) { + prev =damon_prev_region (r); +if (prev->ar.end > r->ar.start) { +damon_destroy_region (r, t); +return -EINVAL ; + } + } + rc =0 ; + } + } +return rc; +} +
SeongJae Park
maintainerPATCH 2/7 mm/damon/dbgfs-test: Add a unit test case for 'init_regions'
In reply to SeongJae ParkThis commit adds another test case for the new feature, 'init_regions'.
--- mm/damon/dbgfs-test.h | 54 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 54 insertions(+)
mm/damon/dbgfs-test.h +54 -0
@@ -109,9 +109,63 @@ static void damon_dbgfs_test_set_targets(struct kunit *test)dbgfs_destroy_ctx (ctx); } +static void damon_dbgfs_test_set_init_regions (struct kunit *test) +{ +struct damon_ctx *ctx =damon_new_ctx (); +unsigned long ids[] = {1 ,2 ,3 }; +/* Each line represents one region in ``<target id> <start> <end>`` */ +char *const valid_inputs[] = {"2 10 20\n 2 20 30\n2 35 45" , +"2 10 20\n" , +"2 10 20\n1 39 59\n1 70 134\n 2 20 25\n" , +"" }; +/* Reading the file again will show sorted, clean output */ +char *const valid_expects[] = {"2 10 20\n2 20 30\n2 35 45\n" , +"2 10 20\n" , +"1 39 59\n1 70 134\n2 10 20\n2 20 25\n" , +"" }; +char *const invalid_inputs[] = {"4 10 20\n" ,/* target not exists */ +"2 10 20\n 2 14 26\n" ,/* regions overlap */ +"1 10 20\n2 30 40\n 1 5 8" };/* not sorted by address */ +char *input, *expect; +int i, rc; +char buf[256 ]; + +damon_set_targets (ctx, ids,3 ); + +/* Put valid inputs and check the results */ +for (i =0 ; i <ARRAY_SIZE (valid_inputs); i++) { + input = valid_inputs[i]; + expect = valid_expects[i]; + + rc =set_init_regions (ctx, input,strnlen (input,256 )); +KUNIT_EXPECT_EQ (test, rc,0 ); + +memset (buf,0 ,256 ); +sprint_init_regions (ctx, buf,256 ); + +KUNIT_EXPECT_STREQ (test, (char *)buf, expect); + } +/* Put invlid inputs and check the return error code */ +for (i =0 ; i <ARRAY_SIZE (invalid_inputs); i++) { + input = invalid_inputs[i]; +pr_info ("input: %s\n" , input); + rc =set_init_regions (ctx, input,strnlen (input,256 )); +KUNIT_EXPECT_EQ (test, rc, -EINVAL ); + +memset (buf,0 ,256 ); +sprint_init_regions (ctx, buf,256 ); + +KUNIT_EXPECT_STREQ (test, (char *)buf,"" ); + } + +damon_set_targets (ctx,NULL ,0 ); +damon_destroy_ctx (ctx); +} +static struct kunit_case damon_test_cases[] = {KUNIT_CASE (damon_dbgfs_test_str_to_target_ids),KUNIT_CASE (damon_dbgfs_test_set_targets), +KUNIT_CASE (damon_dbgfs_test_set_init_regions), {}, };
Signature · 1 line
2.17.1
SeongJae Park
maintainerPATCH 3/7 Docs/admin-guide/mm/damon: Document 'init_regions' feature
In reply to SeongJae ParkThis commit adds description of the 'init_regions' feature in the DAMON usage document.
--- Documentation/admin-guide/mm/damon/usage.rst | 41 +++++++++++++++++++- 1 file changed, 39 insertions(+), 2 deletions(-)
Documentation/admin-guide/mm/damon/usage.rst +39 -2
@@ -34,8 +34,9 @@ the reason, this document describes only the debugfs interface debugfs Interface ================= -DAMON exports four files, ``attrs``, ``target_ids``, ``schemes`` and -``monitor_on`` under its debugfs directory, ``<debugfs>/damon/``. +DAMON exports five files, ``attrs``, ``target_ids``, ``init_regions``, +``schemes`` and ``monitor_on`` under its debugfs directory, +``<debugfs>/damon/``. Attributes
@@ -74,6 +75,42 @@ check it again:: Note that setting the target ids doesn't start the monitoring. +Initial Monitoring Target Regions +--------------------------------- + +In case of the debugfs based monitoring, DAMON automatically sets and updates +the monitoring target regions so that entire memory mappings of target +processes can be covered. However, users can want to limit the monitoring +region to specific address ranges, such as the heap, the stack, or specific +file-mapped area. Or, some users can know the initial access pattern of their +workloads and therefore want to set optimal initial regions for the 'adaptive +regions adjustment'. + +In such cases, users can explicitly set the initial monitoring target regions +as they want, by writing proper values to the ``init_regions`` file. Each line +of the input should represent one region in below form.:: + + <target id> <start address> <end address> + +The ``target id`` should already in ``target_ids`` file, and the regions should +be passed in address order. For example, below commands will set a couple of +address ranges, ``1-100`` and ``100-200`` as the initial monitoring target +region of process 42, and another couple of address ranges, ``20-40`` and +``50-100`` as that of process 4242.:: + + # cd <debugfs>/damon + # echo "42 1 100 + 42 100 200 + 4242 20 40 + 4242 50 100" > init_regions + +Note that this sets the initial monitoring target regions only. In case of +virtual memory monitoring, DAMON will automatically updates the boundary of the +regions after one ``regions update interval``. Therefore, users should set the +``regions update interval`` large enough in this case, if they don't want the +update. + + Schemes -------
Signature · 1 line
2.17.1
SeongJae Park
maintainerPATCH 4/7 mm/damon/vaddr: Separate commonly usable functions
In reply to SeongJae ParkThis commit moves functions in the default virtual address spaces monitoring primitives that commonly usable from other address spaces like physical address space into a header file. Those will be reused by the physical address space monitoring primitives which will be implemented by the following commit.
--- mm/damon/Makefile | 2 +- mm/damon/prmtv-common.c | 88 +++++++++++++++++++++++++++++++++++++++++ mm/damon/prmtv-common.h | 17 ++++++++ mm/damon/vaddr.c | 87 +--------------------------------------- 4 files changed, 108 insertions(+), 86 deletions(-) create mode 100644 mm/damon/prmtv-common.c create mode 100644 mm/damon/prmtv-common.h
mm/damon/Makefile +1 -1
@@ -1,5 +1,5 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_DAMON) := core.o -obj-$(CONFIG_DAMON_VADDR) += vaddr.o +obj-$(CONFIG_DAMON_VADDR) += prmtv-common.o vaddr.o obj-$(CONFIG_DAMON_DBGFS) += dbgfs.o
mm/damon/prmtv-common.c new file +88 -0
88 lines not on this page · raw message
mm/damon/prmtv-common.h new file +17 -0
@@ -0,0 +1,17 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* +* Common Primitives for Data Access Monitoring +* +* Author: SeongJae Park <[email protected]> +*/ + +#include <linux/damon.h> +#include <linux/random.h> + +/* Get a random number in [l, r) */ +#define damon_rand (l, r) (l + prandom_u32_max(r - l)) + +struct page *damon_get_page (unsigned long pfn); + +void damon_ptep_mkold (pte_t *pte,struct mm_struct *mm,unsigned long addr); +void damon_pmdp_mkold (pmd_t *pmd,struct mm_struct *mm,unsigned long addr);
mm/damon/vaddr.c +2 -85
109 lines not on this page · raw message
Signature · 1 line
2.17.1
SeongJae Park
maintainerPATCH 5/7 mm/damon: Implement primitives for physical address space monitoring
In reply to SeongJae ParkThis commit implements the monitoring primitives for the physical memory address space. Internally, it uses the PTE Accessed bit, similar to that of the virtual address spaces monitoring primitives. It supports only user memory pages, as idle pages tracking does. If the monitoring target physical memory address range contains non-user memory pages, access check of the pages will do nothing but simply treat the pages as not accessed.
--- include/linux/damon.h | 10 ++ mm/damon/Kconfig | 8 ++ mm/damon/Makefile | 1 + mm/damon/paddr.c | 224 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 243 insertions(+) create mode 100644 mm/damon/paddr.c
include/linux/damon.h +10 -0
@@ -351,4 +351,14 @@ void damon_va_set_primitives(struct damon_ctx *ctx);#endif /* CONFIG_DAMON_VADDR */ +#ifdef CONFIG_DAMON_PADDR + +/* Monitoring primitives for the physical memory address space */ +void damon_pa_prepare_access_checks (struct damon_ctx *ctx); +unsigned int damon_pa_check_accesses (struct damon_ctx *ctx); +bool damon_pa_target_valid (void *t); +void damon_pa_set_primitives (struct damon_ctx *ctx); + +#endif /* CONFIG_DAMON_PADDR */ +#endif /* _DAMON_H */
mm/damon/Kconfig +8 -0
@@ -32,6 +32,14 @@ config DAMON_VADDR This builds the default data access monitoring primitives for DAMON that work for virtual address spaces. +config DAMON_PADDR + bool "Data access monitoring primitives for the physical address space" + depends on DAMON && MMU + select PAGE_IDLE_FLAG + help + This builds the default data access monitoring primitives for DAMON + that works for the physical address space. + config DAMON_VADDR_KUNIT_TEST bool "Test for DAMON primitives" if !KUNIT_ALL_TESTS depends on DAMON_VADDR && KUNIT=y
mm/damon/Makefile +1 -0
@@ -2,4 +2,5 @@ obj-$(CONFIG_DAMON) := core.o obj-$(CONFIG_DAMON_VADDR) += prmtv-common.o vaddr.o +obj-$(CONFIG_DAMON_PADDR) += prmtv-common.o paddr.o obj-$(CONFIG_DAMON_DBGFS) += dbgfs.o
mm/damon/paddr.c new file +224 -0
224 lines not on this page · raw message
Signature · 1 line
2.17.1
SeongJae Park
maintainerPATCH 6/7 mm/damon/dbgfs: Support physical memory monitoring
In reply to SeongJae ParkThis commit makes the 'damon-dbgfs' to support the physical memory monitoring, in addition to the virtual memory monitoring.
Users can do the physical memory monitoring by writing a special keyword, 'paddr\n' to the 'target_ids' debugfs file. Then, DAMON will check the special keyword and configure the monitoring context to run with the primitives for the physical address space.
Unlike the virtual memory monitoring, the monitoring target region will not be automatically set. Therefore, users should also set the monitoring target address region using the 'init_regions' debugfs file.
Also, note that the physical memory monitoring will not automatically terminated. The user should explicitly turn off the monitoring by writing 'off' to the 'monitor_on' debugfs file.
--- mm/damon/Kconfig | 2 +- mm/damon/dbgfs.c | 21 ++++++++++++++++++--- 2 files changed, 19 insertions(+), 4 deletions(-)
mm/damon/Kconfig +1 -1
@@ -54,7 +54,7 @@ config DAMON_VADDR_KUNIT_TEST config DAMON_DBGFS bool "DAMON debugfs interface" - depends on DAMON_VADDR && DEBUG_FS + depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS help This builds the debugfs interface for DAMON. The user space admins can use the interface for arbitrary data access monitoring.
mm/damon/dbgfs.c +18 -3
@@ -339,6 +339,7 @@ static ssize_t dbgfs_target_ids_write(struct file *file, const char __user *buf, size_t count, loff_t *ppos) { struct damon_ctx *ctx = file->private_data; +bool id_is_pid = true;char *kbuf, *nrs;unsigned long *targets;ssize_t nr_targets;
@@ -351,6 +352,11 @@ static ssize_t dbgfs_target_ids_write(struct file *file,return PTR_ERR (kbuf); nrs = kbuf; +if (!strncmp (kbuf,"paddr\n" , count)) { + id_is_pid = false; +/* target id is meaningless here, but we set it just for fun */ +scnprintf (kbuf, count,"42 " ); + } targets =str_to_target_ids (nrs, ret, &nr_targets);if (!targets) {
@@ -358,7 +364,7 @@ static ssize_t dbgfs_target_ids_write(struct file *file, goto out; } -if (targetid_is_pid (ctx)) { +if (id_is_pid) {for (i =0 ; i < nr_targets; i++) { targets[i] = (unsigned long )find_get_pid ( (int )targets[i]);
@@ -372,15 +378,24 @@ static ssize_t dbgfs_target_ids_write(struct file *file,mutex_lock (&ctx->kdamond_lock);if (ctx->kdamond) { -if (targetid_is_pid (ctx)) +if (id_is_pid)dbgfs_put_pids (targets, nr_targets); ret = -EBUSY ; goto unlock_out; } +/* remove targets with previously-set primitive */ +damon_set_targets (ctx,NULL ,0 ); + +/* Configure the context for the address space type */ +if (id_is_pid) +damon_va_set_primitives (ctx); +else +damon_pa_set_primitives (ctx); + err =damon_set_targets (ctx, targets, nr_targets);if (err) { -if (targetid_is_pid (ctx)) +if (id_is_pid)dbgfs_put_pids (targets, nr_targets); ret = err; }
Signature · 1 line
2.17.1
SeongJae Park
maintainerPATCH 7/7 Docs/DAMON: Document physical memory monitoring support
In reply to SeongJae ParkThis commit updates the DAMON documents for the physical memory address space monitoring support.
--- Documentation/admin-guide/mm/damon/usage.rst | 25 +++++++++++++---- Documentation/vm/damon/design.rst | 29 ++++++++++++-------- Documentation/vm/damon/faq.rst | 5 ++-- 3 files changed, 40 insertions(+), 19 deletions(-)
Documentation/admin-guide/mm/damon/usage.rst +20 -5
@@ -10,15 +10,16 @@ DAMON provides below three interfaces for different users. This is for privileged people such as system administrators who want a just-working human-friendly interface. Using this, users can use the DAMON’s major features in a human-friendly way. It may not be highly tuned for - special cases, though. It supports only virtual address spaces monitoring. + special cases, though. It supports both virtual and physical address spaces + monitoring. - *debugfs interface.* This is for privileged user space programmers who want more optimized use of DAMON. Using this, users can use DAMON’s major features by reading from and writing to special debugfs files. Therefore, you can write and use your personalized DAMON debugfs wrapper programs that reads/writes the debugfs files instead of you. The DAMON user space tool is also a reference - implementation of such programs. It supports only virtual address spaces - monitoring. + implementation of such programs. It supports both virtual and physical + address spaces monitoring. - *Kernel Space Programming Interface.* This is for kernel space programmers. Using this, users can utilize every feature of DAMON most flexibly and efficiently by writing kernel space
@@ -72,20 +73,34 @@ check it again:: # cat target_ids 42 4242 +Users can also monitor the physical memory address space of the system by +writing a special keyword, "``paddr\n``" to the file. Because physical address +space monitoring doesn't support multiple targets, reading the file will show a +fake value, ``42``, as below:: + + # cd <debugfs>/damon + # echo paddr > target_ids + # cat target_ids + 42 + Note that setting the target ids doesn't start the monitoring. Initial Monitoring Target Regions --------------------------------- -In case of the debugfs based monitoring, DAMON automatically sets and updates -the monitoring target regions so that entire memory mappings of target +In case of the virtual address space monitoring, DAMON automatically sets and +updates the monitoring target regions so that entire memory mappings of target processes can be covered. However, users can want to limit the monitoring region to specific address ranges, such as the heap, the stack, or specific file-mapped area. Or, some users can know the initial access pattern of their workloads and therefore want to set optimal initial regions for the 'adaptive regions adjustment'. +In contrast, DAMON do not automatically sets and updates the monitoring target +regions in case of physical memory monitoring. Therefore, users should set the +monitoring target regions by themselves. + In such cases, users can explicitly set the initial monitoring target regions as they want, by writing proper values to the ``init_regions`` file. Each line of the input should represent one region in below form.::
Documentation/vm/damon/design.rst +18 -11
@@ -35,13 +35,17 @@ two parts: 1. Identification of the monitoring target address range for the address space. 2. Access check of specific address range in the target space. -DAMON currently provides the implementation of the primitives for only the -virtual address spaces. Below two subsections describe how it works. +DAMON currently provides the implementations of the primitives for the physical +and virtual address spaces. Below two subsections describe how those work. VMA-based Target Address Range Construction ------------------------------------------- +This is only for the virtual address space primitives implementation. That for +the physical address space simply asks users to manually set the monitoring +target address ranges. + Only small parts in the super-huge virtual address space of the processes are mapped to the physical memory and accessed. Thus, tracking the unmapped address regions is just wasteful. However, because DAMON can deal with some
@@ -71,15 +75,18 @@ to make a reasonable trade-off. Below shows this in detail:: PTE Accessed-bit Based Access Check ----------------------------------- -The implementation for the virtual address space uses PTE Accessed-bit for -basic access checks. It finds the relevant PTE Accessed bit from the address -by walking the page table for the target task of the address. In this way, the -implementation finds and clears the bit for next sampling target address and -checks whether the bit set again after one sampling period. This could disturb -other kernel subsystems using the Accessed bits, namely Idle page tracking and -the reclaim logic. To avoid such disturbances, DAMON makes it mutually -exclusive with Idle page tracking and uses ``PG_idle`` and ``PG_young`` page -flags to solve the conflict with the reclaim logic, as Idle page tracking does. +Both of the implementations for physical and virtual address spaces use PTE +Accessed-bit for basic access checks. Only one difference is the way of +finding the relevant PTE Accessed bit(s) from the address. While the +implementation for the virtual address walks the page table for the target task +of the address, the implementation for the physical address walks every page +table having a mapping to the address. In this way, the implementations find +and clear the bit(s) for next sampling target address and checks whether the +bit(s) set again after one sampling period. This could disturb other kernel +subsystems using the Accessed bits, namely Idle page tracking and the reclaim +logic. To avoid such disturbances, DAMON makes it mutually exclusive with Idle +page tracking and uses ``PG_idle`` and ``PG_young`` page flags to solve the +conflict with the reclaim logic, as Idle page tracking does. Address Space Independent Core Mechanisms
Documentation/vm/damon/faq.rst +2 -3
@@ -36,10 +36,9 @@ constructions and actual access checks can be implemented and configured on the DAMON core by the users. In this way, DAMON users can monitor any address space with any access check technique. -Nonetheless, DAMON provides vma tracking and PTE Accessed bit check based +Nonetheless, DAMON provides vma/rmap tracking and PTE Accessed bit check based implementations of the address space dependent functions for the virtual memory -by default, for a reference and convenient use. In near future, we will -provide those for physical memory address space. +and the physical memory by default, for a reference and convenient use. Can I simply monitor page granularity?
Signature · 1 line
2.17.1