media: drivers: cx24113: remove redundant variable r
Subsystems (2)
PATCH 1/1 media: drivers: cx24113: remove redundant variable r
From: Colin Ian King <[email protected]>
Variable r is being assigned values but it is never being used. The variable is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>
--- drivers/media/dvb-frontends/cx24113.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/cx24113.c +1 -1
@@ -378,7 +378,7 @@ static void cx24113_set_nfr(struct cx24113_state *state, u16 n, s32 f, u8 r)static int cx24113_set_frequency (struct cx24113_state *state,u32 frequency) { -u8 r =1 ;/* or 2 */ +u8 r;u16 n =6 ;s32 f =0 ;
Signature · 1 line
2.32.0
Quoting Colin King (2021-10-14 16:12:35)
Quoted 5 lines
From: Colin Ian King <[email protected]>
Variable r is being assigned values but it is never being used. The variable is redundant and can be removed.
Indeed, it gets re-assigned at line 385 as the first cx24113_readreg.
Reviewed-by Kieran Bingham <[email protected]>
Quoted 22 lines
Addresses-Coverity: ("Unused value")
Signed-off-by Colin Ian King <[email protected]>--- drivers/media/dvb-frontends/cx24113.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/media/dvb-frontends/cx24113.c +1
-1@@ -378,7 +378,7 @@ static void cx24113_set_nfr(struct cx24113_state *state, u16 n, s32 f, u8 r)static int cx24113_set_frequency (struct cx24113_state *state,u32 frequency) { -u8 r =1 ;/* or 2 */ +u8 r;u16 n =6 ;s32 f =0 ;Signature · 1 line
2.32.0