Skip to contentSkip to conversation

media: drivers: cx24113: remove redundant variable r

PATCH In review Colin King 2 participants 2 messages Oct 14, 2021 – Oct 15, 2021

Subsystems (2)
lore
Share & tools
lore

Colin King

author
#0 lore raw

PATCH 1/1 media: drivers: cx24113: remove redundant variable r

From: Colin Ian King <[email protected]>

Variable r is being assigned values but it is never being used. The variable is redundant and can be removed.

Addresses-Coverity: ("Unused value")

---
 drivers/media/dvb-frontends/cx24113.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/cx24113.c +1 -1
index 60a9f70275f7..dd55d314bf9a 100644
@@ -378,7 +378,7 @@ static void cx24113_set_nfr(struct cx24113_state *state, u16 n, s32 f, u8 r)
 
 static int cx24113_set_frequency(struct cx24113_state *state, u32 frequency)
 {
-	u8 r = 1; /* or 2 */
+	u8 r;
 	u16 n = 6;
 	s32 f = 0;
 
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw

Quoting Colin King (2021-10-14 16:12:35)

Quoted 5 lines

From: Colin Ian King <[email protected]>

Variable r is being assigned values but it is never being used. The variable is redundant and can be removed.

Indeed, it gets re-assigned at line 385 as the first cx24113_readreg.

Quoted 22 lines

Addresses-Coverity: ("Unused value")

---
 drivers/media/dvb-frontends/cx24113.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/dvb-frontends/cx24113.c +1 -1
index 60a9f70275f7..dd55d314bf9a 100644
@@ -378,7 +378,7 @@ static void cx24113_set_nfr(struct cx24113_state *state, u16 n, s32 f, u8 r)
 
 static int cx24113_set_frequency(struct cx24113_state *state, u32 frequency)
 {
-       u8 r = 1; /* or 2 */
+       u8 r;
        u16 n = 6;
        s32 f = 0;
 
Signature · 1 line
2.32.0