PCI: mediatek-gen3: Disable DVFSRC voltage request
PATCH v3 1/1 PCI: mediatek-gen3: Disable DVFSRC voltage request
When the DVFSRC (dynamic voltage and frequency scaling resource collector) feature is not implemented, the PCIe hardware will assert a voltage request signal when exit from the L1 PM Substates to request a specific Vcore voltage, but cannot receive the voltage ready signal, which will cause the link to fail to exit the L1 PM Substates.
Disable DVFSRC voltage request by default, we need to find a common way to enable it in the future.
--- drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/pci/controller/pcie-mediatek-gen3.c +8 -0
@@ -79,6 +79,9 @@#define PCIE_ICMD_PM_REG 0x198#define PCIE_TURN_OFF_LINK BIT(4) +#define PCIE_MISC_CTRL_REG 0x348 +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1) +#define PCIE_TRANS_TABLE_BASE_REG 0x800#define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4#define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8
@@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port) val &= ~PCIE_INTX_ENABLE ;writel_relaxed (val, port->base +PCIE_INT_ENABLE_REG ); +/* Disable DVFSRC voltage request */ + val =readl_relaxed (port->base +PCIE_MISC_CTRL_REG ); + val |=PCIE_DISABLE_DVFSRC_VLT_REQ ; +writel_relaxed (val, port->base +PCIE_MISC_CTRL_REG ); +/* Assert all reset signals */ val =readl_relaxed (port->base +PCIE_RST_CTRL_REG ); val |=PCIE_MAC_RSTB |PCIE_PHY_RSTB |PCIE_BRG_RSTB |PCIE_PE_RSTB ;
Signature · 1 line
2.25.1
Hi Maintainers,
Just gentle ping for this patch, if there is anything I need to modify, please kindly let me know.
Thanks.
Quoted 51 lines · Jianjun Wang
When the DVFSRC (dynamic voltage and frequency scaling resource collector)
feature is not implemented, the PCIe hardware will assert a voltage request
signal when exit from the L1 PM Substates to request a specific Vcore voltage, but cannot receive the voltage ready signal, which will cause
the link to fail to exit the L1 PM Substates.Disable DVFSRC voltage request by default, we need to find a common way to
enable it in the future.Fixes d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driverfor MT8192")
Signed-off-by Jianjun Wang <[email protected]>Reviewed-by Tzung-Bi Shih <[email protected]>Tested-by Qizhong Cheng <[email protected]>--- drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/pci/controller/pcie-mediatek-gen3.c +8
-0@@ -79,6 +79,9 @@#define PCIE_ICMD_PM_REG 0x198#define PCIE_TURN_OFF_LINK BIT(4) +#define PCIE_MISC_CTRL_REG 0x348 +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1) +#define PCIE_TRANS_TABLE_BASE_REG 0x800#define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4#define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8@@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port) val &= ~PCIE_INTX_ENABLE;writel_relaxed (val, port->base +PCIE_INT_ENABLE_REG ); +/* Disable DVFSRC voltage request */ + val =readl_relaxed (port->base +PCIE_MISC_CTRL_REG ); + val |=PCIE_DISABLE_DVFSRC_VLT_REQ ; +writel_relaxed (val, port->base +PCIE_MISC_CTRL_REG ); +/* Assert all reset signals */ val =readl_relaxed (port->base +PCIE_RST_CTRL_REG );val |=
PCIE_MAC_RSTB|PCIE_PHY_RSTB|PCIE_BRG_RSTB|PCIE_PE_RSTB;
Hi Maintainers,
Just gentle ping for this patch, is there anything I need to do to get this patch merged?
Thanks.
Quoted 45 lines · Jianjun Wang
Quoted 43 lines · Jianjun Wang
When the DVFSRC (dynamic voltage and frequency scaling resource collector)
feature is not implemented, the PCIe hardware will assert a voltage request
signal when exit from the L1 PM Substates to request a specific Vcore
voltage, but cannot receive the voltage ready signal, which will cause
the link to fail to exit the L1 PM Substates.Disable DVFSRC voltage request by default, we need to find a common way to
enable it in the future.Fixes d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driverfor MT8192")
Signed-off-by Jianjun Wang <[email protected]>Reviewed-by Tzung-Bi Shih <[email protected]>Tested-by Qizhong Cheng <[email protected]>--- drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/pci/controller/pcie-mediatek-gen3.c +3
-0@@ -79,6 +79,9 @@#define PCIE_ICMD_PM_REG 0x198#define PCIE_TURN_OFF_LINK BIT(4) +#define PCIE_MISC_CTRL_REG 0x348 +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1) +#define PCIE_TRANS_TABLE_BASE_REG 0x800#define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4#define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8@@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port) val &= ~PCIE_INTX_ENABLE;writel_relaxed (val, port->base +PCIE_INT_ENABLE_REG );
Quoted 14 lines
Quoted 9 lines
drivers/pci/controller/pcie-mediatek-gen3.c +5
-0+/* Disable DVFSRC voltage request */ + val =readl_relaxed (port->base +PCIE_MISC_CTRL_REG ); + val |=PCIE_DISABLE_DVFSRC_VLT_REQ ; +writel_relaxed (val, port->base +PCIE_MISC_CTRL_REG ); +/* Assert all reset signals */ val =readl_relaxed (port->base +PCIE_RST_CTRL_REG );val |=
PCIE_MAC_RSTB|PCIE_PHY_RSTB|PCIE_BRG_RSTB|PCIE_PE_RSTB;_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 6 lines · Jianjun Wang
When the DVFSRC (dynamic voltage and frequency scaling resource collector) feature is not implemented, the PCIe hardware will assert a voltage request signal when exit from the L1 PM Substates to request a specific Vcore voltage, but cannot receive the voltage ready signal, which will cause the link to fail to exit the L1 PM Substates.
Quoted 7 lines
Disable DVFSRC voltage request by default, we need to find a common way to enable it in the future.
Fixes d3bf75b579b9 ("PCI: mediatek-gen3: Add MediaTek Gen3 driver for MT8192")Signed-off-by Jianjun Wang <[email protected]>Reviewed-by Tzung-Bi Shih <[email protected]>Tested-by Qizhong Cheng <[email protected]>
Quoted 31 lines
--- drivers/pci/controller/pcie-mediatek-gen3.c | 8 ++++++++ 1 file changed, 8 insertions(+)drivers/pci/controller/pcie-mediatek-gen3.c +8
-0@@ -79,6 +79,9 @@#define PCIE_ICMD_PM_REG 0x198#define PCIE_TURN_OFF_LINK BIT(4) +#define PCIE_MISC_CTRL_REG 0x348 +#define PCIE_DISABLE_DVFSRC_VLT_REQ BIT(1) +#define PCIE_TRANS_TABLE_BASE_REG 0x800#define PCIE_ATR_SRC_ADDR_MSB_OFFSET 0x4#define PCIE_ATR_TRSL_ADDR_LSB_OFFSET 0x8@@ -297,6 +300,11 @@ static int mtk_pcie_startup_port(struct mtk_pcie_port *port) val &= ~PCIE_INTX_ENABLE ;writel_relaxed (val, port->base +PCIE_INT_ENABLE_REG ); +/* Disable DVFSRC voltage request */ + val =readl_relaxed (port->base +PCIE_MISC_CTRL_REG ); + val |=PCIE_DISABLE_DVFSRC_VLT_REQ ; +writel_relaxed (val, port->base +PCIE_MISC_CTRL_REG ); +/* Assert all reset signals */ val =readl_relaxed (port->base +PCIE_RST_CTRL_REG ); val |=PCIE_MAC_RSTB |PCIE_PHY_RSTB |PCIE_BRG_RSTB |PCIE_PE_RSTB ;
Lorenzo Pieralisi
AppliedQuoted 10 lines · Jianjun Wang
When the DVFSRC (dynamic voltage and frequency scaling resource collector) feature is not implemented, the PCIe hardware will assert a voltage request signal when exit from the L1 PM Substates to request a specific Vcore voltage, but cannot receive the voltage ready signal, which will cause the link to fail to exit the L1 PM Substates.
Disable DVFSRC voltage request by default, we need to find a common way to enable it in the future.
[...]
Applied to pci/mediatek-gen3, thanks!
[1/1] PCI: mediatek-gen3: Disable DVFSRC voltage request
https://git.kernel.org/lpieralisi/pci/c/ab344fd43f
Thanks,
Lorenzo
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek