KVM: x86/mmu: kvm_faultin_pfn has to return false if pfh is returned
PATCH 1/1 KVM: x86/mmu: kvm_faultin_pfn has to return false if pfh is returned
This looks like a typo in 8f32d5e563cb. This change didn't intend to do any functional changes.
The problem was caught by gVisor tests.
Fixes 8f32d5e563cb ("KVM: x86/mmu: allow kvm_faultin_pfn to return page fault handling code")
Cc Maxim Levitsky <[email protected]>
Cc Paolo Bonzini <[email protected]>
Signed-off-by Andrei Vagin <[email protected]>
--- arch/x86/kvm/mmu/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/x86/kvm/mmu/mmu.c +1 -1
@@ -3956,7 +3956,7 @@ static bool kvm_faultin_pfn(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn, *pfn =__gfn_to_pfn_memslot (slot, gfn, false,NULL , write, writable, hva); - +return false; out_retry: *r =RET_PF_RETRY ;return true;
Signature · 1 line
2.31.1
Paolo Bonzini
maintainerQuoted 19 lines · Andrei Vagin
This looks like a typo in
8f32d5e563cb. This change didn't intend to do any functional changes.The problem was caught by gVisor tests.
Fixes 8f32d5e563cb ("KVM: x86/mmu: allow kvm_faultin_pfn to return page fault handling code")Cc Maxim Levitsky <[email protected]>Cc Paolo Bonzini <[email protected]>Signed-off-by Andrei Vagin <[email protected]>--- arch/x86/kvm/mmu/mmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/x86/kvm/mmu/mmu.c +0
-0
arch/x86/kvm/mmu/mmu.c static bool kvm_faultin_pfn(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn, · line 3962
Quoted 8 lines
arch/x86/kvm/mmu/mmu.c +1
-1@@ -3956,7 +3956,7 @@ static bool kvm_faultin_pfn(struct kvm_vcpu *vcpu, bool prefault, gfn_t gfn, *pfn =__gfn_to_pfn_memslot (slot, gfn, false,NULL , write, writable, hva); - +return false; out_retry: *r =RET_PF_RETRY ;return true;
Ouch! Queued, thanks.
Paolo