Skip to contentSkip to conversation

tests/i915/kms_mmap_write_crc : Create dynamic subtests

PATCH New Mohammed Thasleem 2 participants 2 messages Apr 25, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/i915/kms_mmap_write_crc : Create dynamic subtests

Create dynamic subtests with valid crtc/connector combinations.

---
 tests/i915/kms_mmap_write_crc.c | 38 +++++++++++++++------------------
 1 file changed, 17 insertions(+), 21 deletions(-)
tests/i915/kms_mmap_write_crc.c +17 -21
index f8825284..680aaf11 100644
@@ -215,23 +215,9 @@ static void cleanup_crtc(data_t *data)
 
 static void run_test(data_t *data)
 {
-	igt_display_t *display = &data->display;
-	igt_output_t *output;
-	enum pipe pipe;
-
-	for_each_pipe_with_valid_output(display, pipe, output) {
-		data->output = output;
-		data->pipe = pipe;
-
-		prepare_crtc(data);
-		test(data);
-		cleanup_crtc(data);
-
-		/* once is enough */
-		return;
-	}
-
-	igt_skip("no valid crtc/connector combinations found\n");
+	prepare_crtc(data);
+	test(data);
+	cleanup_crtc(data);
 }
 
 struct igt_helper_process hog;
@@ -272,6 +258,8 @@ static data_t data;
 igt_main_args("n", NULL, NULL, opt_handler, NULL)
 {
 	int i;
+	igt_output_t *output;
+	enum pipe pipe;
 
 	igt_fixture {
 		data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
@@ -288,10 +276,18 @@ igt_main_args("n", NULL, NULL, opt_handler, NULL)
 	}
 
 	igt_describe("Tests that caching mode has become UC/WT and flushed using mmap write");
-	igt_subtest("main") {
-		igt_info("Using %d rounds for the test\n", ROUNDS);
-		for (i = 0; i < ROUNDS; i++)
-			run_test(&data);
+	igt_info("Using %d rounds for each pipe in the test\n", ROUNDS);
+
+	igt_subtest_with_dynamic("main") {
+		for_each_pipe_with_valid_output(&data.display, pipe, output) {
+			igt_dynamic_f("%s-pipe-%s", igt_output_name(output),
+					kmstest_pipe_name(pipe)) {
+				data.output = output;
+				data.pipe = pipe;
+				for (i = 0; i < ROUNDS; i++)
+					run_test(&data);
+			}
+		}
 	}
 
 	igt_fixture {
Signature · 1 line
2.25.1
#1 lore raw

[igt-dev] ✗ Fi.CI.BAT: failure for tests/i915/kms_mmap_write_crc : Create dynamic subtests

== Series Details ==

== Series Details ==

Series: tests/i915/kms_mmap_write_crc : Create dynamic subtests
URL : https://patchwork.freedesktop.org/series/103065/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11550 -> IGTPW_6993
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6993 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6993, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/index.html

Participating hosts (43 -> 45)
------------------------------

Additional (3): bat-dg2-8 bat-adlm-1 bat-dg1-6
Missing (1): fi-bsw-cyan

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6993:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s0@smem:
- bat-dg1-6: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/bat-dg1-6/igt@gem_exec_suspend@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@i915_selftest@live@hugepages:
- {bat-rpls-1}: [DMESG-WARN][2] ([i915#5278]) -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/bat-rpls-1/igt@i915_selftest@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/bat-rpls-1/igt@i915_selftest@[email protected]

Known issues
------------

Here are the changes found in IGTPW_6993 that come from known issues:

### IGT changes ###

#### Possible fixes ####

* igt@i915_selftest@live@gt_heartbeat:
- fi-cfl-guc: [DMESG-FAIL][4] ([i915#5334]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-cfl-guc/igt@i915_selftest@live@gt_heartbeat.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/fi-cfl-guc/igt@i915_selftest@live@gt_heartbeat.html

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][6] ([i915#4785]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/fi-hsw-4770/igt@i915_selftest@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/fi-hsw-4770/igt@i915_selftest@[email protected]

* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][8] ([i915#3576]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11550/bat-adlp-6/igt@kms_busy@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/bat-adlp-6/igt@kms_busy@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5270]: https://gitlab.freedesktop.org/drm/intel/issues/5270
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5275]: https://gitlab.freedesktop.org/drm/intel/issues/5275
[i915#5278]: https://gitlab.freedesktop.org/drm/intel/issues/5278
[i915#5329]: https://gitlab.freedesktop.org/drm/intel/issues/5329
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5356]: https://gitlab.freedesktop.org/drm/intel/issues/5356
[i915#5537]: https://gitlab.freedesktop.org/drm/intel/issues/5537
[i915#5607]: https://gitlab.freedesktop.org/drm/intel/issues/5607
[i915#5763]: https://gitlab.freedesktop.org/drm/intel/issues/5763

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6451 -> IGTPW_6993

CI-20190529: 20190529
CI_DRM_11550: 56b089ae03ef8ea8ab7f474eaa70367898891ef0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6993: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/index.html
IGT_6451: f055bd83bd831a938d639718c2359516224f15f9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6993/index.html