Add octal DTR support for Macronix flash
Subsystems (2)
v4 cover Add octal DTR support for Macronix flash
This series add support for Macronix octal DTR flash, add flag for Softreset with "INVERT" command extension type on boot and follow linux kernel to enable 4byte opcode when possible.
v4:
Add flag SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT to seperate command extension types.
Replace ifdef with CONFIG_IS_ENABLED and modify uncorrect descriptions.
v3:
Add flag SPI_NOR_CMD_EXT_INVERT to seperate command extension types. replace CONFIG_SPI_FLASH_MACRONIX with SPI_FLASH_MACRONIX_OCTAL for spi_nor_macronix_octal_dtr_enable function.
v2:
add ret checking for write enable in spi_nor_macronix_octal_dtr_enable function.
JaimeLiao (4):
mtd: spi-nor: macronix: add support for Macronix Octal
mtd: spi-nor-core: Adding different type of command extension in Soft
Reset
mtd: spi-nor-core: set 4byte opcode when possible
mtd: spi-nor-core: Add support for Macronix Octal flash
drivers/mtd/spi/Kconfig | 14 +++++ drivers/mtd/spi/spi-nor-core.c | 94 +++++++++++++++++++++++++++++++++- drivers/mtd/spi/spi-nor-ids.c | 22 +++++++- include/linux/mtd/spi-nor.h | 13 ++++- 4 files changed, 139 insertions(+), 4 deletions(-)
Signature · 1 line
2.17.1
PATCH v4 1/4 mtd: spi-nor: macronix: add support for Macronix Octal
Follow patch "f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding Macronix flash in Octal DTR mode.
Enable Octal DTR mode with 20 dummy cycles to allow running at the
maximum supported frequency.
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf
--- drivers/mtd/spi/Kconfig | 7 +++ drivers/mtd/spi/spi-nor-core.c | 83 ++++++++++++++++++++++++++++++++++ include/linux/mtd/spi-nor.h | 13 +++++- 3 files changed, 101 insertions(+), 2 deletions(-)
drivers/mtd/spi/Kconfig +7 -0
@@ -162,6 +162,13 @@ config SPI_FLASH_MACRONIX help Add support for various Macronix SPI flash chips (MX25Lxxx) +config SPI_FLASH_MACRONIX_OCTAL + bool "Macronix octal flash support" + depends on SPI_FLASH_MACRONIX + help + Add support for the Macronix octal flash. This is a separate config + because the fixup hooks octal enable for this flash. + config SPI_FLASH_SPANSION bool "Spansion SPI flash support" help
drivers/mtd/spi/spi-nor-core.c +83 -0
95 lines not on this page · raw message
include/linux/mtd/spi-nor.h +11 -2
@@ -116,8 +116,17 @@#define XSR_RDY BIT(7)/* Ready */ /* Used for Macronix and Winbond flashes. */ -#define SPINOR_OP_EN4B 0xb7/* Enter 4-byte mode */ -#define SPINOR_OP_EX4B 0xe9/* Exit 4-byte mode */ +#define SPINOR_OP_EN4B 0xb7/* Enter 4-byte mode */ +#define SPINOR_OP_EX4B 0xe9/* Exit 4-byte mode */ +#define SPINOR_OP_RD_CR2 0x71/* Read configuration register 2 */ +#define SPINOR_OP_WR_CR2 0x72/* Write configuration register 2 */ +#define SPINOR_OP_MXIC_DTR_RD 0xee/* Fast Read opcode in DTR mode */ +#define SPINOR_REG_MXIC_CR2_MODE 0x00000000/* For setting octal DTR mode */ +#define SPINOR_REG_MXIC_OPI_DTR_EN 0x2/* Enable Octal DTR */ +#define SPINOR_REG_MXIC_OPI_DTR_DIS 0x1/* Disable Octal DTR */ +#define SPINOR_REG_MXIC_CR2_DC 0x00000300/* For setting dummy cycles */ +#define SPINOR_REG_MXIC_DC_20 0x0/* Setting dummy cycles to 20 */ +#define MXIC_MAX_DC 20/* Maximum value of dummy cycles */ /* Used for Spansion flashes only. */ #define SPINOR_OP_BRWR 0x17/* Bank register write */
Signature · 1 line
2.17.1
Re: [PATCH v4 1/4] mtd: spi-nor: macronix: add support for Macronix Octal
Quoted 20 lines · JaimeLiao
Follow patch "
f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding Macronix flash in Octal DTR mode.Enable Octal DTR mode with 20 dummy cycles to allow running at the
maximum supported frequency.
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdfSigned-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++ drivers/mtd/spi/spi-nor-core.c | 83 ++++++++++++++++++++++++++++++++++ include/linux/mtd/spi-nor.h | 13 +++++- 3 files changed, 101 insertions(+), 2 deletions(-)drivers/mtd/spi/Kconfig +0
-0
drivers/mtd/spi/Kconfig config SPI_FLASH_MACRONIX · line 165
Quoted 4 lines
drivers/mtd/spi/Kconfig +1
-0@@ -162,6 +162,13 @@ config SPI_FLASH_MACRONIX help Add support for various Macronix SPI flash chips (MX25Lxxx) +config SPI_FLASH_MACRONIX_OCTAL
What if we use exiting SPI_FLASH_MACRONIX for it? does it increasing size much? if not go for exiting macro.
Re: [PATCH v4 1/4] mtd: spi-nor: macronix: add support for Macronix Octal
Hi Jagan
Quoted 25 lines · JaimeLiao
Quoted 23 lines
Follow patch "
f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding Macronix flash in Octal DTR mode.Enable Octal DTR mode with 20 dummy cycles to allow running at the
maximum supported frequency.
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdfSigned-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++ drivers/mtd/spi/spi-nor-core.c | 83 ++++++++++++++++++++++++++++++++++ include/linux/mtd/spi-nor.h | 13 +++++- 3 files changed, 101 insertions(+), 2 deletions(-)drivers/mtd/spi/Kconfig +0
-0@@ -162,6 +162,13 @@ config SPI_FLASH_MACRONIX help Add support for various Macronix SPI flash chips (MX25Lxxx)
Quoted 4 lines
drivers/mtd/spi/Kconfig config SPI_FLASH_MACRONIX · line 165
Quoted 1 line
drivers/mtd/spi/Kconfig +1
-0+config SPI_FLASH_MACRONIX_OCTALWhat if we use exiting
SPI_FLASH_MACRONIXfor it? does it increasing size much? if not go for exiting macro.
I want to seperate SPI_FLASH_MACRONIX and SPI_FLASH_MACRONIX_OCTAL for enabling Macronix octal support.
Refer to your suggestions, checking SPI_FLASH_MACRONIX and other configuration which means octal enable is better.
But I didn't found the existing configuration means "octal enable". It would be great if you can recommend the suitable configuration set for nor->fixups hooks macronix_octal_fixups.
I will have v5 patchwork with the configuration checking.
Thanks
Jaime
Re: [PATCH v4 1/4] mtd: spi-nor: macronix: add support for Macronix Octal
Quoted 33 lines · liao jaime
Hi Jagan
Quoted 25 lines · JaimeLiao
Quoted 23 lines
Follow patch "
f6adec1af4b2f5d3012480c6cdce7743b74a6156" for adding Macronix flash in Octal DTR mode.Enable Octal DTR mode with 20 dummy cycles to allow running at the
maximum supported frequency.
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdfSigned-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++ drivers/mtd/spi/spi-nor-core.c | 83 ++++++++++++++++++++++++++++++++++ include/linux/mtd/spi-nor.h | 13 +++++- 3 files changed, 101 insertions(+), 2 deletions(-)drivers/mtd/spi/Kconfig +0
-0@@ -162,6 +162,13 @@ config SPI_FLASH_MACRONIX help Add support for various Macronix SPI flash chips (MX25Lxxx)Quoted 4 lines
drivers/mtd/spi/Kconfig config SPI_FLASH_MACRONIX · line 165
Quoted 1 line
drivers/mtd/spi/Kconfig +1
-0+config SPI_FLASH_MACRONIX_OCTALWhat if we use exiting
SPI_FLASH_MACRONIXfor it? does it increasing size much? if not go for exiting macro.
Quoted 8 lines
I want to seperate
SPI_FLASH_MACRONIXandSPI_FLASH_MACRONIX_OCTALfor enabling Macronix octal support.
Refer to your suggestions, checkingSPI_FLASH_MACRONIXand other configuration which means octal enable is better.
But I didn't found the existing configuration means "octal enable". It would be great if you can recommend the suitable configuration set fornor->fixupshooksmacronix_octal_fixups.
I will have v5 patchwork with the configuration checking.
My suggestion is go with existing Macronix config, if we keep adding octal specific configs for each flash it will increase configs.
Jagan.
PATCH v4 2/4 mtd: spi-nor-core: Adding different type of command extension in Soft Reset
In reply to JaimeLiaoPower-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe.
Command extension type is not standardized across flash vendors in DTR mode.
For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.
--- drivers/mtd/spi/Kconfig | 7 +++++++ drivers/mtd/spi/spi-nor-core.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-)
drivers/mtd/spi/Kconfig +7 -0
@@ -97,6 +97,13 @@ config SPI_FLASH_SMART_HWCAPS can support a type of operation in a much more refined way compared to using flags like SPI_RX_DUAL, SPI_TX_QUAD, etc. +config SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT + bool "Command extension type is INVERT for Software Reset on boot" + default n + help + Because of SFDP information can not be get before boot. + So define command extension type is INVERT when Software Reset on boot only. + config SPI_FLASH_SOFT_RESET bool "Software Reset support for SPI NOR flashes" default n
drivers/mtd/spi/spi-nor-core.c +6 -1
@@ -3661,7 +3661,12 @@ static int spi_nor_soft_reset(struct spi_nor *nor)enum spi_nor_cmd_ext ext; ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +if (nor->cmd_ext_type ==SPI_NOR_EXT_NONE ) { + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +#if CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT ) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +#endif /* SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT */ + } op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRSTEN, 0), SPI_MEM_OP_NO_DUMMY,
Signature · 1 line
2.17.1
Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset
Quoted 38 lines · JaimeLiao
Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe.
Command extension type is not standardized across flash vendors in DTR mode.
For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++++++ drivers/mtd/spi/spi-nor-core.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-)drivers/mtd/spi/Kconfig +7
-0@@ -97,6 +97,13 @@ config SPI_FLASH_SMART_HWCAPS can support a type of operation in a much more refined way compared to using flags like SPI_RX_DUAL, SPI_TX_QUAD, etc. +config SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT + bool "Command extension type is INVERT for Software Reset on boot" + default n + help + Because of SFDP information can not be get before boot. + So define command extension type is INVERT when Software Reset on boot only. + config SPI_FLASH_SOFT_RESET bool "Software Reset support for SPI NOR flashes" default ndrivers/mtd/spi/spi-nor-core.c +0
-0
drivers/mtd/spi/spi-nor-core.c static int spi_nor_soft_reset(struct spi_nor *nor) · line 3668
Quoted 9 lines
drivers/mtd/spi/spi-nor-core.c +5
-1@@ -3661,7 +3661,12 @@ static int spi_nor_soft_reset(struct spi_nor *nor)enum spi_nor_cmd_ext ext; ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +if (nor->cmd_ext_type ==SPI_NOR_EXT_NONE ) { + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +#if CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT ) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +#endif /* SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT */
I think we can get the SPI_NOR_EXT_INVERT by parsing bfpt, can you try it that way instead of new macro?
Jagan.
Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset
Quoted 41 lines · Jagan Teki
Quoted 40 lines · JaimeLiao
Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe.
Command extension type is not standardized across flash vendors in DTR mode.
For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++++++ drivers/mtd/spi/spi-nor-core.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-)drivers/mtd/spi/Kconfig +7
-0@@ -97,6 +97,13 @@ config SPI_FLASH_SMART_HWCAPS can support a type of operation in a much more refined way compared to using flags like SPI_RX_DUAL, SPI_TX_QUAD, etc. +config SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT + bool "Command extension type is INVERT for Software Reset on boot" + default n + help + Because of SFDP information can not be get before boot. + So define command extension type is INVERT when Software Reset on boot only. + config SPI_FLASH_SOFT_RESET bool "Software Reset support for SPI NOR flashes" default ndrivers/mtd/spi/spi-nor-core.c +0
-0@@ -3661,7 +3661,12 @@ static int spi_nor_soft_reset(struct spi_nor *nor)enum spi_nor_cmd_ext ext;
Quoted 10 lines
drivers/mtd/spi/spi-nor-core.c static int spi_nor_soft_reset(struct spi_nor *nor) · line 3668
Quoted 7 lines
drivers/mtd/spi/spi-nor-core.c +5
-1ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +if (nor->cmd_ext_type ==SPI_NOR_EXT_NONE ) { + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +#if CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT ) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +#endif /* SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT */ I think we can get the
SPI_NOR_EXT_INVERTby parsing bfpt, can you try it that way instead of new macro?
The problem is that for OSPI boot mode the ROM can often leave the flash in 8D-8D-8D mode. So when U-Boot first starts executing the flash is already in 8D-8D-8D mode and there is no easy and reliable way to detect this mode. So we must blindly perform a soft reset before probing the flash and reading SFDP so that it is reset back to a usable state.
This is why we can't detect the extension via BFPT since the flash is in an unknown state. This is not the case when resetting before booting the OS since at that point we have fully probed the flash. So I think this config must only be used for the reset at boot time. For later resets we should indeed use the extension provided by BFPT.
This is a kinda hacky but I can't come up with a better alternative.
Jamie,
Below diff is what I have been suggesting you in my earlier replies. Note that this is just a quick and dirty implementation, I have not tested this at all. That is up to you to do. Please also test soft reset _after_ the probe is finished so we know that it works correctly when using data from BFPT as well.
-- 8< --
drivers/mtd/spi/spi-nor-core.c +43 -35
@@ -3616,10 +3616,6 @@ static int spi_nor_soft_reset(struct spi_nor *nor) {struct spi_mem_op op;int ret; -enum spi_nor_cmd_ext ext; - - ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRSTEN, 0), SPI_MEM_OP_NO_DUMMY,
@@ -3629,7 +3625,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor) ret =spi_mem_exec_op (nor->spi, &op);if (ret) {dev_warn (nor->dev,"Software reset enable failed: %d\n" , ret); - goto out; +return ret; } op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRST, 0),
@@ -3640,7 +3636,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor) ret =spi_mem_exec_op (nor->spi, &op);if (ret) {dev_warn (nor->dev,"Software reset failed: %d\n" , ret); - goto out; +return ret; }/*
@@ -3650,9 +3646,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor)*/ udelay (SPI_NOR_SRST_SLEEP_LEN ); -out: - nor->cmd_ext_type = ext; - return ret; + return 0; }#endif /* CONFIG_SPI_FLASH_SOFT_RESET */
@@ -3698,6 +3692,44 @@ void spi_nor_set_fixups(struct spi_nor *nor)#endif } +/* +* When the flash is handed to us in a stateful mode like 8D-8D-8D, it is +* difficult to detect the mode the flash is in. One option is to read SFDP in +* all modes and see which one gives the correct "SFDP" signature, but not all +* flashes support SFDP in 8D-8D-8D mode. +* +* Further, even if you detect the mode of the flash via SFDP, you still have +* the problem of actually reading the ID. The Read ID command is not +* standardized across flash vendors. Flashes can have different dummy cycles +* needed for reading the ID. Some flashes even expect a 4-byte dummy address +* with the Read ID command. All this information cannot be obtained from the +* SFDP table. +* +* So, perform a Software Reset sequence before reading the ID and initializing +* the flash. A Soft Reset will bring back the flash in its default protocol +* mode assuming no non-volatile configuration was set. This will let us detect +* the flash even if ROM hands it to us in Octal DTR mode. +* +* To accommodate cases where there is more than one flash on a board, and only +* one of them needs a soft reset, failure to reset is not made fatal, and we +* still try to read ID if possible. +*/ +static void spi_nor_soft_reset_on_boot (struct spi_nor *nor) +{ +enum spi_nor_cmd_ext ext; + + ext = nor->cmd_ext_type; + +if (CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT )) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +else + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; + +spi_nor_soft_reset (nor); + + nor->cmd_ext_type = ext; +} +int spi_nor_scan (struct spi_nor *nor) {struct spi_nor_flash_parameter params;
@@ -3722,32 +3754,8 @@ int spi_nor_scan(struct spi_nor *nor) nor->setup = spi_nor_default_setup; -#ifdef CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT -/* -* When the flash is handed to us in a stateful mode like 8D-8D-8D, it -* is difficult to detect the mode the flash is in. One option is to -* read SFDP in all modes and see which one gives the correct "SFDP" -* signature, but not all flashes support SFDP in 8D-8D-8D mode. -* -* Further, even if you detect the mode of the flash via SFDP, you -* still have the problem of actually reading the ID. The Read ID -* command is not standardized across flash vendors. Flashes can have -* different dummy cycles needed for reading the ID. Some flashes even -* expect a 4-byte dummy address with the Read ID command. All this -* information cannot be obtained from the SFDP table. -* -* So, perform a Software Reset sequence before reading the ID and -* initializing the flash. A Soft Reset will bring back the flash in -* its default protocol mode assuming no non-volatile configuration was -* set. This will let us detect the flash even if ROM hands it to us in -* Octal DTR mode. -* -* To accommodate cases where there is more than one flash on a board, -* and only one of them needs a soft reset, failure to reset is not -* made fatal, and we still try to read ID if possible. -*/ -spi_nor_soft_reset (nor); -#endif /* CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT */ +if (CONFIG_IS_ENABLED (SPI_FLASH_SOFT_RESET_ON_BOOT )) +spi_nor_soft_reset_on_boot (nor); info =spi_nor_read_id (nor);if (IS_ERR_OR_NULL (info))
Signature · 3 lines
Regards, Pratyush Yadav Texas Instruments Inc.
Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset
For validating soft_reset after probe, I have test it on my side. It is working with command extension type which got from BFPT.
Pratyush Yadav <[email protected]> 於 2021年10月26日 週二 上午3:42寫道:
Quoted 239 lines · Jagan Teki
Quoted 1 line
On Mon, Oct 18, 2021 at 11:54 AM JaimeLiao <[email protected]>
Quoted 2 lines · wrote:
Quoted 2 lines
Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from
8D-8D-8D
Quoted 3 lines
Quoted 3 lines
in the begging of probe.
Command extension type is not standardized across flash vendors in DTR
mode.
Quoted 2 lines
Quoted 2 lines
For suiting different vendor flash devices, adding a flag to seperate
types for
Quoted 8 lines
Quoted 8 lines
soft reset on boot.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++++++ drivers/mtd/spi/spi-nor-core.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-)Quoted 6 lines
drivers/mtd/spi/Kconfig config SPI_FLASH_SMART_HWCAPS · line 97
Quoted 6 lines
drivers/mtd/spi/Kconfig +0
-0@@ -97,6 +97,13 @@ config SPI_FLASH_SMART_HWCAPS can support a type of operation in a much more refined waycompared
Quoted 4 lines
drivers/mtd/spi/Kconfig config SPI_FLASH_SMART_HWCAPS · line 101
Quoted 4 lines
drivers/mtd/spi/Kconfig +2
-0to using flags like SPI_RX_DUAL, SPI_TX_QUAD, etc. +config SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT + bool "Command extension type is INVERT for Software Reset onboot"
Quoted 4 lines
drivers/mtd/spi/Kconfig config SPI_FLASH_SMART_HWCAPS · line 105
Quoted 4 lines
drivers/mtd/spi/Kconfig +4
-0+ default n + help + Because of SFDP information can not be get before boot. + So define command extension type is INVERT when SoftwareReset on boot only.
Quoted 5 lines
Review
Quoted 5 lines
drivers/mtd/spi/Kconfig +1
-0+ config SPI_FLASH_SOFT_RESET bool "Software Reset support for SPI NOR flashes" default n(quoted diff) +0
-0
b/drivers/mtd/spi/spi-nor-core.cQuoted 4 lines
drivers/mtd/spi/spi-nor-core.c static int spi_nor_soft_reset(struct spi_nor
Quoted 4 lines
index
fdaca0a0d3..87a7de7d60100644drivers/mtd/spi/spi-nor-core.c +0
-0@@ -3661,7 +3661,12 @@ static int spi_nor_soft_reset(struct spi_nor*nor)
Quoted 12 lines
drivers/mtd/spi/spi-nor-core.c static int spi_nor_soft_reset(struct spi_nor · line 3668
Quoted 9 lines
drivers/mtd/spi/spi-nor-core.c +5
-1enum spi_nor_cmd_ext ext; ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +if (nor->cmd_ext_type ==SPI_NOR_EXT_NONE ) { + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +#if CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT ) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +#endif /* SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT */ I think we can get the
SPI_NOR_EXT_INVERTby parsing bfpt, can you try it that way instead of new macro?The problem is that for OSPI boot mode the ROM can often leave the flash in 8D-8D-8D mode. So when U-Boot first starts executing the flash is already in 8D-8D-8D mode and there is no easy and reliable way to detect this mode. So we must blindly perform a soft reset before probing the flash and reading SFDP so that it is reset back to a usable state.
This is why we can't detect the extension via BFPT since the flash is in an unknown state. This is not the case when resetting before booting the OS since at that point we have fully probed the flash. So I think this config must only be used for the reset at boot time. For later resets we should indeed use the extension provided by BFPT.
This is a kinda hacky but I can't come up with a better alternative.
Jamie,
Below diff is what I have been suggesting you in my earlier replies. Note that this is just a quick and dirty implementation, I have not tested this at all. That is up to you to do. Please also test soft reset _after_ the probe is finished so we know that it works correctly when using data from BFPT as well.
-- 8< --
drivers/mtd/spi/spi-nor-core.c +0
-4@@ -3616,10 +3616,6 @@ static int spi_nor_soft_reset(struct spi_nor *nor) {struct spi_mem_op op;int ret; -enum spi_nor_cmd_ext ext; - - ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRSTEN, 0),
SPI_MEM_OP_NO_DUMMY,drivers/mtd/spi/spi-nor-core.c +1
-1@@ -3629,7 +3625,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor) ret =spi_mem_exec_op (nor->spi, &op);if (ret) {dev_warn (nor->dev,"Software reset enable failed: %d\n" , ret); - goto out; +return ret; }op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRST,
0),drivers/mtd/spi/spi-nor-core.c +5
-4@@ -3640,7 +3636,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor) ret =spi_mem_exec_op (nor->spi, &op);if (ret) {dev_warn (nor->dev,"Software reset failed: %d\n" , ret); - goto out; +return ret; }/* @@ -3650,9 +3646,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor)*/ udelay (SPI_NOR_SRST_SLEEP_LEN ); -out: - nor->cmd_ext_type = ext; - return ret; + return 0; }#endif /* CONFIG_SPI_FLASH_SOFT_RESET */ @@ -3698,6 +3692,44 @@ void spi_nor_set_fixups(struct spi_nor *nor)#endif } +/* +* When the flash is handed to us in a stateful mode like 8D-8D-8D, it is +* difficult to detect the mode the flash is in. One option is to read SFDP in
+ * all modes and see which one gives the correct "SFDP" signature, but not all
+ * flashes support SFDP in 8D-8D-8D mode.
+ *
+ * Further, even if you detect the mode of the flash via SFDP, you still have
+ * the problem of actually reading the ID. The Read ID command is not
+ * standardized across flash vendors. Flashes can have different dummy cycles
+ * needed for reading the ID. Some flashes even expect a 4-byte dummy address
+ * with the Read ID command. All this information cannot be obtained from the
+ * SFDP table.
+ *
+ * So, perform a Software Reset sequence before reading the ID and initializing
+ * the flash. A Soft Reset will bring back the flash in its default protocol
+ * mode assuming no non-volatile configuration was set. This will let us detect
+ * the flash even if ROM hands it to us in Octal DTR mode.
+ *
+ * To accommodate cases where there is more than one flash on a board, and only
+ * one of them needs a soft reset, failure to reset is not made fatal, and we
+ * still try to read ID if possible.
+ */drivers/mtd/spi/spi-nor-core.c +16
-3+static void spi_nor_soft_reset_on_boot (struct spi_nor *nor) +{ +enum spi_nor_cmd_ext ext; + + ext = nor->cmd_ext_type; + +if (CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT )) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +else + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; + +spi_nor_soft_reset (nor); + + nor->cmd_ext_type = ext; +} +int spi_nor_scan (struct spi_nor *nor) {struct spi_nor_flash_parameter params;@@ -3722,32 +3754,8 @@ int spi_nor_scan(struct spi_nor *nor) nor->setup = spi_nor_default_setup; -#ifdef CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT -/* -* When the flash is handed to us in a stateful mode like 8D-8D-8D, it
- * is difficult to detect the mode the flash is in. One option is
to
- * read SFDP in all modes and see which one gives the correct
"SFDP"drivers/mtd/spi/spi-nor-core.c +0
-5-* signature, but not all flashes support SFDP in 8D-8D-8D mode. -* -* Further, even if you detect the mode of the flash via SFDP, you -* still have the problem of actually reading the ID. The Read ID -* command is not standardized across flash vendors. Flashes can have
- * different dummy cycles needed for reading the ID. Some flashes
evendrivers/mtd/spi/spi-nor-core.c +0
-5-* expect a 4-byte dummy address with the Read ID command. All this -* information cannot be obtained from the SFDP table. -* -* So, perform a Software Reset sequence before reading the ID and -* initializing the flash. A Soft Reset will bring back the flash in
- * its default protocol mode assuming no non-volatile
configuration was
- * set. This will let us detect the flash even if ROM hands it to
us indrivers/mtd/spi/spi-nor-core.c +0
-3-* Octal DTR mode. -* -* To accommodate cases where there is more than one flash on a board,
drivers/mtd/spi/spi-nor-core.c +2
-6-* and only one of them needs a soft reset, failure to reset is not -* made fatal, and we still try to read ID if possible. -*/ -spi_nor_soft_reset (nor); -#endif /* CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT */ +if (CONFIG_IS_ENABLED (SPI_FLASH_SOFT_RESET_ON_BOOT )) +spi_nor_soft_reset_on_boot (nor); info =spi_nor_read_id (nor);if (IS_ERR_OR_NULL (info)) --Regards,
Pratyush Yadav
Texas Instruments Inc.
Re: [PATCH v4 2/4] mtd: spi-nor-core: Adding different type of command extension in Soft Reset
In reply to Pratyush YadavQuoted 193 lines · Jagan Teki
Quoted 41 lines · JaimeLiao
Quoted 40 lines
Power-on-Reset is a method to restore flash back to 1S-1S-1S mode from 8D-8D-8D in the begging of probe.
Command extension type is not standardized across flash vendors in DTR mode.
For suiting different vendor flash devices, adding a flag to seperate types for soft reset on boot.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/Kconfig | 7 +++++++ drivers/mtd/spi/spi-nor-core.c | 7 ++++++- 2 files changed, 13 insertions(+), 1 deletion(-)drivers/mtd/spi/Kconfig +7
-0@@ -97,6 +97,13 @@ config SPI_FLASH_SMART_HWCAPS can support a type of operation in a much more refined way compared to using flags like SPI_RX_DUAL, SPI_TX_QUAD, etc. +config SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT + bool "Command extension type is INVERT for Software Reset on boot" + default n + help + Because of SFDP information can not be get before boot. + So define command extension type is INVERT when Software Reset on boot only. + config SPI_FLASH_SOFT_RESET bool "Software Reset support for SPI NOR flashes" default ndrivers/mtd/spi/spi-nor-core.c +0
-0@@ -3661,7 +3661,12 @@ static int spi_nor_soft_reset(struct spi_nor *nor)enum spi_nor_cmd_ext ext;Quoted 10 lines
drivers/mtd/spi/spi-nor-core.c static int spi_nor_soft_reset(struct spi_nor *nor) · line 3668
Quoted 7 lines
drivers/mtd/spi/spi-nor-core.c +5
-1ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +if (nor->cmd_ext_type ==SPI_NOR_EXT_NONE ) { + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; +#if CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT ) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +#endif /* SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT */ I think we can get the
SPI_NOR_EXT_INVERTby parsing bfpt, can you try it that way instead of new macro?The problem is that for OSPI boot mode the ROM can often leave the flash in 8D-8D-8D mode. So when U-Boot first starts executing the flash is already in 8D-8D-8D mode and there is no easy and reliable way to detect this mode. So we must blindly perform a soft reset before probing the flash and reading SFDP so that it is reset back to a usable state.
This is why we can't detect the extension via BFPT since the flash is in an unknown state. This is not the case when resetting before booting the OS since at that point we have fully probed the flash. So I think this config must only be used for the reset at boot time. For later resets we should indeed use the extension provided by BFPT.
This is a kinda hacky but I can't come up with a better alternative.
Jamie,
Below diff is what I have been suggesting you in my earlier replies. Note that this is just a quick and dirty implementation, I have not tested this at all. That is up to you to do. Please also test soft reset _after_ the probe is finished so we know that it works correctly when using data from BFPT as well.
-- 8< --
drivers/mtd/spi/spi-nor-core.c +41
-32@@ -3616,10 +3616,6 @@ static int spi_nor_soft_reset(struct spi_nor *nor) {struct spi_mem_op op;int ret; -enum spi_nor_cmd_ext ext; - - ext = nor->cmd_ext_type; - nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRSTEN, 0), SPI_MEM_OP_NO_DUMMY,@@ -3629,7 +3625,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor) ret =spi_mem_exec_op (nor->spi, &op);if (ret) {dev_warn (nor->dev,"Software reset enable failed: %d\n" , ret); - goto out; +return ret; } op = (struct spi_mem_op)SPI_MEM_OP(SPI_MEM_OP_CMD(SPINOR_OP_SRST, 0),@@ -3640,7 +3636,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor) ret =spi_mem_exec_op (nor->spi, &op);if (ret) {dev_warn (nor->dev,"Software reset failed: %d\n" , ret); - goto out; +return ret; }/* @@ -3650,9 +3646,7 @@ static int spi_nor_soft_reset(struct spi_nor *nor)*/ udelay (SPI_NOR_SRST_SLEEP_LEN ); -out: - nor->cmd_ext_type = ext; - return ret; + return 0; }#endif /* CONFIG_SPI_FLASH_SOFT_RESET */ @@ -3698,6 +3692,44 @@ void spi_nor_set_fixups(struct spi_nor *nor)#endif } +/* +* When the flash is handed to us in a stateful mode like 8D-8D-8D, it is +* difficult to detect the mode the flash is in. One option is to read SFDP in +* all modes and see which one gives the correct "SFDP" signature, but not all +* flashes support SFDP in 8D-8D-8D mode. +* +* Further, even if you detect the mode of the flash via SFDP, you still have +* the problem of actually reading the ID. The Read ID command is not +* standardized across flash vendors. Flashes can have different dummy cycles +* needed for reading the ID. Some flashes even expect a 4-byte dummy address +* with the Read ID command. All this information cannot be obtained from the +* SFDP table. +* +* So, perform a Software Reset sequence before reading the ID and initializing +* the flash. A Soft Reset will bring back the flash in its default protocol +* mode assuming no non-volatile configuration was set. This will let us detect +* the flash even if ROM hands it to us in Octal DTR mode. +* +* To accommodate cases where there is more than one flash on a board, and only +* one of them needs a soft reset, failure to reset is not made fatal, and we +* still try to read ID if possible. +*/ +static void spi_nor_soft_reset_on_boot (struct spi_nor *nor) +{ +enum spi_nor_cmd_ext ext; + + ext = nor->cmd_ext_type; + +if (CONFIG_IS_ENABLED (SPI_NOR_BOOT_SOFT_RESET_EXT_INVERT )) + nor->cmd_ext_type =SPI_NOR_EXT_INVERT ; +else + nor->cmd_ext_type =SPI_NOR_EXT_REPEAT ; + +spi_nor_soft_reset (nor); + + nor->cmd_ext_type = ext; +} +int spi_nor_scan (struct spi_nor *nor) {struct spi_nor_flash_parameter params;@@ -3722,32 +3754,8 @@ int spi_nor_scan(struct spi_nor *nor) nor->setup = spi_nor_default_setup; -#ifdef CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT -/* -* When the flash is handed to us in a stateful mode like 8D-8D-8D, it -* is difficult to detect the mode the flash is in. One option is to -* read SFDP in all modes and see which one gives the correct "SFDP" -* signature, but not all flashes support SFDP in 8D-8D-8D mode. -* -* Further, even if you detect the mode of the flash via SFDP, you -* still have the problem of actually reading the ID. The Read ID -* command is not standardized across flash vendors. Flashes can have -* different dummy cycles needed for reading the ID. Some flashes even -* expect a 4-byte dummy address with the Read ID command. All this -* information cannot be obtained from the SFDP table. -* -* So, perform a Software Reset sequence before reading the ID and -* initializing the flash. A Soft Reset will bring back the flash in -* its default protocol mode assuming no non-volatile configuration was -* set. This will let us detect the flash even if ROM hands it to us in -* Octal DTR mode. -* -* To accommodate cases where there is more than one flash on a board, -* and only one of them needs a soft reset, failure to reset is not -* made fatal, and we still try to read ID if possible.
drivers/mtd/spi/spi-nor-core.c int spi_nor_scan(struct spi_nor *nor)
Quoted 10 lines
drivers/mtd/spi/spi-nor-core.c +2
-4-*/ -spi_nor_soft_reset (nor); -#endif /* CONFIG_SPI_FLASH_SOFT_RESET_ON_BOOT */ +if (CONFIG_IS_ENABLED (SPI_FLASH_SOFT_RESET_ON_BOOT )) +spi_nor_soft_reset_on_boot (nor); info =spi_nor_read_id (nor);if (IS_ERR_OR_NULL (info)) --
For validating soft_reset after probe, I have test it on my side. It is working with command extension type which got from BFPT.
Quoted 3 lines
Regards,
Pratyush Yadav
Texas Instruments Inc.
PATCH v4 3/4 mtd: spi-nor-core: set 4byte opcode when possible
In reply to JaimeLiaoFollowing linux kernel to check address width and 4byte flag to enable 4byte opcode setting.
--- drivers/mtd/spi/spi-nor-core.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/mtd/spi/spi-nor-core.c +4 -0
@@ -3902,6 +3902,10 @@ int spi_nor_scan(struct spi_nor *nor)return -EINVAL ; } +/* Set 4byte opcodes when possible. */ +if (nor->addr_width ==4 && info->flags &SPI_NOR_4B_OPCODES ) +spi_nor_set_4byte_opcodes (nor, info); +/* Send all the required SPI flash commands to initialize device */ ret =spi_nor_init (nor);if (ret)
Signature · 1 line
2.17.1
Re: [PATCH v4 3/4] mtd: spi-nor-core: set 4byte opcode when possible
Quoted 13 lines · JaimeLiao
Following linux kernel to check address width and 4byte flag to enable 4byte opcode setting.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/spi-nor-core.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/mtd/spi/spi-nor-core.c +0
-0
drivers/mtd/spi/spi-nor-core.c int spi_nor_scan(struct spi_nor *nor) · line 3908
Quoted 7 lines
drivers/mtd/spi/spi-nor-core.c +4
-0@@ -3902,6 +3902,10 @@ int spi_nor_scan(struct spi_nor *nor)return -EINVAL ; } +/* Set 4byte opcodes when possible. */ +if (nor->addr_width ==4 && info->flags &SPI_NOR_4B_OPCODES ) +spi_nor_set_4byte_opcodes (nor, info); +
I still don't think this is the right thing to do. You should rework the previous check for SPI_NOR_4B_OPCODES to fit whatever your flash needs instead of adding it again.
Quoted 6 lines
drivers/mtd/spi/spi-nor-core.c +0
-0/* Send all the required SPI flash commands to initialize device */ ret =spi_nor_init (nor);if (ret)Signature · 1 line
2.17.1
Signature · 3 lines
Regards, Pratyush Yadav Texas Instruments Inc.
Re: [PATCH v4 3/4] mtd: spi-nor-core: set 4byte opcode when possible
Quoted 18 lines · JaimeLiao
Quoted 16 lines
Following linux kernel to check address width and 4byte flag to enable 4byte opcode setting.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/spi-nor-core.c | 4 ++++ 1 file changed, 4 insertions(+)drivers/mtd/spi/spi-nor-core.c +0
-0@@ -3902,6 +3902,10 @@ int spi_nor_scan(struct spi_nor *nor)return -EINVAL ; }
Quoted 8 lines
drivers/mtd/spi/spi-nor-core.c int spi_nor_scan(struct spi_nor *nor) · line 3908
Quoted 4 lines
drivers/mtd/spi/spi-nor-core.c +4
-0+/* Set 4byte opcodes when possible. */ +if (nor->addr_width ==4 && info->flags &SPI_NOR_4B_OPCODES ) +spi_nor_set_4byte_opcodes (nor, info); +I still don't think this is the right thing to do. You should rework the previous check for
SPI_NOR_4B_OPCODESto fit whatever your flash needs instead of adding it again.
You are right, 3 byte command can be accepted after SPINOR_OP_EN4B. I will remove this part in patch next revision.
Quoted 12 lines
Quoted 7 lines
drivers/mtd/spi/spi-nor-core.c +0
-1/* Send all the required SPI flash commands to initialize device */ ret =spi_nor_init (nor);if (ret) --2.17.1
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
PATCH v4 4/4 mtd: spi-nor-core: Add support for Macronix Octal flash
In reply to JaimeLiaoAdding Macronix Octal flash for Octal DTR support.
The octaflash series can be divided into the following types:
MX25 series : Serial NOR Flash.
MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW series : Support simultaneous Read-while-Write operation in multiple
bank architecture. Read-while-write feature which means read data one bank while another bank is programing or erasing.
MX25LM : 3.0V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf
MX25UM : 1.8V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdf
MX66LM : 3.0V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf
MX66UM : 1.8V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf
MX25LW : 3.0V Octal I/O with Read-while-Write MX25UW : 1.8V Octal I/O with Read-while-Write MX66LW : 3.0V Octal I/O with Read-while-Write and stack die MX66UW : 1.8V Octal I/O with Read-while-Write and stack die
About LW/UW series, please contact us freely if you have any questions. For adding Octal NOR Flash IDs, we have validated each Flash on plateform zynq-picozed.
--- drivers/mtd/spi/spi-nor-ids.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)
drivers/mtd/spi/spi-nor-ids.c +21 -1
@@ -169,7 +169,27 @@ const struct flash_info spi_nor_ids[] = { { INFO("mx66l1g45g", 0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("mx25l1633e", 0xc22415, 0, 64 * 1024, 32, SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | SECT_4K) }, { INFO("mx25r6435f", 0xc22817, 0, 64 * 1024, 128, SECT_4K) }, - { INFO("mx66uw2g345g", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw2g345gx0", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66lm1g45g", 0xc2853b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lm51245g", 0xc2853a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lw51245g", 0xc2863a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lm25645g", 0xc28539, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66um2g45g", 0xc2803c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw2g345g", 0xc2843c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66um1g45g", 0xc2803b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw1g45g", 0xc2813b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um51245g", 0xc2803a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw51245g", 0xc2813a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw51345g", 0xc2843a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um25645g", 0xc28039, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw25645g", 0xc28139, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um25345g", 0xc28339, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw25345g", 0xc28439, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12845g", 0xc28138, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12a45g", 0xc28938, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12345g", 0xc28438, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw6445g", 0xc28137, 0, 2 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw6345g", 0xc28437, 0, 2 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */
Signature · 1 line
2.17.1
Re: [PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash
Quoted 42 lines · JaimeLiao
Adding Macronix Octal flash for Octal DTR support.
The octaflash series can be divided into the following types:
MX25 series : Serial NOR Flash.
MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW series : Support simultaneous Read-while-Write operation in multiple
bank architecture. Read-while-write feature which means read data one bank while another bank is programing or erasing.MX25LM : 3.0V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdfMX25UM : 1.8V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdfMX66LM : 3.0V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdfMX66UM : 1.8V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdfMX25LW : 3.0V Octal I/O with Read-while-Write MX25UW : 1.8V Octal I/O with Read-while-Write MX66LW : 3.0V Octal I/O with Read-while-Write and stack die MX66UW : 1.8V Octal I/O with Read-while-Write and stack die
About LW/UW series, please contact us freely if you have any questions. For adding Octal NOR Flash IDs, we have validated each Flash on plateform zynq-picozed.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)drivers/mtd/spi/spi-nor-ids.c +0
-0
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 172
Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +1
-1@@ -169,7 +169,27 @@ const struct flash_info spi_nor_ids[] = { { INFO("mx66l1g45g", 0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("mx25l1633e", 0xc22415, 0, 64 * 1024, 32, SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | SECT_4K) }, { INFO("mx25r6435f", 0xc22817, 0, 64 * 1024, 128, SECT_4K) }, - { INFO("mx66uw2g345g", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw2g345gx0", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) },
Why are you changing the name of this flash?
Other than this, the patch looks good to me.
Quoted 26 lines
drivers/mtd/spi/spi-nor-ids.c +20
-0+ { INFO("mx66lm1g45g", 0xc2853b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lm51245g", 0xc2853a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lw51245g", 0xc2863a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lm25645g", 0xc28539, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66um2g45g", 0xc2803c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw2g345g", 0xc2843c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66um1g45g", 0xc2803b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw1g45g", 0xc2813b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um51245g", 0xc2803a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw51245g", 0xc2813a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw51345g", 0xc2843a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um25645g", 0xc28039, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw25645g", 0xc28139, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um25345g", 0xc28339, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw25345g", 0xc28439, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12845g", 0xc28138, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12a45g", 0xc28938, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12345g", 0xc28438, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw6445g", 0xc28137, 0, 2 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw6345g", 0xc28437, 0, 2 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */Signature · 1 line
2.17.1
Signature · 3 lines
Regards, Pratyush Yadav Texas Instruments Inc.
Re: [PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash
MX66UW2G345G is similar to MX66UW2G345GX0 and MX66UW2G345G's device ID is 0xc2843c actually.
So that I correct it and add MX66UW2G345GX0 in IDs table.
Pratyush Yadav <[email protected]> 於 2021年10月26日 週二 上午3:45寫道:
Quoted 116 lines · JaimeLiao
Quoted 8 lines
Adding Macronix Octal flash for Octal DTR support.
The octaflash series can be divided into the following types:
MX25 series : Serial NOR Flash.
MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW series : Support simultaneous Read-while-Write operation inmultiple
Quoted 1 line
bank architecture. Read-while-write feature which means
read
Quoted 4 lines
data one bank while another bank is programing or erasing.
MX25LM : 3.0V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdf
Quoted 3 lines
MX25UM : 1.8V Octal I/O
-Quoted 3 lines
MX66LM : 3.0V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdf
Quoted 3 lines
MX66UM : 1.8V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdf
Quoted 10 lines
MX25LW : 3.0V Octal I/O with Read-while-Write MX25UW : 1.8V Octal I/O with Read-while-Write MX66LW : 3.0V Octal I/O with Read-while-Write and stack die MX66UW : 1.8V Octal I/O with Read-while-Write and stack die
About LW/UW series, please contact us freely if you have any questions. For adding Octal NOR Flash IDs, we have validated each Flash on plateform zynq-picozed.
Review
Quoted 6 lines
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)(quoted diff) +0
-0
b/drivers/mtd/spi/spi-nor-ids.cdrivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 169
Quoted 5 lines
index
cb3a08872d..5c13ea3a78100644drivers/mtd/spi/spi-nor-ids.c +0
-0@@ -169,7 +169,27 @@ const struct flash_info spi_nor_ids[] = { { INFO("mx66l1g45g", 0xc2201b, 0, 64 * 1024, 2048, SECT_4K |
SPI_NOR_DUAL_READ|SPI_NOR_QUAD_READ) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 170
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +0
-0{ INFO("mx25l1633e", 0xc22415, 0, 64 * 1024, 32,
SPI_NOR_QUAD_READ|SPI_NOR_4B_OPCODES|SECT_4K) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 172
Quoted 2 lines
drivers/mtd/spi/spi-nor-ids.c +0
-1{ INFO("mx25r6435f", 0xc22817, 0, 64 * 1024, 128, SECT_4K) }, - { INFO("mx66uw2g345g", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 172
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx66uw2g345gx0", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },Why are you changing the name of this flash?
Other than this, the patch looks good to me.
drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 173
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx66lm1g45g", 0xc2853b, 0, 32 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 174
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25lm51245g", 0xc2853a, 0, 16 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 175
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25lw51245g", 0xc2863a, 0, 16 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 176
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25lm25645g", 0xc28539, 0, 8 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 177
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx66um2g45g", 0xc2803c, 0, 64 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 178
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx66uw2g345g", 0xc2843c, 0, 64 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 179
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx66um1g45g", 0xc2803b, 0, 32 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 180
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx66uw1g45g", 0xc2813b, 0, 32 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 181
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25um51245g", 0xc2803a, 0, 16 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 182
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw51245g", 0xc2813a, 0, 16 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 183
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw51345g", 0xc2843a, 0, 16 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 184
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25um25645g", 0xc28039, 0, 8 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 185
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw25645g", 0xc28139, 0, 8 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 186
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25um25345g", 0xc28339, 0, 8 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 187
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw25345g", 0xc28439, 0, 8 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 188
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw12845g", 0xc28138, 0, 4 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 189
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw12a45g", 0xc28938, 0, 4 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 190
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw12345g", 0xc28438, 0, 4 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 191
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw6445g", 0xc28137, 0, 2 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 192
Quoted 1 line
drivers/mtd/spi/spi-nor-ids.c +1
-0+ { INFO("mx25uw6345g", 0xc28437, 0, 2 * 1024, 4096, SECT_4K |
SPI_NOR_OCTAL_DTR_READ|SPI_NOR_4B_OPCODES) },Quoted 6 lines
drivers/mtd/spi/spi-nor-ids.c +0
-1#endif #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */ --2.17.1
--
Regards,
Pratyush Yadav
Texas Instruments Inc.
Re: [PATCH v4 4/4] mtd: spi-nor-core: Add support for Macronix Octal flash
In reply to Pratyush YadavQuoted 52 lines · JaimeLiao
Quoted 42 lines
Adding Macronix Octal flash for Octal DTR support.
The octaflash series can be divided into the following types:
MX25 series : Serial NOR Flash.
MX66 series : Serial NOR Flash with stacked die.(Size larger than 1Gb) LM/UM series : Up to 250MHz clock frequency with both DTR/STR operation. LW/UW series : Support simultaneous Read-while-Write operation in multiple
bank architecture. Read-while-write feature which means read data one bank while another bank is programing or erasing.MX25LM : 3.0V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7841/MX25LM51245G,%203V,%20512Mb,%20v1.1.pdfMX25UM : 1.8V Octal I/O
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7525/MX25UM51245G%20Extreme%20Speed,%201.8V,%20512Mb,%20v1.0.pdfMX66LM : 3.0V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7929/MX66LM1G45G,%203V,%201Gb,%20v1.1.pdfMX66UM : 1.8V Octal I/O with stacked die
-https://www.mxic.com.tw/Lists/Datasheet/Attachments/7721/MX66UM1G45G,%201.8V,%201Gb,%20v1.1.pdfMX25LW : 3.0V Octal I/O with Read-while-Write MX25UW : 1.8V Octal I/O with Read-while-Write MX66LW : 3.0V Octal I/O with Read-while-Write and stack die MX66UW : 1.8V Octal I/O with Read-while-Write and stack die
About LW/UW series, please contact us freely if you have any questions. For adding Octal NOR Flash IDs, we have validated each Flash on plateform zynq-picozed.
Signed-off-by JaimeLiao <[email protected]>--- drivers/mtd/spi/spi-nor-ids.c | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-)drivers/mtd/spi/spi-nor-ids.c +0
-0drivers/mtd/spi/spi-nor-ids.c const struct flash_info spi_nor_ids[] = { · line 172
Quoted 5 lines
drivers/mtd/spi/spi-nor-ids.c +1
-1@@ -169,7 +169,27 @@ const struct flash_info spi_nor_ids[] = { { INFO("mx66l1g45g", 0xc2201b, 0, 64 * 1024, 2048, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, { INFO("mx25l1633e", 0xc22415, 0, 64 * 1024, 32, SPI_NOR_QUAD_READ | SPI_NOR_4B_OPCODES | SECT_4K) }, { INFO("mx25r6435f", 0xc22817, 0, 64 * 1024, 128, SECT_4K) }, - { INFO("mx66uw2g345g", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw2g345gx0", 0xc2943c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) },Why are you changing the name of this flash?
Quoted 1 line
Other than this, the patch looks good to me.
MX66UW2G345G is similar to MX66UW2G345GX0 and MX66UW2G345G's device ID is 0xc2843c actually.
So that I correct it and add MX66UW2G345GX0 in IDs table.
Quoted 32 lines
Quoted 25 lines
drivers/mtd/spi/spi-nor-ids.c +20
-1+ { INFO("mx66lm1g45g", 0xc2853b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lm51245g", 0xc2853a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lw51245g", 0xc2863a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25lm25645g", 0xc28539, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66um2g45g", 0xc2803c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw2g345g", 0xc2843c, 0, 64 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66um1g45g", 0xc2803b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx66uw1g45g", 0xc2813b, 0, 32 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um51245g", 0xc2803a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw51245g", 0xc2813a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw51345g", 0xc2843a, 0, 16 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um25645g", 0xc28039, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw25645g", 0xc28139, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25um25345g", 0xc28339, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw25345g", 0xc28439, 0, 8 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12845g", 0xc28138, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12a45g", 0xc28938, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw12345g", 0xc28438, 0, 4 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw6445g", 0xc28137, 0, 2 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, + { INFO("mx25uw6345g", 0xc28437, 0, 2 * 1024, 4096, SECT_4K | SPI_NOR_OCTAL_DTR_READ | SPI_NOR_4B_OPCODES) }, #endif #ifdef CONFIG_SPI_FLASH_STMICRO /* STMICRO */ --Quoted 2 lines
2.17.1
--
Regards,
Pratyush Yadav
Texas Instruments Inc.