staging: vt6655: fix camelcase byData in card.c
PATCH v2 1/1 staging: vt6655: fix camelcase byData in card.c
Replace camelcase variable "byData" into linux kernel coding style equivalent variable "data" in card.c.
"by" prefix in hungarian notation stands for byte or unsigned char
References:
- https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
- https://www.kernel.org/doc/html/v4.10/process/coding-style.html
---
Changes since v1:
- Make the commit body message more clearer
drivers/staging/vt6655/card.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/staging/vt6655/card.c +16 -16
@@ -183,7 +183,7 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type)unsigned char bySlot =0 ;unsigned char bySIFS =0 ;unsigned char byDIFS =0 ; -unsigned char byData; +unsigned char data;int i;/* Set SIFS, DIFS, EIFS, SlotTime, CwMin */
@@ -194,15 +194,15 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type) priv->abyBBVGA[0 ] =0x20 ; priv->abyBBVGA[2 ] =0x10 ; priv->abyBBVGA[3 ] =0x10 ; -bb_read_embedded (priv,0xE7 , &byData); -if (byData ==0x1C ) +bb_read_embedded (priv,0xE7 , &data); +if (data ==0x1C )bb_write_embedded (priv,0xE7 , priv->abyBBVGA[0 ]); }else if (priv->byRFType ==RF_UW2452 ) {MACvSetBBType (priv->port_offset,BB_TYPE_11A ); priv->abyBBVGA[0 ] =0x18 ; -bb_read_embedded (priv,0xE7 , &byData); -if (byData ==0x14 ) { +bb_read_embedded (priv,0xE7 , &data); +if (data ==0x14 ) {bb_write_embedded (priv,0xE7 , priv->abyBBVGA[0 ]);bb_write_embedded (priv,0xE1 ,0x57 ); }
@@ -220,14 +220,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type) priv->abyBBVGA[0 ] =0x1C ; priv->abyBBVGA[2 ] =0x00 ; priv->abyBBVGA[3 ] =0x00 ; -bb_read_embedded (priv,0xE7 , &byData); -if (byData ==0x20 ) +bb_read_embedded (priv,0xE7 , &data); +if (data ==0x20 )bb_write_embedded (priv,0xE7 , priv->abyBBVGA[0 ]); }else if (priv->byRFType ==RF_UW2452 ) { priv->abyBBVGA[0 ] =0x14 ; -bb_read_embedded (priv,0xE7 , &byData); -if (byData ==0x18 ) { +bb_read_embedded (priv,0xE7 , &data); +if (data ==0x18 ) {bb_write_embedded (priv,0xE7 , priv->abyBBVGA[0 ]);bb_write_embedded (priv,0xE1 ,0xD3 ); }
@@ -243,14 +243,14 @@ bool CARDbSetPhyParameter(struct vnt_private *priv, u8 bb_type) priv->abyBBVGA[0 ] =0x1C ; priv->abyBBVGA[2 ] =0x00 ; priv->abyBBVGA[3 ] =0x00 ; -bb_read_embedded (priv,0xE7 , &byData); -if (byData ==0x20 ) +bb_read_embedded (priv,0xE7 , &data); +if (data ==0x20 )bb_write_embedded (priv,0xE7 , priv->abyBBVGA[0 ]); }else if (priv->byRFType ==RF_UW2452 ) { priv->abyBBVGA[0 ] =0x14 ; -bb_read_embedded (priv,0xE7 , &byData); -if (byData ==0x18 ) { +bb_read_embedded (priv,0xE7 , &data); +if (data ==0x18 ) {bb_write_embedded (priv,0xE7 , priv->abyBBVGA[0 ]);bb_write_embedded (priv,0xE1 ,0xD3 ); }
@@ -798,12 +798,12 @@ bool CARDbGetCurrentTSF(struct vnt_private *priv, u64 *pqwCurrTSF) {void __iomem *iobase = priv->port_offset;unsigned short ww; -unsigned char byData; +unsigned char data;MACvRegBitsOn (iobase,MAC_REG_TFTCTL ,TFTCTL_TSFCNTRRD );for (ww =0 ; ww <W_MAX_TIMEOUT ; ww++) { -VNSvInPortB (iobase +MAC_REG_TFTCTL , &byData); -if (!(byData &TFTCTL_TSFCNTRRD )) +VNSvInPortB (iobase +MAC_REG_TFTCTL , &data); +if (!(data &TFTCTL_TSFCNTRRD ))break ; }if (ww ==W_MAX_TIMEOUT )
Signature · 1 line
2.25.1
Greg Kroah-Hartman
maintainerQuoted 6 lines · Tommaso Merciai
Replace camelcase variable "byData" into linux kernel coding style equivalent variable "data" in
card.c.
"by" prefix in hungarian notation stands for byte or unsigned charReferences:
- https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htm
Don't provide web links in a changelog text, they might not endure.
Quoted 1 line
- https://www.kernel.org/doc/html/v4.10/process/coding-style.html
Why the old and obsolete 4.10 kernel document?
thanks,
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Tommaso Merciai
Replace camelcase variable "byData" into linux kernel coding style equivalent variable "data" in
card.c.
"by" prefix in hungarian notation stands for byte or unsigned charReferences:
- https://www.cse.iitk.ac.in/users/dsrkg/cs245/html/Guide.htmDon't provide web links in a changelog text, they might not endure.
Quoted 7 lines
Quoted 1 line
- https://www.kernel.org/doc/html/v4.10/process/coding-style.html
Why the old and obsolete 4.10 kernel document?
thanks,
greg k-h
Hi Greg,
I'll update and resend.
Thanks,
Tommaso