Skip to contentSkip to conversation

package/fastd: bump version to 22

PATCH Applied Alexander Dahl 2 participants 2 messages Oct 17, 2021 – Oct 18, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/fastd: bump version to 22

There's a new feature to offload L2TP to the Linux kernel, which depends on libmnl. A new menu option was introduced for that.

It's possible to link an internal version of libmnl statically for smaller binary size on constraint targets, but this was not added to the buildroot package for complexity reasons (both build and licensing).

The COPYING file gained an additional paragraph for internal libmnl which does not apply, because internal libmnl is not used in the package.

---
 package/fastd/Config.in  | 8 ++++++++
 package/fastd/fastd.hash | 4 ++--
 package/fastd/fastd.mk   | 9 ++++++++-
 3 files changed, 18 insertions(+), 3 deletions(-)
package/fastd/Config.in +8 -0
index 5319d68503..0214786470 100644
@@ -21,6 +21,14 @@ config BR2_PACKAGE_FASTD_STATUS_SOCKET
 	help
 	  Enable support for a socket to get fastd's status.
 
+config BR2_PACKAGE_FASTD_OFFLOAD_L2TP
+	bool "l2tp offload support"
+	default y
+	select BR2_PACKAGE_LIBMNL
+	help
+	  L2TP can be offloaded to the Linux kernel, significantly
+	  increasing throughput.
+
 endif
 
 comment "fastd needs a toolchain w/ threads, dynamic library"
package/fastd/fastd.hash +2 -2
index b59085e0ee..5f7f966533 100644
@@ -1,3 +1,3 @@
 # computed locally
-sha256  942f33bcd794bcb8e19da4c30c875bdfd4d0f1c24ec4dcdf51237791bbfb0d4c  fastd-21.tar.xz
-sha256  1f5acece57466eac89108f934a196be09b7676fa2d637e78d6657ee1a7d644ac  COPYRIGHT
+sha256  19750b88705d66811b7c21b672537909c19ae6b21350688cbd1a3a54d08a8951  fastd-22.tar.xz
+sha256  adf08b42f1b890b89e998360a864cb4f8441a0a57c9e95e2ce1bfdfc24c49976  COPYRIGHT
package/fastd/fastd.mk +8 -1
index c1db1cc472..5cd6a909c3 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-FASTD_VERSION = 21
+FASTD_VERSION = 22
 FASTD_SITE = https://github.com/NeoRaider/fastd/releases/download/v$(FASTD_VERSION)
 FASTD_SOURCE = fastd-$(FASTD_VERSION).tar.xz
 FASTD_LICENSE = BSD-2-Clause
@@ -33,6 +33,13 @@ else
 FASTD_CONF_OPTS += -Dstatus_socket=disabled
 endif
 
+ifeq ($(BR2_PACKAGE_FASTD_OFFLOAD_L2TP),y)
+FASTD_CONF_OPTS += -Doffload_l2tp=enabled -Dlibmnl_builtin=false
+FASTD_DEPENDENCIES += libmnl
+else
+FASTD_CONF_OPTS += -Doffload_l2tp=disabled
+endif
+
 ifeq ($(BR2_INIT_SYSTEMD),y)
 FASTD_CONF_OPTS += -Dsystemd=enabled
 else

base-commit: 55ae6b59d48dd75f4e432b63e5b8a4655b76305c

Signature · 6 lines
2.20.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw
Quoted 11 lines · On Sun, 17 Oct 2021 17:25:11 +0200 Alexander Dahl <[email protected]> wrote:

There's a new feature to offload L2TP to the Linux kernel, which depends on libmnl. A new menu option was introduced for that.

It's possible to link an internal version of libmnl statically for smaller binary size on constraint targets, but this was not added to the buildroot package for complexity reasons (both build and licensing).

The COPYING file gained an additional paragraph for internal libmnl which does not apply, because internal libmnl is not used in the package.

Thanks for providing this explanation, very good!

package/fastd/Config.in config BR2_PACKAGE_FASTD_STATUS_SOCKET · line 26

Quoted 3 lines
package/fastd/Config.in +3 -0
+config BR2_PACKAGE_FASTD_OFFLOAD_L2TP
+	bool "l2tp offload support"
+	default y

I don't think there was much reason for this option to be enabled by default, and we try to not enable optional features by default in Buildroot, so I dropped this "default y" when applying.

Applied to master this change. Thanks!

Best regards,

Thomas

Signature · 7 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot