Skip to contentSkip to conversation

arm64: dts: qcom: sdm845-oneplus: enable second wifi channel

PATCH In review Caleb Connolly 2 participants 3 messages Oct 20, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm64: dts: qcom: sdm845-oneplus: enable second wifi channel

Like the c630, the OnePlus 6 is also capable of using both antenna channels for 2.4 and 5ghz wifi, however unlike the c630 only the first channel is used for bluetooth.

---
 arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi +7 -0
index d4355522374a..8bf2430a3af7 100644
@@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
 			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
 		};
 
+		vreg_l23a_3p3: ldo23 {
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3312000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
 		vdda_qusb_hs0_3p1:
 		vreg_l24a_3p075: ldo24 {
 			regulator-min-microvolt = <3088000>;
@@ -647,6 +653,7 @@ &wifi {
 	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
 	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
 	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 
 	qcom,snoc-host-cap-8bit-quirk;
 };

--
2.33.1

#1 lore raw

Hi Caleb,

Quoted 35 lines · Caleb Connolly

Like the c630, the OnePlus 6 is also capable of using both antenna channels for 2.4 and 5ghz wifi, however unlike the c630 only the first channel is used for bluetooth.

---
  arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
  1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi +7 -1
index d4355522374a..8bf2430a3af7 100644
@@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
  		};
 
+		vreg_l23a_3p3: ldo23 {
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3312000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
  		vdda_qusb_hs0_3p1:
  		vreg_l24a_3p075: ldo24 {
  			regulator-min-microvolt = <3088000>;
@@ -647,6 +653,7 @@ &wifi {
  	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
  	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
  	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 
  	qcom,snoc-host-cap-8bit-quirk;
  };
--
Quoted 3 lines

2.33.1

Just for the record, I added it for completeness, as far as I can tell, the bluetooth driver itself won't use the second channel.

-- steev

#2 lore raw

Hi Steev,

Quoted 35 lines · Steev Klimaszewski

Hi Caleb,

Quoted 32 lines · Caleb Connolly

Like the c630, the OnePlus 6 is also capable of using both antenna channels for 2.4 and 5ghz wifi, however unlike the c630 only the first channel is used for bluetooth.

---
   arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
   1 file changed, 7 insertions(+)
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi +7 -0
index d4355522374a..8bf2430a3af7 100644
@@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
   			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
   		};
 
+		vreg_l23a_3p3: ldo23 {
+			regulator-min-microvolt = <3300000>;
+			regulator-max-microvolt = <3312000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
   		vdda_qusb_hs0_3p1:
   		vreg_l24a_3p075: ldo24 {
   			regulator-min-microvolt = <3088000>;
@@ -647,6 +653,7 @@ &wifi {
   	vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
   	vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
   	vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+	vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
 
Quoted 8 lines
Quoted 6 lines
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi +0 -1
   	qcom,snoc-host-cap-8bit-quirk;
   };
--

2.33.1

Just for the record, I added it for completeness, as far as I can tell, the bluetooth driver itself won't use the second channel.

Ah I see, I can confirm that the bluetooth hardware is only connected to the first channel on the op6, so with wifi off the second antenna can also be turned off to save power without affecting bluetooth signal strength.

Quoted 4 lines

-- steev

--
Kind Regards,
Caleb