maintainers: update for driver testing tool

PATCH In review Aman Singh 3 participants 11 messages Oct 22, 2021 – Nov 26, 2021

lore

Share & tools

lore

Aman Singh

author

2021-10-22 07:31 UTC #0 lore raw

PATCH 1/1 maintainers: update for driver testing tool

For test-pmd adding Aman Singh

Signed-off-by Aman Singh <[email protected]>

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

MAINTAINERS +1 -0

index 278e5b3226..c4070fe668 100644
@@ -1637,6 +1637,7 @@ F: app/test/sample_packet_forward.h
 
 Driver testing tool
 M: Xiaoyun Li <[email protected]>
+M: Aman Singh <[email protected]>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/

Signature · 1 line

2.17.1

Ferruh Yigit

Acked-by on v1 1/1

2021-10-22 08:57 UTC #1 lore raw

Quoted 3 lines · Aman Singh

For test-pmd adding Aman Singh
Signed-off-by Aman Singh <[email protected]>

Thanks Aman for volunteering.

Acked-by Ferruh Yigit <[email protected]>

Thomas Monjalon

2021-11-25 10:00 UTC #2 lore raw

22/10/2021 10:57, Ferruh Yigit:

Quoted 8 lines · Aman Singh

Quoted 3 lines
For test-pmd adding Aman Singh
Signed-off-by Aman Singh <[email protected]>
Thanks Aman for volunteering.
Acked-by Ferruh Yigit <[email protected]>

I'll take this opportunity to update the section title. v2 coming.

Thomas Monjalon

2021-11-25 10:02 UTC #3 lore raw

PATCH v2 1/1 maintainers: update for testpmd

In reply to Aman Singh

From: Aman Singh <[email protected]>

Add Aman Singh as co-maintainer of testpmd.

Make the title description more accurate for this tool.

Signed-off-by Aman Singh <[email protected]>

Acked-by Ferruh Yigit <[email protected]>

Signed-off-by Thomas Monjalon <[email protected]>

---
v2: update the section title

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

MAINTAINERS +2 -1

index d785363c5c..1b259a3d98 100644
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <[email protected]>
 F: app/test/sample_packet_forward.c
 F: app/test/sample_packet_forward.h
 
-Driver testing tool
+Networking features testing tool
 M: Xiaoyun Li <[email protected]>
+M: Aman Singh <[email protected]>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/

Signature · 1 line

2.33.0

Ferruh Yigit

2021-11-25 13:41 UTC #4 lore raw

Re: [PATCH v2] maintainers: update for testpmd

Quoted 20 lines · Thomas Monjalon

From: Aman Singh <[email protected]>
Add Aman Singh as co-maintainer of testpmd.
Make the title description more accurate for this tool.
Signed-off-by Aman Singh <[email protected]>
Acked-by Ferruh Yigit <[email protected]>
Signed-off-by Thomas Monjalon <[email protected]>
---
v2: update the section title
---
  MAINTAINERS | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
MAINTAINERS +0 -0
index d785363c5c..1b259a3d98 100644

MAINTAINERS M: Reshma Pattan <[email protected]> · line 1694

Quoted 5 lines

MAINTAINERS +1 -1

@@ -1691,8 +1691,9 @@ M: Reshma Pattan <[email protected]>
  F: app/test/sample_packet_forward.c
  F: app/test/sample_packet_forward.h
 
-Driver testing tool
+Networking features testing tool

"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing.

Quoted 6 lines

MAINTAINERS +1 -0

  M: Xiaoyun Li <[email protected]>
+M: Aman Singh <[email protected]>
  T: git://dpdk.org/next/dpdk-next-net
  F: app/test-pmd/
  F: doc/guides/testpmd_app_ug/

Thomas Monjalon

2021-11-25 15:20 UTC #5 lore raw

Re: [PATCH v2] maintainers: update for testpmd

25/11/2021 14:40, Ferruh Yigit:

Quoted 7 lines · Thomas Monjalon

MAINTAINERS M: Reshma Pattan <[email protected]> · line 1694
Quoted 2 lines
MAINTAINERS +1 -1
-Driver testing tool
+Networking features testing tool
"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing.

Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf which is also testing networking drivers.

Maybe "Networking drivers features testing tool" ?

Ferruh Yigit

2021-11-25 16:05 UTC #6 lore raw

Re: [PATCH v2] maintainers: update for testpmd

Quoted 9 lines · Thomas Monjalon

25/11/2021 14:40, Ferruh Yigit:
Quoted 7 lines · Thomas Monjalon
MAINTAINERS M: Reshma Pattan <[email protected]> · line 1694
Quoted 2 lines
MAINTAINERS +1 -1
-Driver testing tool
+Networking features testing tool
"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing.

Quoted 6 lines

Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf which is also testing networking drivers.
Maybe "Networking drivers features testing tool" ?

ack

Ferruh Yigit

2021-11-25 16:31 UTC #7 lore raw

Re: [PATCH v2] maintainers: update for testpmd

Quoted 10 lines · Ferruh Yigit

Quoted 9 lines · Thomas Monjalon
25/11/2021 14:40, Ferruh Yigit:
Quoted 7 lines · Thomas Monjalon
MAINTAINERS M: Reshma Pattan <[email protected]> · line 1694
Quoted 2 lines
MAINTAINERS +1 -1
-Driver testing tool
+Networking features testing tool
"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing.

Quoted 9 lines

Quoted 6 lines
Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf which is also testing networking drivers.
Maybe "Networking drivers features testing tool" ?
ack

thinking twice what additional meaning does 'features' adds here, "Networking drivers features testing"
vs
"Networking drivers testing"

Isn't "Networking drivers testing" implies features of drivers?

Thomas Monjalon

2021-11-25 16:56 UTC #8 lore raw

Re: [PATCH v2] maintainers: update for testpmd

25/11/2021 17:31, Ferruh Yigit:

Quoted 21 lines · Ferruh Yigit

Quoted 10 lines · Thomas Monjalon
Quoted 9 lines
25/11/2021 14:40, Ferruh Yigit:
Quoted 7 lines · Thomas Monjalon
MAINTAINERS M: Reshma Pattan <[email protected]> · line 1694
Quoted 2 lines
MAINTAINERS +1 -1
-Driver testing tool
+Networking features testing tool
"Networking features" scope is a little wide.
Not sure if "Networking features" or "Networking drivers" suits better, according previous title it is for driver testing.
Quoted 9 lines
Quoted 6 lines
Yes it is for drivers features.
I want to distinguish testpmd and other tools like test-flow-perf which is also testing networking drivers.
Maybe "Networking drivers features testing tool" ?
ack

Quoted 6 lines

thinking twice what additional meaning does 'features' adds here, "Networking drivers features testing"
vs
"Networking drivers testing"
Isn't "Networking drivers testing" implies features of drivers?

Yes
I was trying to avoid being too generic, because the same title could apply to flow-perf. But not mentioning "performance" should be enough.

OK for "Networking drivers testing tool"

Thomas Monjalon

2021-11-26 10:05 UTC #9 lore raw

PATCH v3 1/1 maintainers: update for testpmd

In reply to Aman Singh

From: Aman Singh <[email protected]>

Add Aman Singh as co-maintainer of testpmd.

Make the title description more accurate for this tool.

Signed-off-by Aman Singh <[email protected]>

Acked-by Ferruh Yigit <[email protected]>

Signed-off-by Thomas Monjalon <[email protected]>

---
v2: update the section title
v3: update the section title

---
 MAINTAINERS | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

MAINTAINERS +2 -1

index d785363c5c..6e520ca560 100644
@@ -1691,8 +1691,9 @@ M: Reshma Pattan <[email protected]>
 F: app/test/sample_packet_forward.c
 F: app/test/sample_packet_forward.h
 
-Driver testing tool
+Networking drivers testing tool
 M: Xiaoyun Li <[email protected]>
+M: Aman Singh <[email protected]>
 T: git://dpdk.org/next/dpdk-next-net
 F: app/test-pmd/
 F: doc/guides/testpmd_app_ug/

Signature · 1 line

2.33.0

Thomas Monjalon

Applied

2021-11-26 11:14 UTC #10 lore raw

Re: [PATCH v3] maintainers: update for testpmd

26/11/2021 11:04, Thomas Monjalon:

Quoted 9 lines

From: Aman Singh <[email protected]>
Add Aman Singh as co-maintainer of testpmd.
Make the title description more accurate for this tool.
Signed-off-by Aman Singh <[email protected]>
Acked-by Ferruh Yigit <[email protected]>
Signed-off-by Thomas Monjalon <[email protected]>

Applied

Thanks Aman for volunteering.