package/qemu: bump host gcc requirements: propagate to all reverse dependencies

PATCH Superseded Adam Duskett 3 participants 3 messages Oct 25, 2021

lore

Share & tools

lore

Adam Duskett

author

2021-10-25 20:00 UTC #0 lore raw

PATCH 1/1 package/qemu: bump host gcc requirements: propagate to all reverse dependencies

qemu now requires gcc >= 7.5, however, as there is no BR2_HOST_GCC_AT_LEAST_7_5, set the host gcc requirements to 8.

In addition:
- Propagate the host gcc dependency to gobject-introspection as it was missing to begin with.
- Propagate the host gcc dependency to nodejs
- Add a missing comment in package/qemu/Config.in.host explaining the host gcc requirements if host gcc < 8.

Fixes:
http://autobuild.buildroot.org/results/32b7fee1f8cda2290fd4bd8ac9fe78bacb25b652

Signed-off-by Adam Duskett <[email protected]>

---
 package/gobject-introspection/Config.in | 3 ++-
 package/nodejs/Config.in                | 6 +++---
 package/qemu/Config.in.host             | 7 ++++++-
 3 files changed, 11 insertions(+), 5 deletions(-)

package/gobject-introspection/Config.in +2 -1

index bacf44363c..15b6bc3bfa 100644
@@ -13,6 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
 	# compile errors with locale.c. As such, require 4.9 until this
 	# can be verified.
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_HOST_GCC_AT_LEAST_8 # qemu
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	# gobject-introspection does not require python3 to run on the
 	# target; however, because the tools run in a qemu wrapper, a

@@ -41,7 +42,7 @@ comment "gobject-introspection needs python3"
 	depends on !BR2_PACKAGE_PYTHON3
 	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
 
-comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9"
+comment "gobject-introspection needs a glibc toolchain, gcc >= 4.9, host gcc >= 8"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_USES_GLIBC || \

package/nodejs/Config.in +3 -3

index 771f735e97..99c76bc3de 100644
@@ -8,18 +8,18 @@ config BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_PACKAGE_QEMU_ARCH_SUPPORTS_TARGET
 
-comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 7, wchar"
+comment "nodejs needs a toolchain w/ C++, dynamic library, NPTL, gcc >= 7, wchar, host gcc >= 8"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS_NPTL || \
-		!BR2_HOST_GCC_AT_LEAST_7 || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR
+		!BR2_HOST_GCC_AT_LEAST_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_7 || !BR2_USE_WCHAR
 
 config BR2_PACKAGE_NODEJS
 	bool "nodejs"
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # libuv
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_PACKAGE_NODEJS_ARCH_SUPPORTS
-	depends on BR2_HOST_GCC_AT_LEAST_7
+	depends on BR2_HOST_GCC_AT_LEAST_8 # qemu
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7
 	depends on BR2_USE_WCHAR
 	# uses fork()

package/qemu/Config.in.host +6 -1

index a5b38c081b..df5d921125 100644
@@ -37,7 +37,7 @@ config BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
 config BR2_PACKAGE_HOST_QEMU
 	bool "host qemu"
 	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
-	depends on BR2_HOST_GCC_AT_LEAST_7
+	depends on BR2_HOST_GCC_AT_LEAST_8
 	select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE \
 		if !BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE && BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORTS
 	select BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE \

@@ -50,6 +50,11 @@ config BR2_PACKAGE_HOST_QEMU
 
 	  http://www.qemu.org
 
+comment "host-qemu needs a host gcc >= 8"
+	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS || \
+		BR2_PACKAGE_HOST_QEMU_USER_ARCH_SUPPORT
+	depends on !BR2_HOST_GCC_AT_LEAST_8
+
 if BR2_PACKAGE_HOST_QEMU
 
 comment "Emulators selection"

Signature · 6 lines

2.32.0

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Arnout Vandecappelle

2021-10-25 20:20 UTC #1 lore raw

Quoted 25 lines · Adam Duskett

qemu now requires gcc >= 7.5, however, as there is no BR2_HOST_GCC_AT_LEAST_7_5, set the host gcc requirements to 8.
In addition:
- Propagate the host gcc dependency to gobject-introspection as it was missing to begin with.
- Propagate the host gcc dependency to nodejs
- Add a missing comment in package/qemu/Config.in.host explaining the host gcc requirements if host gcc < 8.
Fixes:
http://autobuild.buildroot.org/results/32b7fee1f8cda2290fd4bd8ac9fe78bacb25b652
Signed-off-by Adam Duskett <[email protected]>
---
  package/gobject-introspection/Config.in | 3 ++-
  package/nodejs/Config.in                | 6 +++---
  package/qemu/Config.in.host             | 7 ++++++-
  3 files changed, 11 insertions(+), 5 deletions(-)
package/gobject-introspection/Config.in +0 -0
index bacf44363c..15b6bc3bfa 100644

package/gobject-introspection/Config.in config BR2_PACKAGE_GOBJECT_INTROSPECTION · line 16

Quoted 4 lines

package/gobject-introspection/Config.in +1 -0

@@ -13,6 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
  	# compile errors with locale.c. As such, require 4.9 until this
  	# can be verified.
  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_HOST_GCC_AT_LEAST_8 # qemu

Ha, Yann just applied [1] so this will need to be refreshed...

Regards,
Arnout

[1] https://patchwork.ozlabs.org/project/buildroot/patch/[email protected]/

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

Yann E. MORIN

2021-10-25 20:32 UTC #2 lore raw

Arnout, All,

On 2021-10-25 22:19 +0200, Arnout Vandecappelle spake thusly:

Quoted 21 lines · Adam Duskett

Quoted 20 lines
qemu now requires gcc >= 7.5, however, as there is no BR2_HOST_GCC_AT_LEAST_7_5, set the host gcc requirements to 8.
In addition:
- Propagate the host gcc dependency to gobject-introspection as it was missing to begin with.
- Propagate the host gcc dependency to nodejs
- Add a missing comment in package/qemu/Config.in.host explaining the host gcc requirements if host gcc < 8.
Fixes:
http://autobuild.buildroot.org/results/32b7fee1f8cda2290fd4bd8ac9fe78bacb25b652
Signed-off-by Adam Duskett <[email protected]>
---
 package/gobject-introspection/Config.in | 3 ++-
 package/nodejs/Config.in                | 6 +++---
 package/qemu/Config.in.host             | 7 ++++++-
 3 files changed, 11 insertions(+), 5 deletions(-)

Quoted 11 lines

package/gobject-introspection/Config.in config BR2_PACKAGE_GOBJECT_INTROSPECTION · line 16
Quoted 9 lines
package/gobject-introspection/Config.in +1 -0
index bacf44363c..15b6bc3bfa 100644
@@ -13,6 +13,7 @@ config BR2_PACKAGE_GOBJECT_INTROSPECTION
 	# compile errors with locale.c. As such, require 4.9 until this
 	# can be verified.
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_9
+	depends on BR2_HOST_GCC_AT_LEAST_8 # qemu
Ha, Yann just applied [1] so this will need to be refreshed...

Yes, we were talking about that with Adam on IRC just at the same time he was sending it. V2 has already been posted, now! ;-)

Regards,
Yann E. MORIN.

Signature · 10 lines

.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot