switch to using crun for podman
Mimi Zohar
maintainerPATCH 1/2 switch to using crun for podman
Fix for:
"container_linux.go:367: starting container process caused: error adding seccomp filter rule for syscall bdflush: permission denied":
OCI permission denied"
--- .travis.yml | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
.travis.yml +4 -7
@@ -32,7 +32,7 @@ matrix: # glibc (gcc/clang) - os: linux - env: DISTRO=opensuse/tumbleweed TSS=ibmtss CONTAINER=podman CONTAINER_ARGS="--runtime=/usr/bin/runc --network=host" COMPILE_SSL=openssl-3.0.0-beta1 + env: DISTRO=opensuse/tumbleweed TSS=ibmtss CONTAINER=podman CONTAINER_ARGS="--runtime=/usr/bin/crun --network=host" COMPILE_SSL=openssl-3.0.0-beta1 compiler: clang - os: linux
@@ -72,7 +72,8 @@ matrix: compiler: gcc before_install: - # Tumbleweed requires podman and newest runc due docker incompatible with glibc 2.33 (faccessat2) + # Tumbleweed requires podman due docker incompatible with glibc 2.33 + # (faccessat2) and crun (for clone3). - CONTAINER="${CONTAINER:-docker}" - > if [ "$CONTAINER" = "podman" ]; then
@@ -81,11 +82,7 @@ before_install: sudo sh -c "echo 'deb http://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/xUbuntu_${VERSION_ID}/ /' > /etc/apt/sources.list.d/devel:kubic:libcontainers:stable.list" wget -nv https://download.opensuse.org/repositories/devel:kubic:libcontainers:stable/xUbuntu_${VERSION_ID}/Release.key -O- | sudo apt-key add - sudo apt update - sudo apt -y install podman slirp4netns - - # runc - sudo curl -L https://github.com/opencontainers/runc/releases/download/v1.0.0-rc93/runc.amd64 -o /usr/bin/runc - sudo chmod +x /usr/bin/runc + sudo apt -y install podman slirp4netns crun fi - $CONTAINER info
Signature · 1 line
2.27.0
Mimi Zohar
maintainerPATCH 2/2 upgrade to glibc-2.34 uses clone3 causing CI to fail
Both opensuse/tumbleweed and Alt Linux have upgraded to glibc-2.34, causing the CI testing to fail. Disable seccomp (which is not needed anyway, since GA uses throwable virtual environments anyway).
options: --security-opt seccomp=unconfined
--- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+)
.github/workflows/ci.yml +1 -0
@@ -103,6 +103,7 @@ jobs: container: image: ${{ matrix.container }} env: ${{ matrix.env }} + options: --security-opt seccomp=unconfined steps: - name: Show OS
Signature · 1 line
2.27.0
Re: [PATCH ima-evm-utils 2/2] upgrade to glibc-2.34 uses clone3 causing CI to fail
Mimi,
Quoted 3 lines · Mimi Zohar
Both opensuse/tumbleweed and Alt Linux have upgraded to glibc-2.34, causing the CI testing to fail. Disable seccomp (which is not needed anyway, since GA uses throwable virtual environments anyway).
JFYI. We decided to update our glibc package to fall-back from clone3 to clone in case it's EPERM. So, after some time (perhaps a day) this workaround will not be needed for ALT Linux. But this will not hurts either and may be beneficial in the future.
Thanks,
Quoted 24 lines
options: --security-opt seccomp=unconfined
Suggested-by Vitaly Chikunov <[email protected]>Acked-by Petr Vorel <[email protected]>Signed-off-by Mimi Zohar <[email protected]>--- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+).github/workflows/ci.yml +1
-0@@ -103,6 +103,7 @@ jobs: container: image: ${{ matrix.container }} env: ${{ matrix.env }} + options: --security-opt seccomp=unconfined steps: - name: Show OSSignature · 1 line
2.27.0
Re: [PATCH ima-evm-utils 2/2] upgrade to glibc-2.34 uses clone3 causing CI to fail
Hi Vitaly,
Quoted 11 lines
Mimi,
Quoted 3 lines · Mimi Zohar
Both opensuse/tumbleweed and Alt Linux have upgraded to glibc-2.34, causing the CI testing to fail. Disable seccomp (which is not needed anyway, since GA uses throwable virtual environments anyway).
JFYI. We decided to update our glibc package to fall-back from clone3 to clone in case it's EPERM. So, after some time (perhaps a day) this workaround will not be needed for ALT Linux. But this will not hurts either and may be beneficial in the future.
I see, 09e37c71 ("__clone_internal: fallback to clone(2)/clone2(2) if clone3(2) fails with EPERM" [1]. Interesting.
Kind regards,
Petr
Re: [PATCH ima-evm-utils 2/2] upgrade to glibc-2.34 uses clone3 causing CI to fail
In reply to Vitaly ChikunovHi,
Quoted 11 lines · Vitaly Chikunov
Mimi,
Quoted 3 lines · Mimi Zohar
Both opensuse/tumbleweed and Alt Linux have upgraded to glibc-2.34, causing the CI testing to fail. Disable seccomp (which is not needed anyway, since GA uses throwable virtual environments anyway).
JFYI. We decided to update our glibc package to fall-back from clone3 to clone in case it's EPERM. So, after some time (perhaps a day) this workaround will not be needed for ALT Linux. But this will not hurts either and may be beneficial in the future.
Citing myself [3]:
"you must have missed the whole discussion on this subject [1][2], the consensus was that problematic container runtimes need to be fixed to make their seccomp filters return ENOSYS for unknown syscalls.
[1] https://sourceware.org/pipermail/libc-alpha/2020-November/119955.html
[2] https://lore.kernel.org/linux-api/[email protected]/T/#u
"
That discussion was about a different syscall, but the problem is essentially the same, and all who commented on the subject more or less vehemently rejected the idea of adding this kind of hacks into glibc. Therefore, I think that change in ALT glibc has to be reconsidered, and problematic container runtimes have to be fixed instead.
[3] https://sourceware.org/pipermail/libc-alpha/2021-February/123008.html
Signature · 1 line
ldv
Hi Mimi,
Quoted 5 lines
Fix for:
"container_linux.go:367: starting container process caused: error adding seccomp filter rule for syscall bdflush: permission denied":
OCI permission denied"
I was surprised crun is updated but runc not, but LGTM.
It'd be nice if somebody test it with public travis (I no longer have access).
IMHO from a long term perspective it'd be nice to create GitHub Actions profile (but that's not related to this patchset).
Kind regards,
Petr
Mimi Zohar
maintainerHi Petr,
Quoted 10 lines · Petr Vorel
Hi Mimi,
Quoted 5 lines
Fix for:
"container_linux.go:367: starting container process caused: error adding seccomp filter rule for syscall bdflush: permission denied":
OCI permission denied"I was surprised crun is updated but runc not, but LGTM.
It'd be nice if somebody test it with public travis (I no longer have access).
Stefan tested on the public travis, which resulted in updating Alpine, Fedora, and Alt to use podman and crun. Other than the alt:sisyphus image prompt, the tests all pass. I assume this is intermittent.
Please select an image:
▸ docker.io/library/alt:sisyphus
quay.io/alt:sisyphus
Quoted 2 lines
Reviewed-by Petr Vorel <[email protected]>
thanks!
Mimi
Quoted 3 lines
IMHO from a long term perspective it'd be nice to create GitHub Actions profile (but that's not related to this patchset).