net: lan78xx: fix division by zero in send path
Subsystems (6)
PATCH 1/1 net: lan78xx: fix division by zero in send path
Add the missing endpoint max-packet sanity check to probe() to avoid division by zero in lan78xx_tx_bh() in case a malicious device has broken descriptors (or when doing descriptor fuzz testing).
Note that USB core will reject URBs submitted for endpoints with zero wMaxPacketSize but that drivers doing packet-size calculations still need to handle this (cf. commit 2548288b4fb0 ("USB: Fix: Don't skip endpoint descriptors with maxpacket=0")).
--- drivers/net/usb/lan78xx.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/net/usb/lan78xx.c +6 -0
@@ -4122,6 +4122,12 @@ static int lan78xx_probe(struct usb_interface *intf, dev->maxpacket =usb_maxpacket (dev->udev, dev->pipe_out,1 ); +/* Reject broken descriptors. */ +if (dev->maxpacket ==0 ) { + ret = -ENODEV ; + goto out4; + } +/* driver requires remote-wakeup capability during autosuspend. */ intf->needs_remote_wakeup =1 ;
Signature · 1 line
2.32.0
This patch was applied to netdev/net.git (master) by David S. Miller <[email protected]>:
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <[email protected]>:
Quoted 10 lines · On Tue, 26 Oct 2021 12:36:17 +0200 you wrote:
Add the missing endpoint max-packet sanity check to
probe()to avoid division by zero inlan78xx_tx_bh()in case a malicious device has broken descriptors (or when doing descriptor fuzz testing).Note that USB core will reject URBs submitted for endpoints with zero wMaxPacketSize but that drivers doing packet-size calculations still need to handle this (cf. commit
2548288b4fb0("USB: Fix: Don't skip endpoint descriptors with maxpacket=0")).[...]
Here is the summary with links:
- net: lan78xx: fix division by zero in send path
https://git.kernel.org/netdev/net/c/db6c3c064f5d
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html